bug#59828: Fundamental Mode buffers fail to keep text properties

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Have noticed that when I insert text with colour properties in a buffer
using fundamental-mode, the text properties (e.g. colours) get lost.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Yuan Fu]

> On Dec 4, 2022, at 10:30 PM, Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
> 
> 
> Have noticed that when I insert text with colour properties in a buffer
> using fundamental-mode, the text properties (e.g. colours) get lost.

I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?

Yuan

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 6:32 AM, Yuan Fu <casouri@gmail.com> wrote:


> > On Dec 4, 2022, at 10:30 PM, Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org wrote:
> > 
> > Have noticed that when I insert text with colour properties in a buffer
> > using fundamental-mode, the text properties (e.g. colours) get lost.
> 
> 
> I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?
> 
> Yuan

I used 'font-lock-face and did not work.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Eli Zaretskii]

> Cc: 59828@debbugs.gnu.org
> Date: Mon, 05 Dec 2022 08:30:51 +0000
> From:  Heime via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> > > Have noticed that when I insert text with colour properties in a buffer
> > > using fundamental-mode, the text properties (e.g. colours) get lost.
> > 
> > 
> > I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?
> > 
> > Yuan
> 
> I used 'font-lock-face and did not work.

Please show the code you used.  It works here.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 12:46 PM, Eli Zaretskii <eliz@gnu.org> wrote:


> > Cc: 59828@debbugs.gnu.org
> > Date: Mon, 05 Dec 2022 08:30:51 +0000
> > From: Heime via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" bug-gnu-emacs@gnu.org
> > 
> > > > Have noticed that when I insert text with colour properties in a buffer
> > > > using fundamental-mode, the text properties (e.g. colours) get lost.
> > > 
> > > I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?
> > > 
> > > Yuan
> > 
> > I used 'font-lock-face and did not work.
> 
> 
> Please show the code you used. It works here.


(with-current-buffer (get-buffer-create bufrn)
  (insert (propertize "G"
             'font-lock-face '(:background "green"
                               :foreground "black"))))

bug#59828: Fundamental Mode buffers fail to keep text properties

[Eli Zaretskii]

> Date: Mon, 05 Dec 2022 13:49:28 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> 
> > > > > Have noticed that when I insert text with colour properties in a buffer
> > > > > using fundamental-mode, the text properties (e.g. colours) get lost.
> > > > 
> > > > I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?
> > > > 
> > > > Yuan
> > > 
> > > I used 'font-lock-face and did not work.
> > 
> > 
> > Please show the code you used. It works here.
> 
> 
> (with-current-buffer (get-buffer-create bufrn)
>   (insert (propertize "G"
>              'font-lock-face '(:background "green"
>                                :foreground "black"))))

From the ELisp manual:

  ‘font-lock-face’
       This property specifies a value for the ‘face’ property that Font
       Lock mode should apply to the underlying text.  It is one of the
       fontification methods used by Font Lock mode, and is useful for
       special modes that implement their own highlighting.  *Note
       Precalculated Fontification::.  When Font Lock mode is disabled,
       ‘font-lock-face’ has no effect.

Note the last sentence.

Conclusion: you need to turn on font-lock in that buffer.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 2:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:


> > Date: Mon, 05 Dec 2022 13:49:28 +0000
> > From: Heime heimeborgia@protonmail.com
> > Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> > 
> > > > > > Have noticed that when I insert text with colour properties in a buffer
> > > > > > using fundamental-mode, the text properties (e.g. colours) get lost.
> > > > > 
> > > > > I assume you used the ‘face property, right? If you replace ‘face with 'font-lock-face, does it work?
> > > > > 
> > > > > Yuan
> > > > 
> > > > I used 'font-lock-face and did not work.
> > > 
> > > Please show the code you used. It works here.
> > 
> > (with-current-buffer (get-buffer-create bufrn)
> > (insert (propertize "G"
> > 'font-lock-face '(:background "green"
> > :foreground "black"))))
> 
> 
> From the ELisp manual:
> 
> ‘font-lock-face’
> This property specifies a value for the ‘face’ property that Font
> Lock mode should apply to the underlying text. It is one of the
> fontification methods used by Font Lock mode, and is useful for
> special modes that implement their own highlighting. *Note
> Precalculated Fontification::. When Font Lock mode is disabled,
> ‘font-lock-face’ has no effect.
> 
> Note the last sentence.
> 
> Conclusion: you need to turn on font-lock in that buffer.
> 

When I use (text-mode) or (org-mode), I do not get the problem.

(with-current-buffer (get-buffer-create bufrn)
 (text-mode)
 (insert (propertize "G"
 'font-lock-face '(:background "green"
 :foreground "black"))))

bug#59828: Fundamental Mode buffers fail to keep text properties

[Eli Zaretskii]

> Date: Mon, 05 Dec 2022 14:54:47 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> 
> > Conclusion: you need to turn on font-lock in that buffer.
> > 
> 
> When I use (text-mode) or (org-mode), I do not get the problem.
> 
> (with-current-buffer (get-buffer-create bufrn)
>  (text-mode)
>  (insert (propertize "G"
>  'font-lock-face '(:background "green"
>  :foreground "black"))))

Because those turn on font-lock by default.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 3:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:


> > Date: Mon, 05 Dec 2022 14:54:47 +0000
> > From: Heime heimeborgia@protonmail.com
> > Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> > 
> > > Conclusion: you need to turn on font-lock in that buffer.
> > 
> > When I use (text-mode) or (org-mode), I do not get the problem.
> > 
> > (with-current-buffer (get-buffer-create bufrn)
> > (text-mode)
> > (insert (propertize "G"
> > 'font-lock-face '(:background "green"
> > :foreground "black"))))
> 
> 
> Because those turn on font-lock by default.

What do you think about having fundamental-mode also turn font-lock on ?

bug#59828: Fundamental Mode buffers fail to keep text properties

[Eli Zaretskii]

> Date: Mon, 05 Dec 2022 15:06:09 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> 
> > > > Conclusion: you need to turn on font-lock in that buffer.
> > > 
> > > When I use (text-mode) or (org-mode), I do not get the problem.
> > > 
> > > (with-current-buffer (get-buffer-create bufrn)
> > > (text-mode)
> > > (insert (propertize "G"
> > > 'font-lock-face '(:background "green"
> > > :foreground "black"))))
> > 
> > 
> > Because those turn on font-lock by default.
> 
> What do you think about having fundamental-mode also turn font-lock on ?

What it does now is the result of what we think.  That's why it is called
Fundamental.

Anyway, there's no bug here, so I'm closing this.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 3:40 PM, Eli Zaretskii <eliz@gnu.org> wrote:


> > Date: Mon, 05 Dec 2022 15:06:09 +0000
> > From: Heime heimeborgia@protonmail.com
> > Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> > 
> > > > > Conclusion: you need to turn on font-lock in that buffer.
> > > > 
> > > > When I use (text-mode) or (org-mode), I do not get the problem.
> > > > 
> > > > (with-current-buffer (get-buffer-create bufrn)
> > > > (text-mode)
> > > > (insert (propertize "G"
> > > > 'font-lock-face '(:background "green"
> > > > :foreground "black"))))
> > > 
> > > Because those turn on font-lock by default.
> > 
> > What do you think about having fundamental-mode also turn font-lock on ?
> 
> 
> What it does now is the result of what we think. That's why it is called
> Fundamental.
> 
> Anyway, there's no bug here, so I'm closing this.

Is fundamental mode not usually used when working on new buffers?

bug#59828: Fundamental Mode buffers fail to keep text properties

[Eli Zaretskii]

> Date: Mon, 05 Dec 2022 19:23:02 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: casouri@gmail.com, 59828-done@debbugs.gnu.org
> 
> > > What do you think about having fundamental-mode also turn font-lock on ?
> > 
> > 
> > What it does now is the result of what we think. That's why it is called
> > Fundamental.
> > 
> > Anyway, there's no bug here, so I'm closing this.
> 
> Is fundamental mode not usually used when working on new buffers?

Not necessarily, it depends on what the Lisp program needs to do.

And turning on font-lock is just one line of Lisp away.

bug#59828: Fundamental Mode buffers fail to keep text properties

[Yuan Fu]

> On Dec 5, 2022, at 11:23 AM, Heime <heimeborgia@protonmail.com> wrote:
> 
> ------- Original Message -------
> On Monday, December 5th, 2022 at 3:40 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> 
>>> Date: Mon, 05 Dec 2022 15:06:09 +0000
>>> From: Heime heimeborgia@protonmail.com
>>> Cc: casouri@gmail.com, 59828@debbugs.gnu.org
>>> 
>>>>>> Conclusion: you need to turn on font-lock in that buffer.
>>>>> 
>>>>> When I use (text-mode) or (org-mode), I do not get the problem.
>>>>> 
>>>>> (with-current-buffer (get-buffer-create bufrn)
>>>>> (text-mode)
>>>>> (insert (propertize "G"
>>>>> 'font-lock-face '(:background "green"
>>>>> :foreground "black"))))
>>>> 
>>>> Because those turn on font-lock by default.
>>> 
>>> What do you think about having fundamental-mode also turn font-lock on ?
>> 
>> 
>> What it does now is the result of what we think. That's why it is called
>> Fundamental.
>> 
>> Anyway, there's no bug here, so I'm closing this.
> 
> Is fundamental mode not usually used when working on new buffers?
> 

Just to clarify:

1. If font-lock-mode is off, you should use (propertize … ‘face …)
2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)

If you create a buffer interactively, font-lock-mode is on (at least in the latest version of Emacs, not sure which version of Emacs are you on). But if you create a buffer programmatically (as you did in the code snippet), font-lock-mode is off.

Yuan

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 8:07 PM, Yuan Fu <casouri@gmail.com> wrote:


> > On Dec 5, 2022, at 11:23 AM, Heime heimeborgia@protonmail.com wrote:
> > 
> > ------- Original Message -------
> > On Monday, December 5th, 2022 at 3:40 PM, Eli Zaretskii eliz@gnu.org wrote:
> > 
> > > > Date: Mon, 05 Dec 2022 15:06:09 +0000
> > > > From: Heime heimeborgia@protonmail.com
> > > > Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> > > > 
> > > > > > > Conclusion: you need to turn on font-lock in that buffer.
> > > > > > 
> > > > > > When I use (text-mode) or (org-mode), I do not get the problem.
> > > > > > 
> > > > > > (with-current-buffer (get-buffer-create bufrn)
> > > > > > (text-mode)
> > > > > > (insert (propertize "G"
> > > > > > 'font-lock-face '(:background "green"
> > > > > > :foreground "black"))))
> > > > > 
> > > > > Because those turn on font-lock by default.
> > > > 
> > > > What do you think about having fundamental-mode also turn font-lock on ?
> > > 
> > > What it does now is the result of what we think. That's why it is called
> > > Fundamental.
> > > 
> > > Anyway, there's no bug here, so I'm closing this.
> > 
> > Is fundamental mode not usually used when working on new buffers?
> 
> 
> Just to clarify:
> 
> 1. If font-lock-mode is off, you should use (propertize … ‘face …)
> 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)

Very clear explanation.
 
> If you create a buffer interactively, font-lock-mode is on (at least in the latest version of Emacs, not sure which version of Emacs are you on). But if you create a buffer programmatically (as you did in the code snippet), font-lock-mode is off.
 
Even if you make a buffer interactively in fundamental-mode?

bug#59828: Fundamental Mode buffers fail to keep text properties

[Yuan Fu]

> On Dec 5, 2022, at 12:13 PM, Heime <heimeborgia@protonmail.com> wrote:
> 
> ------- Original Message -------
> On Monday, December 5th, 2022 at 8:07 PM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
>>> On Dec 5, 2022, at 11:23 AM, Heime heimeborgia@protonmail.com wrote:
>>> 
>>> ------- Original Message -------
>>> On Monday, December 5th, 2022 at 3:40 PM, Eli Zaretskii eliz@gnu.org wrote:
>>> 
>>>>> Date: Mon, 05 Dec 2022 15:06:09 +0000
>>>>> From: Heime heimeborgia@protonmail.com
>>>>> Cc: casouri@gmail.com, 59828@debbugs.gnu.org
>>>>> 
>>>>>>>> Conclusion: you need to turn on font-lock in that buffer.
>>>>>>> 
>>>>>>> When I use (text-mode) or (org-mode), I do not get the problem.
>>>>>>> 
>>>>>>> (with-current-buffer (get-buffer-create bufrn)
>>>>>>> (text-mode)
>>>>>>> (insert (propertize "G"
>>>>>>> 'font-lock-face '(:background "green"
>>>>>>> :foreground "black"))))
>>>>>> 
>>>>>> Because those turn on font-lock by default.
>>>>> 
>>>>> What do you think about having fundamental-mode also turn font-lock on ?
>>>> 
>>>> What it does now is the result of what we think. That's why it is called
>>>> Fundamental.
>>>> 
>>>> Anyway, there's no bug here, so I'm closing this.
>>> 
>>> Is fundamental mode not usually used when working on new buffers?
>> 
>> 
>> Just to clarify:
>> 
>> 1. If font-lock-mode is off, you should use (propertize … ‘face …)
>> 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)
> 
> Very clear explanation.
> 
>> If you create a buffer interactively, font-lock-mode is on (at least in the latest version of Emacs, not sure which version of Emacs are you on). But if you create a buffer programmatically (as you did in the code snippet), font-lock-mode is off.
> 
> Even if you make a buffer interactively in fundamental-mode?

By “interactively” I mean typing M-x switch-to-buffer <buffer name> RET. This gives you a new buffer in fundamental-mode.

If you create a buffer this way, and type M-x eval-expression font-lock-mode RET, you should get t, meaning font-lock-mode is on. Whereas 

(with-current-buffer (get-buffer-create "xxx")
  font-lock-mode)

returns nil.

Yuan

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Monday, December 5th, 2022 at 8:13 PM, Heime via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:


> ------- Original Message -------
> On Monday, December 5th, 2022 at 8:07 PM, Yuan Fu casouri@gmail.com wrote:
> 
> 
> 
> > > On Dec 5, 2022, at 11:23 AM, Heime heimeborgia@protonmail.com wrote:
> > > 
> > > ------- Original Message -------
> > > On Monday, December 5th, 2022 at 3:40 PM, Eli Zaretskii eliz@gnu.org wrote:
> > > 
> > > > > Date: Mon, 05 Dec 2022 15:06:09 +0000
> > > > > From: Heime heimeborgia@protonmail.com
> > > > > Cc: casouri@gmail.com, 59828@debbugs.gnu.org
> > > > > 
> > > > > > > > Conclusion: you need to turn on font-lock in that buffer.
> > > > > > > 
> > > > > > > When I use (text-mode) or (org-mode), I do not get the problem.
> > > > > > > 
> > > > > > > (with-current-buffer (get-buffer-create bufrn)
> > > > > > > (text-mode)
> > > > > > > (insert (propertize "G"
> > > > > > > 'font-lock-face '(:background "green"
> > > > > > > :foreground "black"))))
> > > > > > 
> > > > > > Because those turn on font-lock by default.
> > > > > 
> > > > > What do you think about having fundamental-mode also turn font-lock on ?
> > > > 
> > > > What it does now is the result of what we think. That's why it is called
> > > > Fundamental.
> > > > 
> > > > Anyway, there's no bug here, so I'm closing this.
> > > 
> > > Is fundamental mode not usually used when working on new buffers?
> > 
> > Just to clarify:
> > 
> > 1. If font-lock-mode is off, you should use (propertize … ‘face …)
> > 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)

If I have a function that does the inserts, should I include the two different conditions, 
whether "font-lock-mode" in "off" or "on" ?

Test whether font-lock-mode is off, then use (propertize … ‘face …)
Test whether font-lock-mode is on, then use (propertize … ‘font-lock-face …)
 
> Very clear explanation.
> 
> > If you create a buffer interactively, font-lock-mode is on (at least in the latest version of Emacs, not sure which version of Emacs are you on). But if you create a buffer programmatically (as you did in the code snippet), font-lock-mode is off.
> 
> 
> Even if you make a buffer interactively in fundamental-mode, would font-lock-mode be on ?
>

bug#59828: Fundamental Mode buffers fail to keep text properties

[Yuan Fu]

>>> 
>>> Just to clarify:
>>> 
>>> 1. If font-lock-mode is off, you should use (propertize … ‘face …)
>>> 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)
> 
> If I have a function that does the inserts, should I include the two different conditions, 
> whether "font-lock-mode" in "off" or "on" ?
> 
> Test whether font-lock-mode is off, then use (propertize … ‘face …)
> Test whether font-lock-mode is on, then use (propertize … ‘font-lock-face …)

It depends on your use-case. If you want to be safe you can just apply both properties, then it will work no matter font-lock-mode is on or not.

Yuan

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Tuesday, December 6th, 2022 at 5:41 AM, Yuan Fu <casouri@gmail.com> wrote:


> > > > Just to clarify:
> > > > 
> > > > 1. If font-lock-mode is off, you should use (propertize … ‘face …)
> > > > 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)
> > 
> > If I have a function that does the inserts, should I include the two different conditions,
> > whether "font-lock-mode" in "off" or "on" ?
> > 
> > Test whether font-lock-mode is off, then use (propertize … ‘face …)
> > Test whether font-lock-mode is on, then use (propertize … ‘font-lock-face …)
> 
> 
> It depends on your use-case. If you want to be safe you can just apply both properties, then it will work no matter font-lock-mode is on or not.
> 
> Yuan

I thought that the procedure is to enable "font-lock-mode", then use (propertize … ‘font-lock-face …).

You are saying to disregard "font-lock-mode" and use (propertize … ‘face …) when it is determined that "font-lock-mode" is off.

Can I have a deeper explanation on how to handle this good?

bug#59828: Fundamental Mode buffers fail to keep text properties

[Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors]

------- Original Message -------
On Wednesday, December 7th, 2022 at 12:53 AM, Heime via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:


> ------- Original Message -------
> On Tuesday, December 6th, 2022 at 5:41 AM, Yuan Fu casouri@gmail.com wrote:
> 
> 
> 
> > > > > Just to clarify:
> > > > > 
> > > > > 1. If font-lock-mode is off, you should use (propertize … ‘face …)
> > > > > 2. If font-lock-mode is on, you should use (propertize … ‘font-lock-face …)
> > > 
> > > If I have a function that does the inserts, should I include the two different conditions,
> > > whether "font-lock-mode" in "off" or "on" ?
> > > 
> > > Test whether font-lock-mode is off, then use (propertize … ‘face …)
> > > Test whether font-lock-mode is on, then use (propertize … ‘font-lock-face …)
> > 
> > It depends on your use-case. If you want to be safe you can just apply both properties, then it will work no matter font-lock-mode is on or not.
> > 
> > Yuan
 
I thought the procedure is to enable "font-lock-mode", followed by  
(propertize "G" 'font-lock-face '(:foreground "black")).  Finally disabling "font-lock-mode" in that buffer.