From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#74507: [PATCH] Indent compounds c-ts-mode when { is not BOL Date: Fri, 29 Nov 2024 16:16:02 -0800 Message-ID: References: <87r071yov3.fsf@lambda.is> <86serabhgw.fsf@gnu.org> <1e4fcc9a-4f69-4c3a-b9d6-716d61129e31@lambda.is> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , theo@thornhill.no, 74507@debbugs.gnu.org To: =?UTF-8?Q?J=C3=B8rgen?= Kvalsvik Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 01:18:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHBBx-0003w3-Bo for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 01:18:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHBBU-0007zB-NY; Fri, 29 Nov 2024 19:18:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHBBT-0007z3-DA for bug-gnu-emacs@gnu.org; Fri, 29 Nov 2024 19:18:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHBBT-00045n-4d for bug-gnu-emacs@gnu.org; Fri, 29 Nov 2024 19:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=DzHMkd17Qs+Qg0Z7pDJ2ZU3yX3hnqh4pBKWJBCK1j7c=; b=Cfil7oW/ypzwl5aa3lLI+2PncwtoVZTCkMsEc5c0Jh3ugEh17FEk4+LudLLhx3bTOzRbfxgm/yWR4aHh05upXz/zs413QV7ukV+ydsv2wOtoi7CwQOyn16y5NMb9SNNSqbAg3ilWElCsJbzX4az6nQ+kcTIkRLU4rSG9dmZIRGgniU/uh7dKSYHILgDbI3t75h3xm4mg6ulnz/xI81fWMYU7PpmjYdXsup2BOlnQf80ZhRQB9G/3Fag1yy0ExZFi4V7Vz7dsMU7KmeHR21sNoKHstVM13lsOjn1EfNPevbUQV3wHy0D0BfdqhlgDyAvRn/jqYIzspeqj9m0oZ8we0w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHBBS-0001wi-CY for bug-gnu-emacs@gnu.org; Fri, 29 Nov 2024 19:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 00:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74507-submit@debbugs.gnu.org id=B74507.17329258397371 (code B ref 74507); Sat, 30 Nov 2024 00:18:02 +0000 Original-Received: (at 74507) by debbugs.gnu.org; 30 Nov 2024 00:17:19 +0000 Original-Received: from localhost ([127.0.0.1]:44820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHBAl-0001up-3P for submit@debbugs.gnu.org; Fri, 29 Nov 2024 19:17:19 -0500 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:43470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHBAh-0001uX-Ki for 74507@debbugs.gnu.org; Fri, 29 Nov 2024 19:17:17 -0500 Original-Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7fc8f0598cdso2332038a12.1 for <74507@debbugs.gnu.org>; Fri, 29 Nov 2024 16:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732925774; x=1733530574; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DzHMkd17Qs+Qg0Z7pDJ2ZU3yX3hnqh4pBKWJBCK1j7c=; b=JWsUnOFRwS/9C2XUyEkQOXFlyatvB/jMrmXdaD0i+zCggPcmtK1rHEH1z1K/XzQoUB G9zeu2A9il7uzb6rpZBJsYqHNkub8LwTXO6Bkp15k1fYq2L9uheyUfws/rs+en8zMYA+ gMugktZRkSu7qTrlBv4CvHUgU2j2mcDKSljpCGNoUuJUHOBCwvLHbUPYLTjeoBQovrhY nO7Fy8sq252MMXl6CPSfL56b/HwC8cY8kuEJcsoFCg/DDCILoCPrR72rcGrEJF+JKG7p QqTH6AETV56XbO4WxYg9ijJjMPcadhWpwOyzmju+pyUpVy6DTQd7HW3MF+TTbb4Oex4B DcGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732925774; x=1733530574; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DzHMkd17Qs+Qg0Z7pDJ2ZU3yX3hnqh4pBKWJBCK1j7c=; b=gQX3tnnj3MgRGiQu1kIuR1bR1YKd8dJyOiGJ276JsvNrQGWiQfhjpQE7j4iDfMLBS7 1HQ8bmvFLi56Ci33mHoGLIrl294lq2RABVo4jksMAUI5iTAE7lLHB7gbpEwWY6f5CwKU g0DYo1A0WIvL5GmrFnS+lDPNmHXB4yiEB895YVhjMx1MfUK5beqnLlXkAduMExUJULWQ VlLkH20+49UUfcl335oZ2UI+wT96+Orw6guSwEcgXVbq3VqpvZ1ZnAQzlut8qwOUqqBt Ul5iSu/IryJzBbtHm3+RplHWzNKR+/aLuy+UEuKaZxcdBA3agpusonLwt3xBixPdOG2n cm9A== X-Forwarded-Encrypted: i=1; AJvYcCVBNgtySX+WAIqSVVpLLpYUFeRRHbIamf0ab3ruaqGe6xtVPtgobIjhkZzRxkQvWcz7YzuQKw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxlc2OX3kAYisDmmYKE/DI50uS1MvTXsU7swS3cLuLp79mmma9D sNVvA4omDrptaoVR/wjnr3NIxOrohGt8QCxWoKd2bxCVTEbjEAoR X-Gm-Gg: ASbGnctMgHGzDIxrlrgg3jn3o6rhxgLBDePsyOes5GJns+lo0LWX8Ov4y91SwLoEzq6 veYLfdu5FQaRBi8nKPXDf9nKq3f3EcJ6m2WPhsgXtwfZN5vpzlGisB19tkOMPdoQ/hfeF/IR5N8 HKbqasczPCQ6dk4Z7rm3TyrsjdAfFIog6PPcV70mDgSWWD/iOEuYVCi+l43vJPEp+2avssCeTYG roLjXGm7qPX2M2kPmQ/XOrItFVcWr1Q6r17p4aUjmy72HTcQltQrHYBA7AN7BJZtrPkYKkEtg== X-Google-Smtp-Source: AGHT+IFg7ZvHFCl7jVCQJWsk19LIRAXgMyeeJBSW9xe64i9n0SxRA05mvFf9rbUUn9rnCH4nAIEqAQ== X-Received: by 2002:a05:6300:8083:b0:1e0:cc01:43da with SMTP id adf61e73a8af0-1e0ec449d2fmr12899710637.0.1732925774548; Fri, 29 Nov 2024 16:16:14 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:71b7:718f:7faa:8436]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72541761309sm4070743b3a.5.2024.11.29.16.16.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Nov 2024 16:16:13 -0800 (PST) In-Reply-To: <1e4fcc9a-4f69-4c3a-b9d6-716d61129e31@lambda.is> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296107 Archived-At: > On Nov 29, 2024, at 1:05=E2=80=AFAM, J=C3=B8rgen Kvalsvik = wrote: >=20 > On 11/29/24 08:57, Eli Zaretskii wrote: >>> Cc: theo@thornhill.no,casouri@gmail.com >>> From: J=C3=B8rgen Kvalsvik >>> Date: Sun, 24 Nov 2024 10:15:12 +0100 >>>=20 >>> * lisp/progmodes/c-ts-mode.el = (c-ts-mode--parent-is-not-top-compound): >>> New function. >>> (c-ts-mode--indent-styles): Use it. >>> * test/lisp/progmodes/c-ts-mode-resources/indent.erts: New compound >>> statement test. >> Please make sure the lines here are not too long (see CONTRIBUTE for >> details). >>> +(defun c-ts-mode--parent-is-not-top-compound (_n parent &rest _) >>> + "Matches when PARENT is not the top level compound statement, >>> +the {} that immediately follows the signature." >> The first line of a doc string should be a single complete sentence. >> Thanks. >=20 > Ok. Yuan, would you like me to submit a revision? Since your assignment is already done, let=E2=80=99s just apply your = patch, and I=E2=80=99ll rebase my changes on top of yours. So yeah, do = send the revision patch, thanks! Yuan=