From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sat, 18 Nov 2023 22:19:15 -0800 Message-ID: References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> <83zfzkwxlv.fsf@gnu.org> <1C21FE6B-D54E-4301-AB87-5F15EE06D7D1@gmail.com> <83cywbryxi.fsf@gnu.org> <6042B192-0400-48E4-9290-940E019B01E3@gmail.com> <83zfzal2el.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 66988@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Theodor Thornhill , =?UTF-8?Q?Lo=C3=AFc_?= =?UTF-8?Q?Lema=C3=AEtre?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 19 07:20:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4bAJ-0002sh-SL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Nov 2023 07:20:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4bA8-0008OA-U2; Sun, 19 Nov 2023 01:20:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4bA3-0008Nt-LJ for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:20:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4bA0-0004GV-VL for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4bA2-0005C0-7L for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.170037477919916 (code B ref 66988); Sun, 19 Nov 2023 06:20:02 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 19 Nov 2023 06:19:39 +0000 Original-Received: from localhost ([127.0.0.1]:49805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4b9f-0005BA-8Z for submit@debbugs.gnu.org; Sun, 19 Nov 2023 01:19:39 -0500 Original-Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:61739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4b9a-0005Al-0Z for 66988@debbugs.gnu.org; Sun, 19 Nov 2023 01:19:37 -0500 Original-Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3b2ec5ee2e4so2353426b6e.3 for <66988@debbugs.gnu.org>; Sat, 18 Nov 2023 22:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700374767; x=1700979567; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MlajGaMV6ygFBtmvogs7GxKfBc9Ap9LPG3MeqLOKOdU=; b=gosvcTw44hK0lnVLpJVLx+WmjDATXZkNzkXMo6jz2kri0oig63oHrQxdB7xoiR+MYN DlbY4J7/Zeak+Px2NVrT3Ss8AbtLN6oY9Ysn8TIVgmDGl1KsVVN4B3XSeZV4rWn1lOcS akw4IEUSFZMnKzV5q/o3VxlbQ9h7klwCTdsmbQgDKuRHs8USWpKCqL8Bx2RsKLAR53tW 0KQ5jCDKZ2P81X1kNoblfMvi9Uy3mxoEGt+8ewI0zprkUT6PGTBI1UwAdW/sbk3oRUnW g9npOLodc6YitDtirTTEnRQP5XQqNNf350OQVPUleuUOy4en/n6mkHIY2PpaBQbfKKXK 0Dxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700374767; x=1700979567; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MlajGaMV6ygFBtmvogs7GxKfBc9Ap9LPG3MeqLOKOdU=; b=ROP85+xvB9TXUh03aAeXvLz4qn3odRe2nlkxAJDSWJge7WuZSRA2aAOyMwEsWAmRRH DIMJ62oJb5lvuJuc4+wMxS0vwDcoRvXG05BSvgySWO3Oz4+gVAfSMZ7FCsQ80DTKGfSB kgKSqDca3ZQEQ/1xCDNg5ekpN2FHn5rQIRuRYddKOtywIzzKOst9TGmWai7u5YTnj34P xm2GlcoIQ06emqqz0M87494Tu1ZbmmU6CVm0jFuMsU1ljHnGQlanpGYoe60r6GAMSVYU Cxz7Xzs4G6V2IIdLXmFxfAhjxEWopHBCFVRTQli7a29hBS5qIC9a+KSLTBEJT9LNn0nf VB9A== X-Gm-Message-State: AOJu0Yypq763cPEDrCf0VCMOV7ICe7/dqs5+49MvrHNJ89okds+FHXKF poBhXjY4Im1ABIGt851UzCHtYH5cYEDNsA== X-Google-Smtp-Source: AGHT+IFN89z0Iwk8F+2Pg2Gx7GgNWMUKNDutECEUZy4m7h/nrZFRJMyWCJs1kL1yFTQ0WBNLZwNW+A== X-Received: by 2002:a05:6808:4497:b0:3b2:e6a4:e177 with SMTP id eq23-20020a056808449700b003b2e6a4e177mr6167763oib.51.1700374767052; Sat, 18 Nov 2023 22:19:27 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id h24-20020aa786d8000000b006c60b150383sm4021878pfo.12.2023.11.18.22.19.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 22:19:26 -0800 (PST) In-Reply-To: <83zfzal2el.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274593 Archived-At: > On Nov 18, 2023, at 9:48 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 18 Nov 2023 10:57:56 -0800 >> Cc: Dmitry Gutov , >> Theodor Thornhill , >> 66988@debbugs.gnu.org, >> Lo=C3=AFc Lema=C3=AEtre , >> Mattias Engdeg=C3=A5rd >>=20 >>=20 >>=20 >>> On Nov 15, 2023, at 4:19 AM, Eli Zaretskii wrote: >>>=20 >>>> From: Yuan Fu >>>> Date: Tue, 14 Nov 2023 22:28:34 -0800 >>>> Cc: Dmitry Gutov , >>>> Theodor Thornhill , >>>> 66988@debbugs.gnu.org, >>>> loic.lemaitre@gmail.com >>>>=20 >>>>> Is it feasible to have a variable that controls whether the full >>>>> matches are implied in these APIs? Then we could start by making = it >>>>> optional, and at some later time make it the default. >>>>=20 >>>> It=E2=80=99s feasible, but I don=E2=80=99t think it=E2=80=99s TRT. = The major mode author should have the control over whether the full = match is implied, not the user. It doesn=E2=80=99t make sense to toggle = the variable either. If you change that variable, major mode code must = also change to be correct. >>>=20 >>> So what do you suggest that we do about this issue? >>=20 >> We change every treesit function that takes a regexp for matching = node type names to imply full match. I think most people wrote code as = if these functions use full match, so the breakage should be small. And = I can forecast this change in as many channels as I can. >=20 > Fine by me, so let's do it. Ok, I=E2=80=99ll start preparing the patch and news. Meanwhile, folks, = let me know if anyone has objections. Yuan=