From: "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com>
To: <bug-gnu-emacs@gnu.org>
Subject: patch for dired-format-columns-of-files
Date: Thu, 1 May 2008 02:50:53 +0900 [thread overview]
Message-ID: <BAY121-DAV41650D7D8CD502B5F98CDE2D80@phx.gbl> (raw)
I found a bug when I do (dired-do-delete).
I will send the patch for correcting it.
--- lisp/dired.el.orig 2008-03-17 01:27:10.000000000 +0900
+++ lisp/dired.el 2008-05-01 02:33:21.297046400 +0900
@@ -2639,9 +2639,9 @@
(defun dired-format-columns-of-files (files)
;; Files should be in forward order for this loop.
;; i.e., (car files) = first file in buffer.
;; Returns the number of lines used.
- (let* ((maxlen (+ 2 (apply 'max (mapcar 'length files))))
+ (let* ((maxlen (+ 2 (apply 'max (mapcar 'string-width files))))
(width (- (window-width (selected-window)) 2))
(columns (max 1 (/ width maxlen)))
(nfiles (length files))
(rows (+ (/ nfiles columns)
next reply other threads:[~2008-04-30 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 17:50 Toru TSUNEYOSHI [this message]
2008-05-01 14:35 ` patch for dired-format-columns-of-files Toru TSUNEYOSHI
2008-05-02 17:39 ` Stefan Monnier
2008-05-03 2:29 ` Toru TSUNEYOSHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY121-DAV41650D7D8CD502B5F98CDE2D80@phx.gbl \
--to=t_tuneyosi@hotmail.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).