From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Brent Goodrick Newsgroups: gmane.emacs.bugs Subject: bug#8684: 24.0.50; Grep mode trips up on Entering directory lines Date: Tue, 17 May 2011 12:33:47 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1305660852 25703 80.91.229.12 (17 May 2011 19:34:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 17 May 2011 19:34:12 +0000 (UTC) Cc: 8684@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 17 21:34:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QMQ1v-0005hM-2y for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2011 21:34:07 +0200 Original-Received: from localhost ([::1]:59823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQ1u-000172-LV for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2011 15:34:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQ1s-00016r-3O for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 15:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMQ1q-0007cP-Qi for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 15:34:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQ1q-0007cC-Og for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QMQ1q-0008DI-20; Tue, 17 May 2011 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brent Goodrick Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 May 2011 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8684 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8684-submit@debbugs.gnu.org id=B8684.130566083631559 (code B ref 8684); Tue, 17 May 2011 19:34:02 +0000 Original-Received: (at 8684) by debbugs.gnu.org; 17 May 2011 19:33:56 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMQ1j-0008Cy-5C for submit@debbugs.gnu.org; Tue, 17 May 2011 15:33:55 -0400 Original-Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMQ1h-0008Cm-Es for 8684@debbugs.gnu.org; Tue, 17 May 2011 15:33:54 -0400 Original-Received: by qyk29 with SMTP id 29so2417364qyk.3 for <8684@debbugs.gnu.org>; Tue, 17 May 2011 12:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qcBBBwjICfD/tMsDQz6uRV41IxI0C/cCnPmHHC/GwqM=; b=xFEIAHGzSeYyOVaGwF/cVYqwZn2Ks342Td1VP5W7B3Ww7bUbyCNDscFlY4VvTZKdPX eLRANDRLzRwKKowvr0XELO//fALR1/eUSOTmZ95MUIDTBTE7lMCOI4NvDL9K7YnB7OCj Zpwc5mEGWdxD7H03L1dRuyP+WL0CcNVU54/0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=NTja6Ow0A4X1b3q4EiZ4ZE0m6tzLfdYyvm233knFDQlZ8aEbsOui3PDnJ29Twyqkfn uVXByc0H9MlmoFOBzPT94kjxlK6YIOdLzah/VD5U912y7Hj0nxn00QntFXeDvjUiZJgt YZD4YJ0ebn8gXB2RsVjukLNL4RxYiLCKcUbV8= Original-Received: by 10.229.214.204 with SMTP id hb12mr738846qcb.261.1305660827900; Tue, 17 May 2011 12:33:47 -0700 (PDT) Original-Received: by 10.229.189.85 with HTTP; Tue, 17 May 2011 12:33:47 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 17 May 2011 15:34:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46524 Archived-At: Hi Stefan, Yes, that does fix the issue and seems like an acceptable fix IMO. Thanks, bg On Tue, May 17, 2011 at 11:15 AM, Stefan Monnier wrote: >> When you are searching build logs for matches using M-x grep, and the >> resulting grep matches lines of the form: > >> =A0 Entering directory `/some/bogus/directory/here' > >> And if you then click on lines _after_ the line such as the "Entering >> directory" line, then you get a prompt asking about "Find this grep >> hit in" which is not correct grep mode like it probably is correct in >> compile mode. > > Does the patch below help? > > > =A0 =A0 =A0 =A0Stefan > > > =3D=3D=3D modified file 'lisp/progmodes/grep.el' > --- lisp/progmodes/grep.el =A0 =A0 =A02011-05-12 15:10:17 +0000 > +++ lisp/progmodes/grep.el =A0 =A0 =A02011-05-17 18:07:41 +0000 > @@ -698,6 +698,7 @@ > =A0 =A0 =A0 =A0grep-hit-face) > =A0 (set (make-local-variable 'compilation-error-regexp-alist) > =A0 =A0 =A0 =A0grep-regexp-alist) > + =A0(set (make-local-variable 'compilation-directory-matcher) nil) > =A0 (set (make-local-variable 'compilation-process-setup-function) > =A0 =A0 =A0 =A0'grep-process-setup) > =A0 (set (make-local-variable 'compilation-disable-input) t) > >