From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8429: 24.0.50; regression: `flush-lines' does not flush all it should Date: Tue, 5 Apr 2011 14:15:33 -0700 Message-ID: References: <31A5E2DEB9B24F82A8AD85713507FE10@us.oracle.com> <83oc4kv5ko.fsf@gnu.org> <83lizov30x.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1302039458 7626 80.91.229.12 (5 Apr 2011 21:37:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 5 Apr 2011 21:37:38 +0000 (UTC) Cc: 8429@debbugs.gnu.org To: "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 05 23:37:29 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7DwF-000798-N3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2011 23:37:28 +0200 Original-Received: from localhost ([127.0.0.1]:36476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7DwF-0004hA-5s for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2011 17:37:27 -0400 Original-Received: from [140.186.70.92] (port=40416 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7Dw6-0004fc-TL for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2011 17:37:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7Dw4-00062T-S7 for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2011 17:37:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7Dw4-00062P-OV for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2011 17:37:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q7DbV-0002r7-Lg; Tue, 05 Apr 2011 17:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2011 21:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8429-submit@debbugs.gnu.org id=B8429.130203814510954 (code B ref 8429); Tue, 05 Apr 2011 21:16:01 +0000 Original-Received: (at 8429) by debbugs.gnu.org; 5 Apr 2011 21:15:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7DbF-0002qd-4y for submit@debbugs.gnu.org; Tue, 05 Apr 2011 17:15:45 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7DbC-0002qR-RV for 8429@debbugs.gnu.org; Tue, 05 Apr 2011 17:15:43 -0400 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p35LFZbX011622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Apr 2011 21:15:36 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p35LFYh5025924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 5 Apr 2011 21:15:34 GMT Original-Received: from abhmt017.oracle.com (abhmt017.oracle.com [141.146.116.26]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p35LFXpH004534; Tue, 5 Apr 2011 16:15:34 -0500 Original-Received: from dradamslap1 (/10.159.34.208) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Apr 2011 14:15:33 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83lizov30x.fsf@gnu.org> thread-index: Acvz0sclqj+S6UlISZCVkcK03dO2RwAArlGA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Source-IP: acsmt358.oracle.com [141.146.40.158] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4D9B8677.0069:SCFSTAT5015188,ss=1,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 05 Apr 2011 17:16:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45654 Archived-At: > > So the problem seems to be lazy highlighting. Unhighlighted > > text interferes with > > search etc. because of the escape chars. > > Yes, it sounds like flush-lines should retry when it fails to find a > match, after lazy-highlighting the next portion of the buffer. That doesn't sound like the right approach to me. For one thing, the problem is not limited to `flush-lines'. Any action on the buffer text that gets thrown off by the added chars will be affected. One of the reasons to run `grep' in Emacs is to have a buffer of text to operate on. For another thing, it's not clear that changing `flush-lines' in that way would be appropriate for other use `flush-lines' contexts. As I said, we might need to opt for letting the user initiate an editing mode. Until now, `C-x C-q' was enough for that. But maybe now more is needed. But that's only if this bug cannot really be fixed in a way that gives back the pre-regression behavior. IOW, things worked well in Emacs 22 and 23; what was gained in losing this behavior? My guess is that the answer is performance: highlighting is no doubt much faster because only what's shown gets highlighted. That is important (useful), no doubt about it. If a tradeoff is needed and no better solution can be found, then I'd suggest a command to make the buffer editable and completely highlighted.