From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 6 Apr 2012 07:44:08 -0700 Message-ID: References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1333724086 30242 80.91.229.3 (6 Apr 2012 14:54:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2012 14:54:46 +0000 (UTC) Cc: 7533@debbugs.gnu.org To: "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 06 16:54:45 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SGAYm-0005nn-L3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Apr 2012 16:54:44 +0200 Original-Received: from localhost ([::1]:40628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGAPx-0003uM-GP for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Apr 2012 10:45:37 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGAPn-0003tI-6H for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 10:45:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SGAPj-0002u7-6f for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 10:45:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGAPj-0002tx-3K for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 10:45:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SGAQL-0003L5-L8 for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 10:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Apr 2012 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7533-submit@debbugs.gnu.org id=B7533.133372350412771 (code B ref 7533); Fri, 06 Apr 2012 14:46:01 +0000 Original-Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 14:45:04 +0000 Original-Received: from localhost ([127.0.0.1]:42700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAPN-0003Jp-PL for submit@debbugs.gnu.org; Fri, 06 Apr 2012 10:45:03 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:44620) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAPH-0003JD-O9 for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 10:45:00 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q36EiD0v019457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 14:44:14 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q36EiCov026780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Apr 2012 14:44:13 GMT Original-Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q36EiBY4016526; Fri, 6 Apr 2012 09:44:12 -0500 Original-Received: from dradamslap1 (/10.159.49.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2012 07:44:11 -0700 X-Mailer: Microsoft Office Outlook 11 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <4F7EF782.6020103@gmx.at> Thread-Index: Ac0T/fTmKOK2NZpjRFeVD09z6fUZLQAAWgYg X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090206.4F7F013F.0001,ss=1,re=0.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58556 Archived-At: > > emacs -Q > > (setq special-display-regexps '("[ ]?[*][^*]+[*]")) > > (setq pop-up-frame t) > > I suppose you mean (setq pop-up-frames t) Yes. > but apparently this variable is no more supported by `display-buffer' > (I'm not sure whether that's by design). I don't know what you mean by that. Dunno whether it is supported by `display-buffer, but I do still use `pop-up-frames' and it works fine in general (apart from this bug, AFAIK). And I thought you took care to ensure that it did, for Emacs 24. > > C-x d whatever-dir > > Mark 4 files for deletion. Hit `x'. Answer `yes'. > > The *Deletions* frame remains displayed. > > Would the attached patch fix it? For my own complete setup, yes. But that's no doubt because I take other measures elsewhere. For the recipe I gave, however (see above), no. The separate `*Deletions*' frame popped up just becomes iconified. It is still available as a frame (and as a buffer). It is still in the list of frames, and it is thus shown in the MS Windows task bar. And on Windows at least, iconification is quite distracting. The frame does not simply disappear (and simultaneously get added to the task bar). The frame zooms down to the task bar in an animated fashion. Quite annoying. There is no need for either the frame or the window - or the buffer for that matter, after the deletions are done (or the copies or whatever `dired-mark-pop-up' was used for). By Occam's razor, no need means Emacs should not keep these things around vestigially - especially not so that users encounter them. > This is NOT a generic fix - it might fail miserably if the buffer in > question is shown in two windows simultaneously. Apparently > this is no great issue in the case at hand since > `dired-pop-to-buffer' already calls `get-buffer-window'. > I earlier provided a variable called `display-buffer-window' > for this and related issues but Stefan didn't like it. FWIW, the fix I sent still works. Perhaps it can be improved upon to satisfy whatever other needs you see that it does not quite satisfy? One way or another, the regression needs to be fixed. Things were OK back in Emacs 22. There should be no reason why we cannot make them OK again in this regard. In Emacs 22 the buffer was not shown in a separate frame, disrespecting `special-display-regexps'. I prefer (slightly) that the latter be respected, so that the buffer is shown in a separate frame. But only if the frame, like a pop-up window, is completely removed when done. Given the choice between your fix and the Emacs 22 behavior, I vastly prefer the latter: no distraction, simple, over and done with, never see `*Deletions*' or whatever again. Thanks for trying to fix this, Martin. I hope we can find a solution that is satisfactory. The fix I sent is good enough for me, but I understand if it is not good enough for you.