unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 70576@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Thu, 2 May 2024 07:47:31 -0400	[thread overview]
Message-ID: <B58177E1-4B1A-4D2E-A205-0D07F6BD1B83@gmail.com> (raw)
In-Reply-To: <86r0ekn0o0.fsf@gnu.org>

Thanks for working on this.  I'm sorry I didn't have a chance to test the patch, it looks good.  I don't think a disable variable is necessary for now, since most repeat maps are self-defined.

> On May 2, 2024, at 3:16 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Cc: 70576@debbugs.gnu.org
>> From: Juri Linkov <juri@linkov.net>
>> Date: Thu, 02 May 2024 09:48:06 +0300
>> 
>> close 70576 30.0.50
>> thanks
>> 
>>>>> (defvar-keymap expreg-repeat-map
>>>>>   :doc "Repeat map for `expreg' actions."
>>>>>   :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract")))
>>>>>   "\\" 'expreg-expand
>>>>>   "|"  'expreg-contract)
>>>> 
>>>> If a hint is missing for a command, it should just have its key mentioned.
>>>> It looks like your idea would require changes to defvar-keymap.  Do you
>>>> want to propose a patch?  We'd need some way to pass the hints in; perhaps
>>>> the macro could set a property on the command symbol as you initially
>>>> proposed.
>>> 
>>> Alright, let's add this to defvar-keymap.  Please try the following patch.
>> 
>> Thanks for the feature request.  This is pushed now.
> 
> Thanks, but please also update the ELisp manual and add an entry to
> NEWS about this change.






  reply	other threads:[~2024-05-02 11:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 22:31 bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" JD Smith
2024-04-26  6:06 ` Juri Linkov
2024-04-26 14:37   ` JD Smith
2024-04-28  6:58     ` Juri Linkov
2024-04-28 12:45       ` JD Smith
2024-04-28 16:38         ` Juri Linkov
2024-05-02  6:48           ` Juri Linkov
2024-05-02  7:16             ` Eli Zaretskii
2024-05-02 11:47               ` JD Smith [this message]
2024-05-02 16:16               ` Juri Linkov
2024-05-02 18:14                 ` Eli Zaretskii
2024-05-03  6:23                   ` Juri Linkov
2024-05-03  7:15                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B58177E1-4B1A-4D2E-A205-0D07F6BD1B83@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=70576@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).