From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Date: Tue, 01 Sep 2020 13:14:33 +0300 Message-ID: References: <87mu2d7hka.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37154"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: K-9 Mail for Android Cc: timv@ughan.xyz, rrandresf@gmail.com, michael.albinus@gmx.de To: ghe@sdf.org, 41423@debbugs.gnu.org, monnier@iro.umontreal.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 01 12:15:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD3Jo-0009Xg-RC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 12:15:12 +0200 Original-Received: from localhost ([::1]:56744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD3Jn-0007nN-TS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 06:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD3Je-0007ko-Sh for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD3Je-0006Uc-ER for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kD3Je-0004el-9U for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2020 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41423 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Gregory Heytings , "Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Stefan Monnier X-Debbugs-Original-Cc: Michael Albinus , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org Original-Received: via spool by 41423-submit@debbugs.gnu.org id=B41423.159895528417828 (code B ref 41423); Tue, 01 Sep 2020 10:15:02 +0000 Original-Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 10:14:44 +0000 Original-Received: from localhost ([127.0.0.1]:55141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3JM-0004dU-Cv for submit@debbugs.gnu.org; Tue, 01 Sep 2020 06:14:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3JL-0004d6-Ex for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 06:14:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD3JF-0006Rg-Ri; Tue, 01 Sep 2020 06:14:37 -0400 Original-Received: from [2a02:14f:1ff:9ae7::8cee:a9f] (port=51636) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1kD3JE-0000pk-KD; Tue, 01 Sep 2020 06:14:37 -0400 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186820 Archived-At: On September 1, 2020 11:31:14 AM GMT+03:00, "Gregory Heytings via Bug repor= ts for GNU Emacs, the Swiss army knife of text editors" wrote: > >> >>> 26=2E therefore pcomplete-completions does not call pcomplete/cd but= =20 >>> eshell-complete-commands-list >> >> I guess this is the culprit >> > >No, see below=2E > >> >> and this is where the time is spent=2E >> > >Yes, this is what I said=2E > >> >> `eshell-complete-commands-list` eagerly builds the list of possible=20 >> candidates and it takes a while whereas we should here return >something=20 >> quickly and cheaply, e=2Eg=2E by returning a function which will build >and=20 >> return this list more lazily when completion is actually performed=2E >> > >No, the bug is in the completion mechanism, not in eshell=2E I don't >know=20 >exactly (because the mechanism is so complicated) where the completion=20 >functions should be fixed, but it is clear that there is no reason to >call=20 >pcomplete-completions-at-point *three* times=2E Would it help to profile the completion process in this use case using the= built-in Lisp profiler?