bug#61333: 29.0.60; edit-kbd-macro failure

bug#61333: 29.0.60; edit-kbd-macro failure

[Przemysław Alexander Kamiński]

Macro edition failing. 

Steps to reproduce:

1. Start 'emacs -Q'
2. Record simple macro "C-x ( C-p C-n C-x )"
3. Bind macro to a key (tested with <f12>, but reproducible with others)
   "C-x C-k b <f12>"
4. Edit bound macro "C-x C-k e <f12>"

Edition fails with following msg:
oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))

In GNU Emacs 29.0.60 (build 1, aarch64-apple-darwin22.3.0, NS
appkit-2299.40 Version 13.2 (Build 22D49)) of 2023-02-06 built on omega
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.2

Configured using:
'configure --disable-dependency-tracking --disable-silent-rules
--enable-locallisppath=/opt/homebrew/share/emacs/site-lisp
--infodir=/opt/homebrew/Cellar/emacs-plus@29/29.0.60/share/info/emacs
--prefix=/opt/homebrew/Cellar/emacs-plus@29/29.0.60 --with-xml2
--with-gnutls --with-native-compilation --without-compress-install
--with-dbus --with-imagemagick --with-modules --with-rsvg
--with-xwidgets --with-ns --disable-ns-self-contained 'CFLAGS=-Os -w
-pipe -mmacosx-version-min=13
-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk
-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT'
'CPPFLAGS=-I/opt/homebrew/opt/zlib/include
-I/opt/homebrew/opt/jpeg/include -I/opt/homebrew/opt/libomp/include
-I/opt/homebrew/opt/icu4c/include
-I/opt/homebrew/opt/openssl@1.1/include
-I/opt/homebrew/opt/readline/include -isystem/opt/homebrew/include
-F/opt/homebrew/Frameworks
-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk'
'LDFLAGS=-L/opt/homebrew/opt/zlib/lib -L/opt/homebrew/opt/jpeg/lib
-L/opt/homebrew/opt/libomp/lib -L/opt/homebrew/opt/icu4c/lib
-L/opt/homebrew/opt/openssl@1.1/lib -L/opt/homebrew/opt/readline/lib
-L/opt/homebrew/lib -F/opt/homebrew/Frameworks
-Wl,-headerpad_max_install_names
-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk''

Configured features:
ACL DBUS GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LC_CTYPE: pl_PL.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8

Major mode: Lisp Interaction

Minor modes in effect:
  display-line-numbers-mode: t
  repeat-mode: t
  global-org-modern-mode: t
  winner-mode: t
  marginalia-mode: t
  vertico-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  which-key-posframe-mode: t
  which-key-mode: t
  global-edit-server-edit-mode: t
  global-company-mode: t
  company-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  shell-dirtrack-mode: t
  server-mode: t
  key-chord-mode: t
  smartparens-global-mode: t
  smartparens-mode: t
  delete-selection-mode: t
  general-override-mode: t
  rich-minority-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  tab-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/Users/xlii/.emacs.d/elpa/transient-20230201.1644/transient hides /opt/homebrew/Cellar/emacs-plus@29/29.0.60/share/emacs/29.0.60/lisp/transient

Features:
(shadow sort mail-extr help-fns radix-tree emacsbug message yank-media
puny rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-svn
display-line-numbers repeat affe consult-vertico consult
treemacs-bookmarks treemacs-tags bookmark skeleton eglot
external-completion array jsonrpc ert pp ewoc debug backtrace ob-python
python ob-dot ob-ruby ob-plantuml org-crypt ob-js ox-md ox-odt rng-loc
rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table
ox-ascii ox-publish ox org-element org-persist org-id org-refile
avl-tree org-protocol org-modern org ob ob-tangle ob-ref ob-lob ob-table
ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote
org-faces org-entities time-date noutline outline ob-emacs-lisp ob-core
ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc
org-loaddefs find-func cal-menu calendar cal-loaddefs org-compat
org-version org-macs format-spec finder-inf winner
catppuccin-frappe-theme ls-lisp marginalia detached-init orderless
vertico treemacs treemacs-header-line treemacs-compatibility
treemacs-mode treemacs-interface treemacs-persistence
treemacs-filewatch-mode filenotify treemacs-follow-mode
treemacs-rendering treemacs-annotations treemacs-async
treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator treemacs-scope pulse treemacs-faces
treemacs-icons treemacs-themes treemacs-core-utils pfuture inline
hl-line ht treemacs-logging treemacs-customization treemacs-macros s
which-key-posframe posframe which-key edit-server visual-fill-column
ialign align rainbow-mode scss-mode flymake-proc flymake derived
visual-regexp rjsx-mode sgml-mode facemenu dom js2-mode js c-ts-common
treesit cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align
cc-engine cc-vars cc-defs imenu inf-ruby ruby-mode smie company-oddmuse
company-abbrev company-keywords company-etags etags fileloop generator
company-gtags company-dabbrev-code company-dabbrev company-files
company-clang company-capf company-cmake company-semantic
company-template company-bbdb company pcase yasnippet with-editor shell
pcomplete server compat avy-zap avy use-package-chords bind-chord
key-chord smerge-mode diff-mode diff smartparens iedit iedit-lib
mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors
multiple-cursors-core advice comp comp-cstr warnings icons rx rect
counsel-projectile projectile grep ibuf-ext ibuffer ibuffer-loaddefs
thingatpt counsel xdg xref project dired dired-loaddefs compile
text-property-search comint ansi-osc ansi-color swiper ivy delsel
ivy-faces ivy-overlay colir edmacro kmacro general git-ps1-mode
autothemer color lisp-mnt dash rich-minority hydra ring lv modus-themes
fontaine exec-path-from-shell cl-extra help-mode use-package
use-package-ensure use-package-delight use-package-diminish
use-package-bind-key bind-key easy-mmode use-package-core
highlight-autoloads lsp-ivy-autoloads vertico-autoloads
counsel-projectile-autoloads autothemer-autoloads
avy-embark-collect-autoloads wgrep-autoloads
which-key-posframe-autoloads counsel-autoloads org-bullets-autoloads
git-ps1-mode-autoloads lsp-treemacs-autoloads treemacs-autoloads
detached-autoloads lsp-ui-autoloads avy-zap-autoloads
smartparens-autoloads eshell-vterm-autoloads hydra-autoloads
ialign-autoloads rjsx-mode-autoloads cfrs-autoloads affe-autoloads
swiper-autoloads ivy-autoloads pfuture-autoloads ace-window-autoloads
avy-autoloads diffview-autoloads company-autoloads python-mls-autoloads
lsp-mode-autoloads spinner-autoloads f-autoloads rainbow-mode-autoloads
lv-autoloads vterm-autoloads fontaine-autoloads which-key-autoloads
org-modern-autoloads rvm-autoloads code-review-autoloads
emojify-autoloads forge-autoloads yaml-autoloads markdown-mode-autoloads
ghub-autoloads a-autoloads magit-autoloads magit-section-autoloads
git-commit-autoloads with-editor-autoloads closql-autoloads
emacsql-sqlite-autoloads emacsql-autoloads uuidgen-autoloads
modus-themes-autoloads marginalia-autoloads general-autoloads
expand-region-autoloads string-inflection-autoloads inf-ruby-autoloads
embark-consult-autoloads embark-autoloads posframe-autoloads
orderless-autoloads ace-jump-zap-autoloads visual-fill-column-autoloads
transient-autoloads typescript-mode-autoloads scss-mode-autoloads
projectile-autoloads treepy-autoloads web-mode-autoloads
use-package-chords-autoloads bind-chord-autoloads deferred-autoloads
git-msg-prefix-autoloads visual-regexp-autoloads ag-autoloads
key-chord-autoloads ht-autoloads js2-refactor-autoloads
yasnippet-autoloads s-autoloads js2-mode-autoloads
ace-jump-mode-autoloads github-browse-file-autoloads
edit-server-autoloads iedit-autoloads rich-minority-autoloads
restclient-jq-autoloads jq-mode-autoloads restclient-autoloads
multiple-cursors-autoloads consult-flycheck-autoloads flycheck-autoloads
pkg-info-autoloads epl-autoloads consult-autoloads compat-autoloads
exec-path-from-shell-autoloads plantuml-mode-autoloads info
dash-autoloads package browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie generate-lisp-file url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp
byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads xwidget-internal dbusbind kqueue cocoa ns lcms2 multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 714146 313119)
(symbols 48 48484 3)
(strings 32 199910 42293)
(string-bytes 1 6816764)
(vectors 16 80270)
(vector-slots 8 1387608 604411)
(floats 8 546 1875)
(intervals 56 1345 627)
(buffers 984 14))

bug#61333: oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure)) (was: bug#61333: 29.0.60; edit-kbd-macro failure)

[Michael Heerdegen]

Przemysław Alexander Kamiński <przemyslaw@kaminski.se> writes:

> 1. Start 'emacs -Q'
> 2. Record simple macro "C-x ( C-p C-n C-x )"
> 3. Bind macro to a key (tested with <f12>, but reproducible with others)
>    "C-x C-k b <f12>"
> 4. Edit bound macro "C-x C-k e <f12>"
>
> oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))

Something for Stefan probably.

Michael.

bug#61333: 29.0.60; edit-kbd-macro failure

[Eli Zaretskii]

> From: Przemysław Alexander Kamiński
>  <przemyslaw@kaminski.se>
> Date: Mon, 6 Feb 2023 21:28:12 +0100
> 
> Macro edition failing. 
> 
> Steps to reproduce:
> 
> 1. Start 'emacs -Q'
> 2. Record simple macro "C-x ( C-p C-n C-x )"
> 3. Bind macro to a key (tested with <f12>, but reproducible with others)
>    "C-x C-k b <f12>"
> 4. Edit bound macro "C-x C-k e <f12>"
> 
> Edition fails with following msg:
> oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))

Stefan, any ideas?

bug#61333: 29.0.60; edit-kbd-macro failure

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> 1. Start 'emacs -Q'
>> 2. Record simple macro "C-x ( C-p C-n C-x )"
>> 3. Bind macro to a key (tested with <f12>, but reproducible with others)
>>    "C-x C-k b <f12>"
>> 4. Edit bound macro "C-x C-k e <f12>"
>> 
>> Edition fails with following msg:
>> oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))
> Stefan, any ideas?

Should be fixed now on `master`.


        Stefan

bug#61333: 29.0.60; edit-kbd-macro failure

[Przemysław Alexander Kamiński]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]


>>> 1. Start 'emacs -Q'
>>> 2. Record simple macro "C-x ( C-p C-n C-x )"
>>> 3. Bind macro to a key (tested with <f12>, but reproducible with others)
>>>   "C-x C-k b <f12>"
>>> 4. Edit bound macro "C-x C-k e <f12>"
>>> 
>>> Edition fails with following msg:
>>> oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))
>> Stefan, any ideas?
> 
> Should be fixed now on `master`.

I confirm that with patch problem no longer occurs. Thank you.

Best,
Przemysław Alexander Kamiński


[-- Attachment #2: Type: text/html, Size: 2076 bytes --]

bug#61333: 29.0.60; edit-kbd-macro failure

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> I confirm that with patch problem no longer occurs. Thank you.

Thank you, closing,


        Stefan

bug#61333: 29.0.60; edit-kbd-macro failure

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Przemysław Alexander Kamiński
>  <przemyslaw@kaminski.se>,
>   61333@debbugs.gnu.org
> Date: Tue, 07 Feb 2023 18:11:04 -0500
> 
> >> 1. Start 'emacs -Q'
> >> 2. Record simple macro "C-x ( C-p C-n C-x )"
> >> 3. Bind macro to a key (tested with <f12>, but reproducible with others)
> >>    "C-x C-k b <f12>"
> >> 4. Edit bound macro "C-x C-k e <f12>"
> >> 
> >> Edition fails with following msg:
> >> oclosure--get: Assertion failed: (eq 'closure (car-safe oclosure))
> > Stefan, any ideas?
> 
> Should be fixed now on `master`.

Thanks.  Any reasons not to backport this to emacs-29?

bug#61333: 29.0.60; edit-kbd-macro failure

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii [2023-02-08 14:59:24] wrote:
> Thanks.  Any reasons not to backport this to emacs-29?

Ah, right, that code is already on `emacs-29`, sorry.
I just cherry picked it onto `emacs-29` now.


        Stefan

bug#61333: 29.0.60; edit-kbd-macro failure

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: przemyslaw@kaminski.se,  61333@debbugs.gnu.org
> Date: Wed, 08 Feb 2023 09:10:22 -0500
> 
> Eli Zaretskii [2023-02-08 14:59:24] wrote:
> > Thanks.  Any reasons not to backport this to emacs-29?
> 
> Ah, right, that code is already on `emacs-29`, sorry.
> I just cherry picked it onto `emacs-29` now.

Great, thanks.