From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#51941: Detect duplication of ERT tests Date: Wed, 24 Nov 2021 11:00:30 +0100 Message-ID: References: <21CD2DED-354E-4C46-9794-07172E3BD5F1@acm.org> <87fsrtkayn.fsf@gnus.org> <87lf1eau3l.fsf@localhost> <5AA13574-8ED8-450E-8F92-1C374A2717AB@acm.org> <87fsrlc36p.fsf@localhost> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51941@debbugs.gnu.org, Lars Ingebrigtsen To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 24 11:08:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mppCN-0001Lc-Et for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 11:08:19 +0100 Original-Received: from localhost ([::1]:55454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mppCM-0001n0-FN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 05:08:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpp5K-0004G7-4E for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 05:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpp5J-0005e5-Qr for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 05:01:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpp5J-0000J9-Ne for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 05:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Nov 2021 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51941 X-GNU-PR-Package: emacs Original-Received: via spool by 51941-submit@debbugs.gnu.org id=B51941.16377480501149 (code B ref 51941); Wed, 24 Nov 2021 10:01:01 +0000 Original-Received: (at 51941) by debbugs.gnu.org; 24 Nov 2021 10:00:50 +0000 Original-Received: from localhost ([127.0.0.1]:53225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp57-0000IS-EK for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:49 -0500 Original-Received: from mail1477c50.megamailservers.eu ([91.136.14.77]:36656 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp4z-0000HP-S7 for 51941@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:44 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1637748033; bh=Gc50kuSMlDR1iMC6UdS7OQfHCYu0YSL/NYF7s/eJBOk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=LBOy4fpWpP+AYTnq2CKcArt2dqgueOxeANq8jR6akz6qqlosUu+Ju3/nWxqloOaz4 y0KjzoqyCqZgjNpyUyf5JoLkvca4OiRwqn4zYW07TFBSKzcLHw9qXf2jE8v2jDQchY Xuo2fk6OwmpNzDLgiSYTuY3AhDK94ex4hkyUH5Og= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1AOA0VR7025609; Wed, 24 Nov 2021 10:00:32 +0000 In-Reply-To: <87fsrlc36p.fsf@localhost> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F29.619E0D41.0032, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=M80ulw8s c=1 sm=1 tr=0 ts=619e0d41 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=pGLkceISAAAA:8 a=cyAM_svuzvAtCki78zMA:9 a=QEXdDO2ut3YA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220721 Archived-At: 24 nov. 2021 kl. 10.29 skrev Ihor Radchenko : > 1. load-file test-oc > 1.1. test-oc requires test-ox > 2. load file test-ox triggers error: > Debugger entered--Lisp error: (error "Test = =E2=80=98test-org-export/bind-keyword=E2=80=99 redefined") Thank you, that was very clear. Best practice is to run each ERT test file in a separate Emacs process. = This ensures isolation between the tests, which can be quite important, = but also permits them to be run in parallel. Easiest is to do this from = a Makefile but you could of course do it from a controlling Emacs = process if you prefer that. Now if you for some reason want to stick with running them all in a = single process, which I would advice against, then at least avoid the = load-file if the file has already been loaded. Maybe use `require` with = a file argument instead of load-file. As a last resort you could insert something like (ert-delete-all-tests) = between the test runs, but then you would no longer get the benefit of = the global ERT test duplication check that is the one advantage of = running them all in the same process.