From: "Mattias Engdegård" <mattiase@acm.org>
To: Fernando de Morais <fernandodemorais.jf@gmail.com>
Cc: 54458@debbugs.gnu.org, bandali@gnu.org, jp@neverwas.me
Subject: bug#54458: 27.2; erc-dcc-get: Re-entering top level after C stack overflow
Date: Mon, 28 Mar 2022 11:23:09 +0200 [thread overview]
Message-ID: <B366C0CA-8149-442C-B105-95EE698B340B@acm.org> (raw)
In-Reply-To: <78459EAB-314B-4122-8E3B-7F82685D0DBA@acm.org>
27 mars 2022 kl. 22.54 skrev Mattias Engdegård <mattiase@acm.org>:
> Not sure where this happens but it looks like it might be erc-dcc-send-filter.
Some additional notes:
This is not an infinite recursion; eventually the stack will culminate and recede, unless (as in this case) we run out of room first.
In Emacs 29 the byte-code engine is more stack-efficient but that just means that bigger files can be transferred without a stack overflow. The bug is still there.
Presumably we should add a note to the documentation of process filter functions that they shouldn't be used to send more data to the process. (Not sure what to recommend, an idle timer maybe?)
I'm not going to fix this because I don't know ERC very well and wouldn't be able to test it sufficiently, but our ERC maintainers do and can!
next prev parent reply other threads:[~2022-03-28 9:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 22:59 bug#54458: 27.2; erc-dcc-get: Re-entering top level after C stack overflow Fernando de Morais
2022-03-21 14:09 ` J.P.
2022-03-22 13:50 ` Fernando de Morais
2022-03-22 14:36 ` Eli Zaretskii
[not found] ` <87tubj1eq4.fsf@gmail.com>
2022-03-27 17:56 ` Eli Zaretskii
2022-03-27 22:09 ` Fernando de Morais
2022-03-27 20:54 ` Mattias Engdegård
2022-03-28 9:23 ` Mattias Engdegård [this message]
2022-03-28 11:14 ` Eli Zaretskii
2022-03-28 12:08 ` J.P.
2022-03-29 15:49 ` Mattias Engdegård
2022-03-29 16:45 ` Eli Zaretskii
2022-03-29 17:47 ` Mattias Engdegård
2022-03-29 19:44 ` J.P.
2022-03-30 4:02 ` J.P.
[not found] ` <87mth8rst7.fsf@neverwas.me>
2022-03-30 15:28 ` Mattias Engdegård
2022-03-31 19:18 ` J.P.
[not found] ` <87sfqygccz.fsf@neverwas.me>
2022-04-03 17:20 ` Fernando de Morais
2022-04-03 19:46 ` J.P.
[not found] ` <87wng67xxd.fsf@neverwas.me>
2022-04-10 21:31 ` J.P.
[not found] ` <875yng39sa.fsf@neverwas.me>
2022-04-11 3:17 ` J.P.
[not found] ` <87sfqkz4ts.fsf@neverwas.me>
2022-04-25 0:59 ` Fernando de Morais
[not found] ` <87ilqyrn9s.fsf@gmail.com>
2022-04-25 12:08 ` J.P.
[not found] ` <878rrtz7or.fsf@neverwas.me>
2022-04-29 14:51 ` Fernando de Morais
[not found] ` <87r15guen2.fsf@gmail.com>
2022-04-30 13:39 ` J.P.
[not found] ` <87ilqqy9km.fsf@neverwas.me>
2022-05-04 13:03 ` Fernando de Morais
[not found] ` <87pmkth2lr.fsf@gmail.com>
2022-05-06 13:06 ` J.P.
[not found] ` <874k22zu7s.fsf@neverwas.me>
2022-05-08 1:16 ` Fernando de Morais
[not found] ` <87sfpk4ydj.fsf@gmail.com>
2022-05-11 14:29 ` J.P.
[not found] ` <87ee10xhw3.fsf@neverwas.me>
2022-05-23 1:22 ` J.P.
2022-04-01 6:32 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B366C0CA-8149-442C-B105-95EE698B340B@acm.org \
--to=mattiase@acm.org \
--cc=54458@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=fernandodemorais.jf@gmail.com \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).