From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Date: Sat, 30 Dec 2023 12:23:18 -0800 Message-ID: References: <87r0jdddxf.fsf@yandex.ru> <835y0pfkgr.fsf@gnu.org> <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> <08D379EF-1556-4498-8E60-F7972A25752A@gmail.com> <2141703952885@mail.yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "67977@debbugs.gnu.org" <67977@debbugs.gnu.org> To: Denis Zubarev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 30 21:24:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJfsd-0003mo-JP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Dec 2023 21:24:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJfsJ-0006Wn-Oh; Sat, 30 Dec 2023 15:24:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJfsI-0006We-O5 for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 15:24:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJfsH-00019J-IR for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 15:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJfsH-0005MX-MJ for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 15:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Dec 2023 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67977 X-GNU-PR-Package: emacs Original-Received: via spool by 67977-submit@debbugs.gnu.org id=B67977.170396782120580 (code B ref 67977); Sat, 30 Dec 2023 20:24:01 +0000 Original-Received: (at 67977) by debbugs.gnu.org; 30 Dec 2023 20:23:41 +0000 Original-Received: from localhost ([127.0.0.1]:45117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfrw-0005Lr-M7 for submit@debbugs.gnu.org; Sat, 30 Dec 2023 15:23:40 -0500 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:42451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfrt-0005Lc-67 for 67977@debbugs.gnu.org; Sat, 30 Dec 2023 15:23:40 -0500 Original-Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1d3ef33e68dso51155465ad.1 for <67977@debbugs.gnu.org>; Sat, 30 Dec 2023 12:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703967810; x=1704572610; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4n98kGptyybYjpEnjHGRJKbZfTLyJQdKyb09MwxLFUM=; b=dhDJMnqLaQPBRJuaF8VMdHaQkbJE+yva8EgVTSpeELHgtT9JqfMswa5AV7fuHOcClW lANd2WJizHJ4bEJUcr5Z3u6LFx4270iB+tpdoVVQUC535W85EpnlNbFrZdNcLJ3riSR4 r50D8x+Rwb9cGHLbEQjGA8m+WPbU41HfyWPiVbcSx62EUpvOjYM26+oRZjlFkFRIYaxp pmwqosvDOitR9s/dK/9Up3Rmk/S/IGorx4BnLyhUrj/zrhFEkwemo3298hAwokUDKl7Q WV3dmMRBJlOUblSNWEbzqRyjfTP3KF7pHmf45ZJSH1qcS8aYyG4+/6eGvsHa/Eag0QO2 GTZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703967810; x=1704572610; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4n98kGptyybYjpEnjHGRJKbZfTLyJQdKyb09MwxLFUM=; b=qNQq5d15UOUEsr8LWQA/bDURUCISazVDNrXxQ021Ta6osj+fMXubTKvAF3eHAc/S9p aD0/Ay2cfWhHVfJRBL1VaozhxZTVVQzqeyW5d9133h3bhh5fPQpp7P77mE8WxKbxwd3V Mi1kwH6mGDwJKP2mzSOCrTnzxt4nQHctOgKZi9B5zTW6NMzHulDekU6MsaOnOT9GcqGQ QAVAnFe8iN+TCm/nI7V6g34APaQe5popixSfxjELeRANFdkgxGZ3fvXbYO10KDaSZa36 Ts3yX+kWe+KunxJVDF40bVSgZMf0GVLzdMWuloXBTdJsjmFttRMgLpuIGvsfDmNVwgT6 2Rcw== X-Gm-Message-State: AOJu0YwU1NbM7gHyqDjYRyppbQpNu74YWqYJM3MRVU0CZOZDERGktU7q vg+71Nz60ONxP/kZ2kYYyZU= X-Google-Smtp-Source: AGHT+IHg8UYOiGPFZjQ0VvpttEqrOEqkPbyo5PfVSmei8Yx3w/DKUCeIEmhB6vh0FOSvAYJJ7jsNlw== X-Received: by 2002:a17:902:d352:b0:1d0:6ffd:610d with SMTP id l18-20020a170902d35200b001d06ffd610dmr12898102plk.47.1703967810327; Sat, 30 Dec 2023 12:23:30 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v1-20020a170902b7c100b001d40cc2c9c3sm16952554plz.35.2023.12.30.12.23.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Dec 2023 12:23:30 -0800 (PST) In-Reply-To: <2141703952885@mail.yandex.ru> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277098 Archived-At: > On Dec 30, 2023, at 8:21 AM, Denis Zubarev = wrote: >=20 > > I pushed a fix and now it shouldn=E2=80=99t crash anymore. However, = I=E2=80=99m yet not sure why at some point the buffer was widened. Is = there any way to track who called widen? > Thank you, It doesn't crash anymore. > > So it seems working in a narrowed buffer would trigger a lot of = back-and-fortch reparse. I wonder if it=E2=80=99s worth optimizing for = (eg, use two parsers behind the scenes, one for widened buffer and one = for narrowed buffer). > I have performed a quite naive benchmark and haven't seen any = significant slow down when inserting text in a narrowed buffer. Right, when you type, since the only thing that access the parser is = font-lock, which always widens the buffer, there=E2=80=99s no = unnecessary reparse. If you invoke some function that access the parser = while the buffer is narrowed, that=E2=80=99ll trigger a reparse, and the = next time font-lock runs, it=E2=80=99ll widen and make the parser = reparse the full buffer again. Yuan=