From: Yuan Fu <casouri@gmail.com>
To: Denis Zubarev <dvzubarev@yandex.ru>
Cc: Eli Zaretskii <eliz@gnu.org>,
"67977@debbugs.gnu.org" <67977@debbugs.gnu.org>
Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer
Date: Sat, 30 Dec 2023 12:23:18 -0800 [thread overview]
Message-ID: <B100D4A5-F0ED-429F-B62C-9B052B5505E5@gmail.com> (raw)
In-Reply-To: <2141703952885@mail.yandex.ru>
> On Dec 30, 2023, at 8:21 AM, Denis Zubarev <dvzubarev@yandex.ru> wrote:
>
> > I pushed a fix and now it shouldn’t crash anymore. However, I’m yet not sure why at some point the buffer was widened. Is there any way to track who called widen?
> Thank you, It doesn't crash anymore.
> > So it seems working in a narrowed buffer would trigger a lot of back-and-fortch reparse. I wonder if it’s worth optimizing for (eg, use two parsers behind the scenes, one for widened buffer and one for narrowed buffer).
> I have performed a quite naive benchmark and haven't seen any significant slow down when inserting text in a narrowed buffer.
Right, when you type, since the only thing that access the parser is font-lock, which always widens the buffer, there’s no unnecessary reparse. If you invoke some function that access the parser while the buffer is narrowed, that’ll trigger a reparse, and the next time font-lock runs, it’ll widen and make the parser reparse the full buffer again.
Yuan
next prev parent reply other threads:[~2023-12-30 20:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 23:18 bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Denis Zubarev
2023-12-23 7:26 ` Eli Zaretskii
2023-12-23 8:08 ` Yuan Fu
2023-12-24 3:00 ` Yuan Fu
2023-12-24 7:11 ` Eli Zaretskii
2023-12-27 4:15 ` Yuan Fu
2023-12-27 12:57 ` Eli Zaretskii
2023-12-28 8:07 ` Yuan Fu
2023-12-28 11:44 ` Dmitry Gutov
2023-12-28 13:53 ` Eli Zaretskii
2023-12-28 16:16 ` Dmitry Gutov
2023-12-29 7:00 ` Yuan Fu
2023-12-29 12:48 ` Dmitry Gutov
2023-12-30 4:35 ` Yuan Fu
2023-12-30 16:21 ` Denis Zubarev
2023-12-30 20:23 ` Yuan Fu [this message]
2023-12-31 0:08 ` Dmitry Gutov
2023-12-31 10:39 ` Denis Zubarev
2023-12-31 12:56 ` Eli Zaretskii
2023-12-31 13:40 ` Dmitry Gutov
2024-01-02 4:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 13:34 ` Dmitry Gutov
2024-01-02 22:58 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B100D4A5-F0ED-429F-B62C-9B052B5505E5@gmail.com \
--to=casouri@gmail.com \
--cc=67977@debbugs.gnu.org \
--cc=dvzubarev@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).