From: ndame <emacsuser@freemail.hu>
To: 38370@debbugs.gnu.org
Subject: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode
Date: Mon, 25 Nov 2019 14:11:30 +0100 (CET) [thread overview]
Message-ID: <AyDtbg.hEmTnourIu.FtDKvvSKLrHkCQM9QIcy@freemail.hu> (raw)
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
Recently I turned on next-error-follow-minor-mode in diff buffers, so
the source context is shown automatically as I move around in the diff
buffer.
It works well, but after a while I noticed there is always a 'Hunk
already applied' message in the echo area.
I investigated and turns out the message comes from here:
next-error
next-error-function
diff-next-error
diff-goto-source
diff-hunk-status-msg
So goto source prints this message every time, even if one just
presses RET in a diff buffer.
I found it confusing, because I was just moving around, I didn't try
to apply anything, so this message wasn't really informative, it
stopped my flow with its unwanted appearance and reference to an other
operation.
Shouldn't this 'Hunk already applied' message appear only if the user
actually tries to apply something?
[-- Attachment #2: Type: text/html, Size: 1078 bytes --]
next reply other threads:[~2019-11-25 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 13:11 ndame [this message]
2020-08-20 14:54 ` bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode Lars Ingebrigtsen
2020-08-20 15:29 ` Stefan Monnier
2020-08-20 15:43 ` Lars Ingebrigtsen
2020-08-20 23:32 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AyDtbg.hEmTnourIu.FtDKvvSKLrHkCQM9QIcy@freemail.hu \
--to=emacsuser@freemail.hu \
--cc=38370@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).