From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: ndame Newsgroups: gmane.emacs.bugs Subject: bug#37459: Acknowledgement (26.2; sql syntax highlight problem when escaping single quote) Date: Fri, 22 Nov 2019 15:44:37 +0100 (CET) Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1542_1164885660.1574433525529" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="34962"; mail-complaints-to="usenet@blaine.gmane.org" To: "37459@debbugs.gnu.org" <37459@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 15:54:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYAJq-0008tO-6P for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 15:53:58 +0100 Original-Received: from localhost ([::1]:51858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYAJo-0000T6-TX for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 09:53:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37206) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYAHu-0006G4-7N for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 09:52:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYABC-0005Tq-EC for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 09:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYABB-0005Tm-Um for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 09:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYABB-0000x3-QQ for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 09:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: ndame Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 14:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37459 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37459-submit@debbugs.gnu.org id=B37459.15744338903628 (code B ref 37459); Fri, 22 Nov 2019 14:45:01 +0000 Original-Received: (at 37459) by debbugs.gnu.org; 22 Nov 2019 14:44:50 +0000 Original-Received: from localhost ([127.0.0.1]:54043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAAz-0000wR-MH for submit@debbugs.gnu.org; Fri, 22 Nov 2019 09:44:49 -0500 Original-Received: from fmfe26.onbox.hu ([46.107.16.231]:28895 helo=web-out.onbox.hu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAAx-0000wC-Jg for 37459@debbugs.gnu.org; Fri, 22 Nov 2019 09:44:48 -0500 X-fm-smtp-source: yes Original-Received: from localhost (localhost [84.236.30.241]) by web-out.onbox.hu (Postfix) with SMTP id 47KK2c2wf1zNr6 for <37459@debbugs.gnu.org>; Fri, 22 Nov 2019 15:44:37 +0100 (CET) In-Reply-To: X-AccountId: 57978162 X-Originating-Ip: 84.236.30.241 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudehgedgieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpucfhtffggffotefknfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffkjghfufggtghiffesrgdtregstddtjeenucfhrhhomhepnhgurghmvgcuoegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhuqeenucfkphepkeegrddvfeeirdeftddrvdegudenucfrrghrrghmpehhvghloheppdhinhgvthepkeegrddvfeeirdeftddrvdeguddpmhgrihhlfhhrohhmpegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhupdhrtghpthhtohepfeejgeehleesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/relaxed; t=1574433880; s=20181004; d=freemail.hu; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Date; l=4339; bh=IsfKEhy5y/BlW6v9dbSCyfgvIXlIjnOEKPEb1mMYhmU=; b=P0ADuatRIISO9Iv+r3+BwyT19JV+K/A8LT0rcRqivQfq9KAmO6Xk6zRoqqCsz8mi IFanrOM6GgHl+QHkRn4D6QMz4pAsv0VV/vs5WZBDvp2IDHbDKpFcvtvx8kW6caQrkZZ ssHR1SusrmTBodMdqDBoizyerjseRBvKnmHv1l9818JB13lq4SgckbqS9M3bHSqWubK Xg4FYJ2RTnxy/da4OWGGwiVaWZTaJyUuAgCoEYOuUby4CDhZ/fUmtLcHKAV2mO7aG/s vPn7aaH1nma43zEswehagXy+9Q+wNTtz0Eufl/UjdkUqs3xOjUu5SWv3u3FEds1PwFo Av6A5A7FUw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172240 Archived-At: ------=_Part_1542_1164885660.1574433525529 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Browsing sql.el I found this code: =C2=A0 ;; MariaDB is a drop-in replacement for MySQL, so just make the ;; MariaDB variables aliases of the MySQL ones. =C2=A0 (defvaralias 'sql-mariadb-program 'sql-mysql-program) (defvaralias 'sql-mariadb-options 'sql-mysql-options) (defvaralias 'sql-mariadb-login-params 'sql-mysql-login-params) =C2=A0 =C2=A0 If mariadb is a drop in mysql replacement then all mysql-related fixes should apply to it too, though later in the code mariadb sets up syntax independetly, so the same bug affects it which the patch here fixes. The correct solution could be setting up a mariadb syntax variable and alias it to the mysql syntax variable to avoid duplicating the same cod= e: =C2=A0 (mariadb :name "MariaDB" :free-software t :font-lock sql-mode-mariadb-font-lock-keywords :sqli-program sql-mariadb-program :sqli-options sql-mariadb-options :sqli-login sql-mariadb-login-params :sqli-comint-func sql-comint-mariadb :list-all "SHOW TABLES;" :list-table "DESCRIBE %s;" :prompt-regexp "^MariaDB \\[.*]> " :prompt-cont-regexp "^ [\"'`-]> " :syntax-alist ((?# . "< b")) :input-filter sql-remove-tabs-filter) =C2=A0 ------=_Part_1542_1164885660.1574433525529 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Browsing sql.el I found this code:
 
;; MariaDB is a drop-in replacement for MySQL, so just make the
;; MariaDB variables aliases of the MySQL ones.
 
(defvaralias 'sql-mariadb-program 'sql-mysql-program)
(defvaralias 'sql-mariadb-options 'sql-mysql-options)
(defvaralias 'sql-mariadb-login-params 'sql-mysql-login-params)
 
 

If mariadb is a drop in mysql replacement then all mysql-related fixes
should apply to it too, though later in the code mariadb sets up syntax
independetly, so the same bug affects it which the patch here fixes.
The correct solution could be setting up a mariadb syntax variable
and alias it to the mysql syntax variable to avoid duplicating the same code:

 
(mariadb
:name "MariaDB"
:free-software t
:font-lock sql-mode-mariadb-font-lock-keywords
:sqli-program sql-mariadb-program
:sqli-options sql-mariadb-options
:sqli-login sql-mariadb-login-params
:sqli-comint-func sql-comint-mariadb
:list-all "SHOW TABLES;"
:list-table "DESCRIBE %s;"
:prompt-regexp "^MariaDB \\[.*]> "
:prompt-cont-regexp "^ [\"'`-]> "
:syntax-alist ((?# . "< b"))
:input-filter sql-remove-tabs-filter)



  ------=_Part_1542_1164885660.1574433525529--