From: Randy Taylor <dev@rjt.dev>
To: Ankit Gadiya <ankit@argp.in>
Cc: Eli Zaretskii <eliz@gnu.org>, 70939@debbugs.gnu.org
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Date: Wed, 10 Jul 2024 23:43:37 +0000 [thread overview]
Message-ID: <Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev> (raw)
In-Reply-To: <CAN7zea0LVarjkL8NNVeTXAfjvmj=VvFV+ZmxSMTfdzfBaJo2XA@mail.gmail.com>
On Saturday, July 6th, 2024 at 15:44, Ankit Gadiya <ankit@argp.in> wrote:
>
> Apologies for the delay again.
>
> > > > For the commit message, I'm not sure we need that paragraph especially when it's already described in the news. Eli what do you think?
>
>
> Thanks Randy and Eli, I've updated the commit message to be shorter now.
>
> > > > +*** New unit test commands.
> > > > +Two new commands are now available to run unit tests.
> > > > Three?
> >
> > This still needs to be updated.
>
>
> Thanks, I fixed it.
>
> > A few more comments:
> > +(defun go-ts-mode--get-test-regexp-at-point ()
> > + "Return a regular expression for tests at point.
> > ^ the
> >
> > Could go-ts-mode--get-test-regexp-at-point and go-ts-mode-test-file use if-let?
>
>
> I wasn't familiar with if-let, thanks for this. Incorporated it in
> both the functions.
>
> > Also, the indentation looks off in go-ts-mode-test-function-at-point (2 extra spaces methinks).
>
>
> Fixed this, thanks.
>
> > > > I'm also wondering if we should include "current" in the go-ts-mode-test-file and go-ts-mode-test-package function names. Maybe someone would expect that they would get prompted to select a file or package to test? Maybe I'm overthinking that :). Eli what do you think?
> > >
> > > I'll wait for Eli to reply before incorporating the changes :).
> >
> > And he chimed in - let's go with his suggestions.
>
>
> Updated both the function names.
> go-ts-mode-test-this-file
> go-ts-mode-test-this-package
>
> > > Additionally, I also noticed that the emacs-30 branch is cut. I wanted
> > > to check if I
> > > need to rebase my patch onto master or emacs-30 branch?
> >
> > I would guess master, but let's see what Eli says.
>
>
> I rebased my patch on the master now. Requesting a re-review.
>
> Thanks
>
> --
> Ankit
I only have a few comments about the commit message:
Three new commands are added in the go-ts-mode to run unit tests.
I would just drop this line altogether, personally.
(go-ts-mode-map): New map variable.
This should probably read something like Add new bindings.
(go-ts-mode-test-file): New function.
(go-ts-mode-test-package): New function.
These two need to be updated (...-test-this-...).
Everything else looks good to me. Thanks for working on this, Ankit.
Eli, if you have no further comments please install when you get a chance. Thanks in advance.
next prev parent reply other threads:[~2024-07-10 23:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:04 bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 16:52 ` Eli Zaretskii
2024-05-14 17:24 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 17:59 ` Eli Zaretskii
2024-05-15 2:36 ` Randy Taylor
2024-05-15 4:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 2:32 ` Randy Taylor
2024-05-16 8:27 ` Eli Zaretskii
2024-05-16 15:03 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 16:01 ` Eli Zaretskii
2024-05-18 9:54 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 2:35 ` Randy Taylor
2024-05-28 2:30 ` Randy Taylor
2024-05-28 19:58 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 18:17 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 2:40 ` Randy Taylor
2024-06-23 14:46 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 2:26 ` Randy Taylor
2024-06-26 11:27 ` Eli Zaretskii
2024-06-26 12:31 ` Randy Taylor
2024-07-06 19:44 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 22:08 ` Stefan Kangas
2024-07-06 22:30 ` Dmitry Gutov
2024-07-07 7:26 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-10 23:43 ` Randy Taylor [this message]
2024-07-11 7:33 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 14:21 ` Randy Taylor
2024-07-12 6:23 ` Eli Zaretskii
2024-07-12 11:10 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 11:21 ` Eli Zaretskii
2024-07-21 6:05 ` Eli Zaretskii
2024-06-23 14:56 ` Eli Zaretskii
2024-05-17 2:27 ` Randy Taylor
2024-05-18 8:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15 11:21 ` Eli Zaretskii
2024-05-16 1:24 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='Aw1pqGXoszlijN37_f3x2HNl-v0smSlppCIoOhUZEJ6Bgt-dTSo4HjFQicqOqDQRaD7E-rsRc4cPmxhL9ej9RneobrWiey_ScDafv_dFUX4=@rjt.dev' \
--to=dev@rjt.dev \
--cc=70939@debbugs.gnu.org \
--cc=ankit@argp.in \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).