From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 01 Jun 2024 01:09:34 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, Dmitry Gutov To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 03:11:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDDH7-0001ea-K2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 03:11:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDDGn-0000wW-5x; Fri, 31 May 2024 21:10:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDDGl-0000w2-As for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:10:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDDGk-0000ci-W1 for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:10:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDDGv-0006xV-TG for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171720420226648 (code B ref 71209); Sat, 01 Jun 2024 01:11:01 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:55492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDDFx-0006vc-Rz for submit@debbugs.gnu.org; Fri, 31 May 2024 21:10:02 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:26181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDDFr-0006vK-SF for 71209@debbugs.gnu.org; Fri, 31 May 2024 21:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1717204177; x=1717463377; bh=Jsup472eKhMeEumYVnnWhtIJYFwU+KvdJ1NJWSkj9pY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=sv+FqB3sFROKHbRzjv13qzkQGr082dm72ryKq7cvoY4CMcqJRtSGFQN2nGO2QtFsM Kt5YvdSvyTUTigb/3szmddNWz5swNT6r9t0i3F8TrKtw5WhueJjIKL/3NjuZESQ35T JA1+nBDZcHYqv4vdKAN2Q7trKvOsa+FdaPehSeXxZx8Emls58e7mURnpBF0hdzQ/Km 3BeUSDzd6I+rjIbpW9FQwX7b8kwOOACc3aaIjSqJTsfOsD1TMXVVNvS+JTKeZ5GNtP 8Wb0JsY930BH8T7UUoaNCgqwZwapW8kXD8W0ps+Gspo75yWV/igdHM7iXsjbz/AAh9 xPnlhCfPEcNsw== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 1d8a650908bb382309f5fa6202f00d5dfda3a132 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286304 Archived-At: On Thursday, May 30th, 2024 at 09:25, Noah Peart w= rote: > > it seems we already highlight this when at treesit-font-lock-level 4? > They get highlighted with `font-lock-variable-use-face` at level 4, but s= houldn't > they be getting `font-lock-variable-name-face` in the 'definition feature= ? >=20 Indeed, thanks. Could someone please install the patch? Thanks in advance. Seems like c++-ts-mode will need to get updated too, as with: for (const auto& i : things) {} i gets font-lock-variable-use-face. I wonder if any other ts modes have similar issues.