From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.bugs Subject: bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers Date: Tue, 25 May 2021 15:58:03 +0200 Message-ID: References: <87imgpw7k3.fsf@warpmail.net> <87mu36enhl.fsf@posteo.net> <8735uru1py.fsf@gnus.org> <871r9yjyv5.fsf@posteo.net> <87h7irqtvf.fsf@gnus.org> <87im37p2b4.fsf@icterid> <87mtsjghns.fsf@icterid> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) Cc: 41438@debbugs.gnu.org, Lars Ingebrigtsen , Juri Linkov To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 16:02:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llXdJ-0008VB-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 16:02:09 +0200 Original-Received: from localhost ([::1]:59010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llXdI-0005yY-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 10:02:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llXaI-0002QI-Dj for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llXaI-0006NI-5n for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llXaI-0007ae-3L for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Arthur Miller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41438 X-GNU-PR-Package: emacs Original-Received: via spool by 41438-submit@debbugs.gnu.org id=B41438.162195109629101 (code B ref 41438); Tue, 25 May 2021 13:59:02 +0000 Original-Received: (at 41438) by debbugs.gnu.org; 25 May 2021 13:58:16 +0000 Original-Received: from localhost ([127.0.0.1]:46465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llXZX-0007ZH-SU for submit@debbugs.gnu.org; Tue, 25 May 2021 09:58:16 -0400 Original-Received: from mail-oln040092075054.outbound.protection.outlook.com ([40.92.75.54]:41415 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llXZU-0007Yz-QF for 41438@debbugs.gnu.org; Tue, 25 May 2021 09:58:14 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUrRIwOwZIhfAdrmgq/sGdCr3hT62/RkkNnhN5a6ld5BVL4Z3kLH9mpgb/ISxGPTivvhQvC1IkFDJkGq040HGYxR99u21HV8hMfzqqO4zAxzms3Sd+gQZluBjKNHLWHTjaSLjO3BEEwmK/A+0FhhZlysZkM6RyyyngxK7X+g24UaaqE8Ei5QwdC9A0QSHIEwBVm3AKW4OranXSE5ErsmwL2ECZmDaS8QXrTOgGXEFxm0Fb1zLJni+zie9goGUhbGSZWroQlWH60Utsrzv2FbR07g1JLbeha9TYPaB6Fqnia9fLX2O/vJODD6hfrGOShHqDBdn1Ee8Ymjx+vwQd357g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCW0sDqsUBsTzPbRTC+hAl2Rlh6eAUffHopXygr2Ots=; b=nAMTS4B9C8arMIFtiIsJ54zUDRhT+qyf7+g0T/nQH18edq/8Ae2M6CsUBEZBU83b4aQBMiqe+P76W4Z0/GZA2NvNP741aigT2nmv5mqOrViImX06QTvZr4M1j6LvPwnIDV1y1xfYGSxT0LO9poMtzy7xY2ygbmqtinaTzpD2iqRBW1pMaa5/mUA+SC08UeZq30NelL3PuQFP1ZdmtTqRR69wsXy5s/EC2fT7fsUOjfNPM0Uj3t+28YDQ+Ou6OioCYKW5ZkcLLEeYUUdweM9z+Nc7H/KareeLFSQ9+GgIqqjVIBjmNLGv2tADssfZc7HCHNWjadoMeOULrygbwDx7og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCW0sDqsUBsTzPbRTC+hAl2Rlh6eAUffHopXygr2Ots=; b=f/UKud9CaGFLNldObRw89ssbIi7HXsCiwNh/6brxxVM4E80uz/7fZg3lpp7XjHsR8lqvcJvI1yWE/w7hwS7ppYQOCV+yGoCIjPlZ+sGMtXp9ZyIPaEi7V7Fmj6f7DVrjLi9YtX4u1eySf9/NjnSndMzFGe1oPxevxsqwoJK3dzRNJpUY2PWbQ1w89WVTWVe35Th1fvc3+FOR8gZ8HLKrTKtkDC9m1303gGgacMXjetLZ5RxASilxTyai8tl/FvajzFHF/8CZ+/rEiuqGcGLQv88EksVF0S8tjlMIYtSCoswB7KkyFnmvXVBJ6eN/1jz+QbmpFDNiDFQ4Bv5dK7nIXQ== Original-Received: from HE1EUR04FT012.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::43) by HE1EUR04HT179.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::391) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Tue, 25 May 2021 13:58:05 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:7e0d::41) by HE1EUR04FT012.mail.protection.outlook.com (2a01:111:e400:7e0d::92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 25 May 2021 13:58:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:FD79D44DAACC2A94DDAB3E1371897997994C54829AC061ADDC6D84BE775D97F6; UpperCasedChecksum:9A7F8E2A58C7CE98FA716DEE782AC27D0125F1C16E624251BA9729D22F122DDD; SizeAsReceived:7741; Count:46 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::d1c1:2a0d:3b2b:4591]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::d1c1:2a0d:3b2b:4591%7]) with mapi id 15.20.4173.020; Tue, 25 May 2021 13:58:05 +0000 In-Reply-To: <87mtsjghns.fsf@icterid> (Philip Kaludercic's message of "Tue, 25 May 2021 11:46:31 +0000") X-TMN: [P6MsaS/0bVg8KyS0s+YfaHoVbsofxSt4] X-ClientProxiedBy: BE0P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::15) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <82eeduoqz8.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from HP-Laptop.homepc (81.232.177.30) by BE0P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Tue, 25 May 2021 13:58:04 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 758f494e-951b-4455-ca6a-08d91f851e36 X-MS-TrafficTypeDiagnostic: HE1EUR04HT179: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qEfRYD55zvUlOrNE9qOdXGZ9/si8FunAjAKKadafK/m1dTX+TK6NfZ6N8Xt7zmHP+qdAxOaEk7K40YD8+pBnGmPzEhbC3KFTla5y+PNvsE57EqFAub//zCu87KFVkhywHeet88uxVpi5VINjdgQUc0iWvatyrQ9mI6aXRRn6bIXHPAnkAVExQKUFLZZszBnDSaVHMB4H6AfzTG3YCSz2fJ5LBlGtGZepXkOiBPriAi1zd9J3tE1FzRpVnyB3bJRhrdFpWyTVm2WH2nyANvM9QD75Z0c/CnID/uW3W9M/Ym8EBXflu/rPrkr3OR6xKrOsl7fwJrz5bCrbX8Sg/wQ3AfyOTPbdZtILB1auFUD8X8nESetcq2QAcA12x65oyL8tvJ8WHA4ZnkHDlKedpc3Svw== X-MS-Exchange-AntiSpam-MessageData: 68UjO17wyybzm+BrGPF6+5fQJtiHvTgPHpJAfgB5RgcVb5sSgPw/sxDctlL/3xvvLXoKkB/CT8MOk9VZTa2syhksyJQzi5vYxDJN9gy8J4TAaWEm9voaurXLhM7blwk7tbxeDw6N1zfnSBdfiid8Ug== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 758f494e-951b-4455-ca6a-08d91f851e36 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 13:58:05.1238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HE1EUR04FT012.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT179 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207217 Archived-At: Philip Kaludercic writes: > Arthur Miller writes: > >> If you are already patching windmove.el, can you consider adding >> bindings for these funcitions too (defined in window.el): >> >> enlarge-window-horizontally >> shrink-window-horizontally >> >> As well as add these two wrappers for vertical operations: >> >> #+begin_src emacs-lisp >> >> ;;;###autoload >> (defun enlarge-window-vertically (delta) >> "Make selected window DELTA columns wider. >> Interactively, if no argument is given, make selected window one >> column wider." >> (interactive "p") >> (enlarge-window delta nil)) >> >> ;;;###autoload >> (defun shrink-window-vertically (delta) >> "Make selected window DELTA columns narrower. >> Interactively, if no argument is given, make selected window one >> column narrower." >> (interactive "p") >> (shrink-window delta nil)) >> >> #+end_src >> >> I have been using those for long time myself since I prefer to do >> everything from the keyboard. Maybe someone else finds them useful too; >> they have been in my config on GH for long time. > > I am not sure if these commands should be added as part of the same > changeset. Those two wrappers itself are not necessary to add, they are just they for the sake of naming. It looks better and more clear what a binding does in "whick-key" window, in help buffers, and provides better symmetry to shrink/enlarge-window-horizontally. original functions are all in window.el: shrink-window enlarge-window shrink-window-horizontally enlarge-window-horizontally > The point of this commit is to make configuring windmove keys > using windmove-default-keybindings & co. more consistent. I completeley understand you are concentrated just on windmove keys. This is just a suggestion. I think windmove should have probably be named from the beginning as "windoperations", since it does more than just move corsor between windows. Shrinking and enlarging windows is definitely a useful window operation to beind on a key, in my opinion should have been in windmove.el since beginning.