unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Arthur Miller <arthur.miller@live.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52129@debbugs.gnu.org
Subject: bug#52129: 29.0.50; Wish: Extend `:align-to center' to work on lines in buffer
Date: Sat, 27 Nov 2021 09:47:58 +0100	[thread overview]
Message-ID: <AM9PR09MB49774F0561A68CDD378F88BF96649@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <83o86616m2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Nov 2021 00:59:30 -0500")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arthur Miller <arthur.miller@live.com>
>> Date: Fri, 26 Nov 2021 21:01:11 +0100
>> 
>> I am not sure if the title is descriptive enough, or even correct, but as seen
>> from attached code and image, I am trying to align two strings in a center of
>> each strings line.
>> 
>> It works now when string-pixel-width correctly calculates pixel widths. However,
>> I would prefer if I could just use :align-to center as a spec for a string as
>> property. Currently we have to use space as a spacer as we used to use
>> gif-spacers back in time.
>> 
>> I am not sure about how semantics would work, there are several cases to
>> consider, but generally if a string or a stretch of text in a string were given
>> text property 'display '(:align-to center), then Emacs would align that stretch
>> of text in the middle of the line that text occupies.
>
> I don't understand what exactly are you asking for.  Is your problem
> that you have to prepend some character to the string and put the
> :align-to spec on that character?  Because AFAIU that simple measure
> should achieve your goal.

You mean something like this:

#+begin_src emacs-lisp
(defun evc--time ()
  (propertize
   (time-stamp-string " %H:%M") 'face evc--time-face 'display '(space :align-to center)))

(defun evc--date ()
  (propertize
   (concat
    " "
    (capitalize (time-stamp-string "%A")) ". "
    (capitalize (time-stamp-string "%B %d"))) 'face evc--date-face 'display '(space :align-to center)))

(defun evc--update ()
  (let ((time (evc--time))
        (date (evc--date)))
    (when (frame-live-p evc--frame)
      (select-frame evc--frame))
    (with-current-buffer evc--buffer
      (erase-buffer)
      (insert time "\n" date))))
#+end_src

That "simple measure" does not achieve the goal of aligning involved strings to
center; or I don't know understand how you mean.

This does:

#+begin_src emacs-lisp
(defun evc--time ()
  (propertize
   (time-stamp-string " %H:%M") 'face evc--time-face))

(defun evc--date ()
  (propertize
   (concat
    (capitalize (time-stamp-string "%A")) ". "
    (capitalize (time-stamp-string "%B %d"))) 'face evc--date-face))

(let* ((tlen (* 0.5 (string-pixel-width time)))
             (dlen (* 0.5 (string-pixel-width date)))
             (spct (propertize " " 'display `(space :align-to (- center (,tlen)))))
             (spcd (propertize " " 'display `(space :align-to (- center (,dlen))))))
        (insert spct time "\n" spcd date))
#+end_src

>                         please show some simple code to explain your
> requests.

I hope above illustrates that it is not just to prepend a space, you have to
calculate how much it should extend to. This has to be done for each line.

Also, even if it would be just to prepend a spacer character, the goal is still
to align text in center of a line, so why can't we just renderer to do it for
us, instead of having such procedural way of telling it what to do. Why can we
not just tell:

(defun evc--time ()
  (propertize
   (time-stamp-string " %H:%M") 'face evc--time-face 'display '(line :align-to center)))

or something similar.

Also what if the text is longer then visual line? Would it be possible for the
rendering engine to center part of the tring with 'aligne-to center' property,
and cull extensive part on sides that are outside. That is not acheavable with a spacer.





  reply	other threads:[~2021-11-27  8:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 20:01 bug#52129: 29.0.50; Wish: Extend `:align-to center' to work on lines in buffer Arthur Miller
2021-11-27  5:59 ` Eli Zaretskii
2021-11-27  8:47   ` Arthur Miller [this message]
2021-11-27  9:15     ` Eli Zaretskii
2021-11-27 11:06       ` Arthur Miller
2021-11-27 11:25         ` Eli Zaretskii
2021-11-27 23:40           ` Arthur Miller
2021-11-28  7:48             ` Eli Zaretskii
2021-11-28 10:38               ` Arthur Miller
2021-11-29 15:59                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM9PR09MB49774F0561A68CDD378F88BF96649@AM9PR09MB4977.eurprd09.prod.outlook.com \
    --to=arthur.miller@live.com \
    --cc=52129@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).