From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8638: 24.0.50; Imenu should not include vacuous defvars Date: Sun, 8 May 2011 12:07:31 -0700 Message-ID: References: <6A3327809B8B440D99CDCDCED77E9575@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1304881693 5087 80.91.229.12 (8 May 2011 19:08:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 8 May 2011 19:08:13 +0000 (UTC) Cc: 8638@debbugs.gnu.org To: "'Juanma Barranquero'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 08 21:08:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ9Kq-0001sA-FQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2011 21:08:08 +0200 Original-Received: from localhost ([::1]:32827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJ9Kp-0006Ay-He for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2011 15:08:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJ9Km-0006Ai-AS for bug-gnu-emacs@gnu.org; Sun, 08 May 2011 15:08:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJ9Kl-0005iE-6R for bug-gnu-emacs@gnu.org; Sun, 08 May 2011 15:08:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJ9Kl-0005iA-0s for bug-gnu-emacs@gnu.org; Sun, 08 May 2011 15:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QJ9Kk-0005JK-F8; Sun, 08 May 2011 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2011 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8638-submit@debbugs.gnu.org id=B8638.130488167720400 (code B ref 8638); Sun, 08 May 2011 19:08:02 +0000 Original-Received: (at 8638) by debbugs.gnu.org; 8 May 2011 19:07:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ9Ke-0005Iz-Lu for submit@debbugs.gnu.org; Sun, 08 May 2011 15:07:56 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ9Kc-0005Im-JX for 8638@debbugs.gnu.org; Sun, 08 May 2011 15:07:55 -0400 Original-Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p48J7k0s003221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 8 May 2011 19:07:48 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p48J7jcK010563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 8 May 2011 19:07:46 GMT Original-Received: from abhmt019.oracle.com (abhmt019.oracle.com [141.146.116.28]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p48J7emD021291; Sun, 8 May 2011 14:07:40 -0500 Original-Received: from dradamslap1 (/10.159.41.120) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 08 May 2011 12:07:39 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcwNsO5Hw8NEN83XTo2bQ0fSlUWB8wAAGx6g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090209.4DC6EA04.00D9:SCFSTAT5015188,ss=1,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 08 May 2011 15:08:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46326 Archived-At: > With lexical binding, (defvar foobar) is used to tell the bytecompiler > that the variable has dynamic scope. It's still a vacuous definition. And any defvar tells the byte compiler that a variable has dynamic scope, no? This seems irrelevant to the bug report. I'd still suggest removing vacuous defvars from the menu. Mixing in vacuous entries with entries that really define variables distracts users. You want to think that accessing a menu item will take you to a real variable definition. If someone wants to provide vacuous defvars in a different submenu from `Variables' (e.g. `Vacuous Vars') I have no problem with that. But I don't really think that's needed. FWIW, this is what I use in my code (imenu+.el): (concat "^\\s-*(" (regexp-opt '("defvar" "defconst" "defconstant" "defcustom" "defparameter" "define-symbol-macro") t) "\\s-+\\(\\sw\\(\\sw\\|\\s_\\)+\\)" "\\s-+[^) \t\n]") Not perfect, perhaps, but it seems to do the job OK so far.