From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6602: [PATCH] make dist target for Windows Date: Sun, 25 Jul 2010 03:01:15 +0200 Message-ID: References: <4C387CF9.4070301@gmail.com> <4C48ED04.2090407@gmail.com> <4C4A5B6A.9080700@gmail.com> <4C4B66D7.8010105@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280020068 23387 80.91.229.12 (25 Jul 2010 01:07:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 01:07:48 +0000 (UTC) Cc: 6602@debbugs.gnu.org To: Christoph Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 25 03:07:46 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocpgu-0001hW-2Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jul 2010 03:07:44 +0200 Original-Received: from localhost ([127.0.0.1]:37866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ocpgt-0006qO-7x for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 21:07:43 -0400 Original-Received: from [140.186.70.92] (port=46786 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ocpgk-0006oz-6J for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 21:07:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ocpgj-0008M1-2D for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 21:07:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37136) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocpgj-0008Lw-0i for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 21:07:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OcpbO-0002xb-I9; Sat, 24 Jul 2010 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2010 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6602 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6602-submit@debbugs.gnu.org id=B6602.128001969711372 (code B ref 6602); Sun, 25 Jul 2010 01:02:02 +0000 Original-Received: (at 6602) by debbugs.gnu.org; 25 Jul 2010 01:01:37 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocpay-0002xN-5e for submit@debbugs.gnu.org; Sat, 24 Jul 2010 21:01:36 -0400 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocpaw-0002xH-M8 for 6602@debbugs.gnu.org; Sat, 24 Jul 2010 21:01:35 -0400 Original-Received: by bwz7 with SMTP id 7so2478283bwz.3 for <6602@debbugs.gnu.org>; Sat, 24 Jul 2010 18:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=hgSpdl5Cx/st9D1Eiaa43GfLWEgFAuPcJdmQQY8uFhI=; b=TIdMVtB07YHxpgOZOtey+aaOvdSnyQ6O/ruUdYfPTbz5hPHs5sGyaBzZhWQ5u1t3po Hwkqm/hcgiMS0pU9YkKhky7bNSmW7z3sktxwUPCVlwirJgShlK30rrQNSXVXBKFpgGCA 06bLL1apavY72jj/RYfFknQY39Tgw436c6Usk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=DjQZlUmQj/6xVcKxz+fz2gHXf/8Mdf1Eu/Zi82g9OWUy10rZdOHFWJT5CBD65sftHD FShsglMQdBMXulBmtEnNFsICJI8NbKq0A11ghTS882wLEnFNcsgCKcjq2A4TaVxptsrt U1wuIZg71xB4cwEPguxdM/rPXEPT3bbzd1XH8= Original-Received: by 10.204.126.153 with SMTP id c25mr4282465bks.27.1280019695224; Sat, 24 Jul 2010 18:01:35 -0700 (PDT) Original-Received: by 10.204.180.136 with HTTP; Sat, 24 Jul 2010 18:01:15 -0700 (PDT) In-Reply-To: <4C4B66D7.8010105@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Jul 2010 21:02:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38887 Archived-At: On Sun, Jul 25, 2010 at 00:19, Christoph wrote: > After testing it in the trunk I remembered: one thing I never was quite s= ure > how to fix best is the fact that when you run `make dist' on the trunk, t= he > root directory the zip file contains is `trunk' (or whatever you named yo= ur > bzr checkout), but it should be `emacs-VERSION'. I noticed, but it was always possible to make a branch emacs-VERSION and build the dist from here. I suppose this change is for better, but it makes more difficult to create a dist with a root directory named other than emacs-VERSION (for my own use, for example, I call them just VERSION, ie., 23.1, 23.2, 24.0.50, etc.). It'd be nice to have a way to customize this, but don't lose time over it; "unzip & rename dir" is just a command away :-) > The main change is that it copies all necessary files to a temporary > directory and then creates the zip files from that. After that the tempor= ary > directory is removed. It is highly unlikely for the user to have a directory nt/emacs-VERSION, but you overwrite it and then remove it, so it'd be nice to check and refuse to do anything if it already exists. Another option would be to write to %TEMP%/%TMP_DIST_DIR% instead of ./%TMP_DIST_DIR% > There is also a minor bugfix: README.W32 was not copied to the install > directory when using `make install'. In fact, there's still a minor issue: README.W32 gets copied to INSTALL_DIR and not removed. For example, I do all installations in-place, and after make dist I end with a README.W32 at the root of my trunk branch. (I've added exclusions to .(bzr|git)ignore, so it's not much of an issue, but still...). =C2=A0 =C2=A0 Juanma