From: Lennart Borgman <lennart.borgman@gmail.com>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: "7296@debbugs.gnu.org" <7296@debbugs.gnu.org>
Subject: bug#7296: display-pixel-height not enough
Date: Mon, 1 Nov 2010 13:00:52 +0100 [thread overview]
Message-ID: <AANLkTincv3W4vR39BDgqGEDgecrzeZ9VUdBgVUCSv+ro@mail.gmail.com> (raw)
In-Reply-To: <4CCEA66C.8060900@swipnet.se>
On Mon, Nov 1, 2010 at 12:37 PM, Jan Djärv <jan.h.d@swipnet.se> wrote:
> 2010-10-31 13:46, Lennart Borgman skrev:
>>
>> On Sun, Oct 31, 2010 at 11:51 AM, Jan Djärv<jan.h.d@swipnet.se> wrote:
>>
>>>>> I know that W32 has some mechanism to maximize a window without
>>>>> fiddling
>>>>> with height and width. You should check if there is a similar way to
>>>>> maximize just height by asking the system to do it.
>>>>
>>>> I told how to do this earlier in this thread. Or did not that message
>>>> reach
>>>> you?
>>>
>>> Actually you did not. You showed how to get display pixel sizes. More
>>> is
>>> needed to correctly calculate the Emacs frame dimensions.
>>
>> Some misunderstanding. I told the API:s for getting the size of the work
>> area.
>
> Whis is not the same thing at all. Making an Emacs frame maximized in
> height from lisp code is so much more, as others have told you. And you
> need a sure way to do this for all platforms and for all window managers if
> it is to be any good at all.
Maybe you are misunderstanding part what I am saying. However I might
have misunderstood something here too. Some clarifications:
- I am speaking mainly about the w32 platform because I know how the
window manager behaves there. I know nothing about the window manages
on other platforms. So please just add suggestions for other platforms
too.
- On w32 display-pixel-height currently returns the total display size
instead of the work area (i.e. the area that the window managers
thinks fit for normally handled windows). I can't see that we have any
use of the total display size on w32. (Though Jason said there might
be. I asked him to clarify this.)
- On w32 you do not maximize a window by setting the size. (I do not
know how this is handled currently in the unpatched Emacs but I
changed it several years ago in my patched Emacs.)
- My initial proposal was to add new functions for the work area size.
However Eli suggested changing display-pixel-height instead on w32 (if
I did not misunderstood Eli). I don't care much which way we do it,
but I think we should have functions to get the size of the work area.
> Nothing is unclear. It is just that you want to change one value for
> another with unforseen consequences for various platforms instead of solving
> the problem, making a window maximized on height.
I am trying to avoid bad consequences, of course (without beeing bug
back compatible).
You may want the max width or height without immediately setting them.
> If we change display-height, it will cause problems on other platforms, X11
> comes to mind, where autohide and panel always on top is something the
> window manager keeps track of. If we only do this for W32 display height
> means two different things. Also as has been pointed out, stuff like
> calculating DPI will be wrong.
Ok. On w32 the window manager also keeps track of those things (with
the API:s I pointed to, but not with the current implementation of
display-pixel-height/width).
So then it looks best to me to add new functions for the work area
size. What do you think of that?
next prev parent reply other threads:[~2010-11-01 12:00 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 10:11 bug#7296: display-pixel-height not enough Lennart Borgman
2010-10-28 18:01 ` Eli Zaretskii
2010-10-28 20:39 ` Lennart Borgman
2010-10-29 7:59 ` Eli Zaretskii
2010-10-29 8:03 ` Lennart Borgman
2010-10-29 10:12 ` Eli Zaretskii
2010-10-29 8:42 ` Lennart Borgman
2010-10-29 10:13 ` Jan Djärv
2010-10-29 10:57 ` Eli Zaretskii
2010-10-29 12:28 ` Lennart Borgman
2010-10-29 13:15 ` Jan D.
2010-10-29 13:38 ` Lennart Borgman
2010-10-29 14:51 ` Drew Adams
2010-10-29 16:53 ` Jan Djärv
2010-10-29 17:37 ` Stefan Monnier
2010-10-29 19:27 ` Lennart Borgman
2010-10-29 19:59 ` Jan D.
2010-10-29 16:24 ` Stefan Monnier
2010-10-29 19:57 ` Jan D.
2010-10-29 20:05 ` Lennart Borgman
2010-10-30 7:28 ` Jan Djärv
2010-10-30 9:25 ` Lennart Borgman
2010-10-30 10:45 ` Jan Djärv
2010-10-30 14:05 ` Lennart Borgman
2010-10-30 15:06 ` Drew Adams
2010-10-30 15:14 ` Lennart Borgman
2010-10-30 17:27 ` Jan Djärv
2010-10-30 17:41 ` Lennart Borgman
2010-10-30 18:30 ` Jan Djärv
2010-10-30 18:59 ` Lennart Borgman
2010-10-31 10:51 ` Jan Djärv
2010-10-31 12:46 ` Lennart Borgman
2010-11-01 11:37 ` Jan Djärv
2010-11-01 12:00 ` Lennart Borgman [this message]
2010-11-01 19:38 ` Jan Djärv
2010-11-01 20:26 ` Eli Zaretskii
2010-11-01 20:35 ` Lennart Borgman
2010-11-01 21:11 ` Jan Djärv
2010-11-01 21:40 ` Eli Zaretskii
2010-11-02 1:09 ` Jason Rumney
2010-11-02 4:01 ` Eli Zaretskii
2010-11-02 13:25 ` Jan D.
2010-11-02 14:53 ` Eli Zaretskii
2010-11-02 16:10 ` Lennart Borgman
2010-11-02 17:48 ` Drew Adams
2010-11-02 17:54 ` Jan Djärv
2010-10-31 3:47 ` Stefan Monnier
2010-10-31 4:13 ` YAMAMOTO Mitsuharu
2010-10-31 10:46 ` Lennart Borgman
2010-11-01 0:10 ` YAMAMOTO Mitsuharu
2010-11-01 0:24 ` Lennart Borgman
2010-11-01 0:56 ` YAMAMOTO Mitsuharu
2010-11-01 1:26 ` Lennart Borgman
2010-11-01 2:46 ` YAMAMOTO Mitsuharu
2010-11-01 10:20 ` Lennart Borgman
2010-11-01 11:40 ` Jan Djärv
2010-11-01 12:04 ` Lennart Borgman
2010-11-01 19:40 ` Jan Djärv
2010-11-02 3:45 ` YAMAMOTO Mitsuharu
2010-11-01 7:44 ` Jason Rumney
2010-11-01 10:12 ` Lennart Borgman
2010-11-01 15:09 ` Drew Adams
2010-11-01 18:08 ` Lennart Borgman
2010-11-02 14:24 ` Stefan Monnier
2010-11-02 15:24 ` Lennart Borgman
2010-11-02 17:17 ` Stefan Monnier
2010-10-31 10:53 ` Jan Djärv
2010-11-02 18:24 ` Drew Adams
2015-01-03 18:46 ` martin rudalics
2015-02-13 18:29 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTincv3W4vR39BDgqGEDgecrzeZ9VUdBgVUCSv+ro@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=7296@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).