From: Lennart Borgman <lennart.borgman@gmail.com>
To: 6915@debbugs.gnu.org
Subject: bug#6915: Please consider making left-margin-width etc buffer local instead of major mode local
Date: Thu, 26 Aug 2010 00:59:01 +0200 [thread overview]
Message-ID: <AANLkTinbeTNjKA-GQE=bDy1VMbjofXXE8N4ztnUch63L@mail.gmail.com> (raw)
I just got a bug report for nXhtml
(https://bugs.launchpad.net/nxhtml/+bug/619587) that seems to be
caused by that left-margin-width is major mode local. I can protect
this from getting changed in mumamo.el, but I wonder whether this
variable and some other variables at the same place in buffer.c should
be made buffer local instead of major mode local. (I.e. I wonder
whether they should be have the property permanent-local set to t.)
To me it looks like it is more likely that it is used as a buffer
local variable (cf linum-mode for example) than a major mode local
variable. And when it is a major mode local variable (as it is today)
it has to be overriden by multi major modes (since the margin width is
per buffer and you do not want it to change while moving in the
buffer).
So I suggest that those variables should be made buffer local.
next reply other threads:[~2010-08-25 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 22:59 Lennart Borgman [this message]
2010-08-26 3:58 ` bug#6915: Please consider making left-margin-width etc buffer local instead of major mode local MON KEY
2010-08-26 9:19 ` Lennart Borgman
2010-08-26 12:16 ` Juanma Barranquero
2010-08-26 12:40 ` Lennart Borgman
2010-08-26 13:05 ` Juanma Barranquero
2010-08-26 20:01 ` Lennart Borgman
2010-08-26 22:20 ` MON KEY
2010-08-26 23:30 ` Lennart Borgman
2010-08-27 2:59 ` MON KEY
2010-08-27 8:39 ` Lennart Borgman
2010-08-28 3:49 ` MON KEY
2010-08-28 6:26 ` Lennart Borgman
2010-08-30 0:45 ` Ken Hori
2010-08-30 0:55 ` Lennart Borgman
2010-08-26 22:51 ` Stefan Monnier
2010-08-27 3:47 ` bug#6915: Please consider making left-margin-width etc buffer local inst MON KEY
2022-04-17 13:55 ` bug#6915: Please consider making left-margin-width etc buffer local instead of major mode local Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinbeTNjKA-GQE=bDy1VMbjofXXE8N4ztnUch63L@mail.gmail.com' \
--to=lennart.borgman@gmail.com \
--cc=6915@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).