From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.bugs Subject: bug#6609: 23.2; Cursor becomes invisible when put over some faces Date: Mon, 12 Jul 2010 12:47:15 +0200 Message-ID: References: <83hbk6unnp.fsf@gnu.org> <83aapyum9c.fsf@gnu.org> <838w5iue9p.fsf@gnu.org> <8339vpvrld.fsf@gnu.org> <83tyo5u7mp.fsf@gnu.org> <83hbk5t9r7.fsf@gnu.org> <838w5ht2cb.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1278932427 2777 80.91.229.12 (12 Jul 2010 11:00:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2010 11:00:27 +0000 (UTC) Cc: 6609@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 12 13:00:26 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGkL-0006Ky-Ln for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 13:00:26 +0200 Original-Received: from localhost ([127.0.0.1]:53172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYGkL-00015q-59 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 07:00:25 -0400 Original-Received: from [140.186.70.92] (port=44530 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYGk7-00011W-N7 for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYGk6-00013s-JJ for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37357) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGk6-00013n-Ht for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OYGYM-0006fP-Hs; Mon, 12 Jul 2010 06:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jul 2010 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6609-submit@debbugs.gnu.org id=B6609.127893166525618 (code B ref 6609); Mon, 12 Jul 2010 10:48:02 +0000 Original-Received: (at 6609) by debbugs.gnu.org; 12 Jul 2010 10:47:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGY5-0006f9-1d for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:47:45 -0400 Original-Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGY3-0006f2-Fw for 6609@debbugs.gnu.org; Mon, 12 Jul 2010 06:47:44 -0400 Original-Received: by wyb40 with SMTP id 40so3113589wyb.3 for <6609@debbugs.gnu.org>; Mon, 12 Jul 2010 03:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=LcQUdciOYgRc3QB7ZFAngUJfrEyELWOnFp5vT32PVpg=; b=DAAjSNqu8G+MVUv+TFFjJ9vJRRH2NVtz2Ewv9Y10eBLmic5AErJ92Q1+0X6NgMefuq KTw6ae8SlHuZRT0ANiQlQ5Qp1+BiJ0oBflda/HeBg1OyWlLEYhhJtYpSTGz3Hr6uH8WU LAwzFDYAyAf2frK7qsQ1egNoezTGoAYNu7Ur4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=szf33HbdADcte88H5vPRxBmwPS2e1dNWc/bJWEeFdHZtdh4nWHzLQRlSXMgSXKSBEx 5ydQCH7vUF54g7KEvxEEEbiRvCgOcHJczSNqnjBU7hRzARdM6FDqMDaWfgJ2+66UC5RA C9aFDYaxsvzPSKvByaScfoxxk3wKJORQKir/o= Original-Received: by 10.216.159.202 with SMTP id s52mr8396819wek.33.1278931665263; Mon, 12 Jul 2010 03:47:45 -0700 (PDT) Original-Received: by 10.216.182.135 with HTTP; Mon, 12 Jul 2010 03:47:15 -0700 (PDT) In-Reply-To: <838w5ht2cb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Jul 2010 06:48:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38441 Archived-At: 2010/7/12 Eli Zaretskii : >> From: Deniz Dogan >> Date: Mon, 12 Jul 2010 10:09:04 +0200 >> Cc: 6609@debbugs.gnu.org >> >> 2010/7/12 Eli Zaretskii : >> >> From: Deniz Dogan >> >> Date: Sun, 11 Jul 2010 21:49:12 +0200 >> >> Cc: 6609@debbugs.gnu.org >> >> >> >> Terribly sorry about that. I did mean white foreground on black >> >> background in the original report! >> > >> > A world of difference. =A0I do see this problem on XP as well, then. >> > >> > Can someone try this on GNU/Linux in a GUI session, please? =A0I'd lik= e >> > to know if this problem is specific to w32. >> > >> > To repeat the recipe: >> > >> > =A0emacs -Q >> > >> > Insert this in the *scratch* buffer: >> > >> > =A0(set-background-color "black") >> > =A0(set-foreground-color "white") >> > >> > Evaluate these two lines. =A0Your cursor will now become invisible. = =A0You >> > can only see it (a) when it is on some text of a non-default color, or >> > (b) when the Emacs frame does not have focus, and the cursor is >> > displayed as a hollow rectangle. >> > >> > "M-x set-face-background RET cursor RET white RET" fixes the problem. >> > So my first guess would be that we don't do that automatically as part >> > of changing the default face, for some reason. >> > >> >> I have tried this on GNU/Linux as well (Bazaar version from some time >> in June) and the problem does not appear there. I can't remember it >> ever happening on GNU/Linux actually. > > Can you please try the patch below? =A0If it works for you, I will > commit it to the emacs-23 branch. > > =3D=3D=3D modified file 'src/w32fns.c' > --- src/w32fns.c =A0 =A0 =A0 =A02010-07-10 18:52:53 +0000 > +++ src/w32fns.c =A0 =A0 =A0 =A02010-07-12 10:31:49 +0000 > @@ -1333,7 +1333,10 @@ x_set_foreground_color (struct frame *f, > =A0 if (FRAME_W32_WINDOW (f) !=3D 0) > =A0 =A0 { > =A0 =A0 =A0 if (x->cursor_pixel =3D=3D old_fg) > - =A0 =A0 =A0 x->cursor_pixel =3D fg; > + =A0 =A0 =A0 { > + =A0 =A0 =A0 =A0 x->cursor_pixel =3D fg; > + =A0 =A0 =A0 =A0 x->cursor_gc->background =3D fg; > + =A0 =A0 =A0 } > > =A0 =A0 =A0 update_face_from_frame_parameter (f, Qforeground_color, arg); > =A0 =A0 =A0 if (FRAME_VISIBLE_P (f)) > > I don't build my Emacs on Windows, only on GNU/Linux. Could someone else running Windows try it? Thanks.