From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 6609@debbugs.gnu.org
Subject: bug#6609: 23.2; Cursor becomes invisible when put over some faces
Date: Mon, 12 Jul 2010 12:47:15 +0200 [thread overview]
Message-ID: <AANLkTinazlWAhewV8xE9cb1y0UB1cYFzHNGz6DqmXavV@mail.gmail.com> (raw)
In-Reply-To: <838w5ht2cb.fsf@gnu.org>
2010/7/12 Eli Zaretskii <eliz@gnu.org>:
>> From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
>> Date: Mon, 12 Jul 2010 10:09:04 +0200
>> Cc: 6609@debbugs.gnu.org
>>
>> 2010/7/12 Eli Zaretskii <eliz@gnu.org>:
>> >> From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
>> >> Date: Sun, 11 Jul 2010 21:49:12 +0200
>> >> Cc: 6609@debbugs.gnu.org
>> >>
>> >> Terribly sorry about that. I did mean white foreground on black
>> >> background in the original report!
>> >
>> > A world of difference. I do see this problem on XP as well, then.
>> >
>> > Can someone try this on GNU/Linux in a GUI session, please? I'd like
>> > to know if this problem is specific to w32.
>> >
>> > To repeat the recipe:
>> >
>> > emacs -Q
>> >
>> > Insert this in the *scratch* buffer:
>> >
>> > (set-background-color "black")
>> > (set-foreground-color "white")
>> >
>> > Evaluate these two lines. Your cursor will now become invisible. You
>> > can only see it (a) when it is on some text of a non-default color, or
>> > (b) when the Emacs frame does not have focus, and the cursor is
>> > displayed as a hollow rectangle.
>> >
>> > "M-x set-face-background RET cursor RET white RET" fixes the problem.
>> > So my first guess would be that we don't do that automatically as part
>> > of changing the default face, for some reason.
>> >
>>
>> I have tried this on GNU/Linux as well (Bazaar version from some time
>> in June) and the problem does not appear there. I can't remember it
>> ever happening on GNU/Linux actually.
>
> Can you please try the patch below? If it works for you, I will
> commit it to the emacs-23 branch.
>
> === modified file 'src/w32fns.c'
> --- src/w32fns.c 2010-07-10 18:52:53 +0000
> +++ src/w32fns.c 2010-07-12 10:31:49 +0000
> @@ -1333,7 +1333,10 @@ x_set_foreground_color (struct frame *f,
> if (FRAME_W32_WINDOW (f) != 0)
> {
> if (x->cursor_pixel == old_fg)
> - x->cursor_pixel = fg;
> + {
> + x->cursor_pixel = fg;
> + x->cursor_gc->background = fg;
> + }
>
> update_face_from_frame_parameter (f, Qforeground_color, arg);
> if (FRAME_VISIBLE_P (f))
>
>
I don't build my Emacs on Windows, only on GNU/Linux. Could someone
else running Windows try it? Thanks.
next prev parent reply other threads:[~2010-07-12 10:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 11:25 bug#6609: 23.2; Cursor becomes invisible when put over some faces Deniz Dogan
2010-07-11 13:57 ` Eli Zaretskii
2010-07-11 14:13 ` Deniz Dogan
2010-07-11 14:18 ` Eli Zaretskii
2010-07-11 14:38 ` Deniz Dogan
2010-07-11 17:48 ` Eli Zaretskii
2010-07-11 18:27 ` Deniz Dogan
2010-07-11 14:27 ` Eli Zaretskii
2010-07-11 14:38 ` Deniz Dogan
2010-07-11 17:02 ` Deniz Dogan
2010-07-11 17:20 ` Eli Zaretskii
2010-07-11 17:24 ` Deniz Dogan
2010-07-11 17:46 ` Eli Zaretskii
2010-07-11 18:24 ` Deniz Dogan
2010-07-11 19:43 ` Eli Zaretskii
2010-07-11 19:49 ` Deniz Dogan
2010-07-12 7:55 ` Eli Zaretskii
2010-07-12 8:09 ` Deniz Dogan
2010-07-12 10:35 ` Eli Zaretskii
2010-07-12 10:47 ` Deniz Dogan [this message]
2010-07-12 12:28 ` Eli Zaretskii
2010-07-13 23:43 ` Juanma Barranquero
2010-07-14 7:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinazlWAhewV8xE9cb1y0UB1cYFzHNGz6DqmXavV@mail.gmail.com \
--to=deniz.a.m.dogan@gmail.com \
--cc=6609@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).