From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6420: Some enhancements to debugging Date: Mon, 14 Jun 2010 20:02:57 +0200 Message-ID: References: <83y6ehijhy.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276540536 29317 80.91.229.12 (14 Jun 2010 18:35:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Jun 2010 18:35:36 +0000 (UTC) Cc: 6420@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 14 20:35:34 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OOEVR-0005tn-Lc for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jun 2010 20:35:33 +0200 Original-Received: from localhost ([127.0.0.1]:47584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOETe-00046i-3b for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jun 2010 14:33:42 -0400 Original-Received: from [140.186.70.92] (port=39385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOEOi-00034S-Hw for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOEOb-0008Tn-Cj for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44355) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOEOb-0008Th-BN for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OOE0v-00017g-It; Mon, 14 Jun 2010 14:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jun 2010 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6420-submit@debbugs.gnu.org id=B6420.12765386054307 (code B ref 6420); Mon, 14 Jun 2010 18:04:01 +0000 Original-Received: (at 6420) by debbugs.gnu.org; 14 Jun 2010 18:03:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOE0K-00017Q-Kw for submit@debbugs.gnu.org; Mon, 14 Jun 2010 14:03:24 -0400 Original-Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOE0I-00017L-W6 for 6420@debbugs.gnu.org; Mon, 14 Jun 2010 14:03:23 -0400 Original-Received: by gyh4 with SMTP id 4so2753698gyh.3 for <6420@debbugs.gnu.org>; Mon, 14 Jun 2010 11:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=6sTkCQkzvxoUfKpqjw5kpyrTTFC4yLH+OAIl9M+HrSs=; b=BGSHYZw80BV+jtBtskjeGPLhfkVB0L29khZrShDq+a6fOLkHxX7BiA7cjjYQSx6koe fLnEacdknwoFshyaovL7pvLV6b/j5P9gYorI06pzoOa7wHx3lsjA1RpjvFKxLId8w9Gs P0UxPozWlutI9O8SoTmTnaBzxNj6UH0xwKAH8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=CzerMdHiYSCZh8vgK2JBJdamNRqSs4mrywxTRC7MLGmlkNvHPwlhPa65W4jcfQo2/O 1xCcAjruQVQFbUQ0QDBSmgK9R7g/S3REsnblgDXbJu/TG5b9SxJ4e0GrW/KUlY9rEtzn ecD4PidggGry/PTAQ3EGv6rbfwLaFORZwS5JM= Original-Received: by 10.101.160.30 with SMTP id m30mr5060679ano.192.1276538597407; Mon, 14 Jun 2010 11:03:17 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Mon, 14 Jun 2010 11:02:57 -0700 (PDT) In-Reply-To: <83y6ehijhy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 14 Jun 2010 14:04:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37779 Archived-At: On Mon, Jun 14, 2010 at 7:58 PM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Mon, 14 Jun 2010 08:11:59 +0200 >> Cc: >> >> =3D=3D=3D modified file 'src/w32proc.c' >> --- trunk/src/w32proc.c =C2=A0 =C2=A0 =C2=A0 2010-06-04 14:13:35 +0000 >> +++ patched/src/w32proc.c =C2=A0 =C2=A0 2010-06-14 05:53:50 +0000 >> @@ -121,9 +121,17 @@ >> =C2=A0{ >> =C2=A0 =C2=A0char buf[1024]; >> =C2=A0 =C2=A0va_list args; >> + =C2=A0char *buf_pos =3D buf; >> + >> + =C2=A0/* On NT add thread id */ >> +#ifdef WINDOWSNT >> + =C2=A0DWORD thread_id =3D GetCurrentThreadId (); >> + =C2=A0sprintf (buf_pos, "[Th%04x] =C2=A0", thread_id); >> + =C2=A0buf_pos =3D buf_pos + 10; >> +#endif > > The above #ifdef is unnecessary: all the platforms that compile this > file have WINDOWSNT defined by definition. OK, I thought it maybe was used by the ms-dos port too. > Also, why do you use magic constants such as 10, instead of the value > returned by `sprintf'? Eh, because my C fu is low. Of course the return value should be used inste= ad. >> - =C2=A0 =C2=A0 =C2=A0 DebPrint (("reader_thread.SetEvent failed with %l= u for fd %ld\n", >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GetLastE= rror (), cp->fd)); >> + =C2=A0 =C2=A0 =C2=A0 DebPrint (("reader_thread.SetEvent failed with %l= u for fd %ld, pid %ld\n", >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GetLastE= rror (), cp->fd, cp->pid)); > > cp->fd and cp->pid are both `int', so no need for `l' in `%ld'. =C2=A0Jus= t > use `%d'. > >> +If the message is longer than 1000 chars it will be split in several >> +lines. > > Not really 1000, since you are prepending a thread ID, no? Yes, I was not very specific there. I did not think it was that important.