From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Keitaro Miyazaki Newsgroups: gmane.emacs.bugs Subject: bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly. Date: Sun, 23 Jan 2011 16:08:21 +0900 Message-ID: References: <87mxmtbpvy.fsf@stupidchicken.com> <87d3noy81o.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1295767515 833 80.91.229.12 (23 Jan 2011 07:25:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 23 Jan 2011 07:25:15 +0000 (UTC) Cc: 7650@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 23 08:25:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PguJy-000578-2x for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jan 2011 08:25:10 +0100 Original-Received: from localhost ([127.0.0.1]:56753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PguJx-0000Be-Eu for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jan 2011 02:25:09 -0500 Original-Received: from [140.186.70.92] (port=42063 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PguJk-0000AS-5u for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2011 02:24:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PguJi-0002I4-H8 for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2011 02:24:56 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PguJi-0002I0-Fb for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2011 02:24:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pgtwc-0003SA-26; Sun, 23 Jan 2011 02:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Keitaro Miyazaki Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jan 2011 07:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7650 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7650-submit@debbugs.gnu.org id=B7650.129576602713230 (code B ref 7650); Sun, 23 Jan 2011 07:01:01 +0000 Original-Received: (at 7650) by debbugs.gnu.org; 23 Jan 2011 07:00:27 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pgtw2-0003RL-0K for submit@debbugs.gnu.org; Sun, 23 Jan 2011 02:00:26 -0500 Original-Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pgtvz-0003R7-BB for 7650@debbugs.gnu.org; Sun, 23 Jan 2011 02:00:24 -0500 Original-Received: by iyi42 with SMTP id 42so3149584iyi.3 for <7650@debbugs.gnu.org>; Sat, 22 Jan 2011 23:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5seJZ6lB/owAuYg74W5OUmVmFfHxFcOyO0jAxtCm4HA=; b=hN5DWR1Y8qp9Eoqv+cL7RcxsrtH3JRReucWmYZCtVfApDyrDrG6Kx0sh2CjFLypGes tcG1N9fW2u1sStUqwLv5cZnNjExk0ScOsFDFbt6Z833zG9BAbdg4K8U06R1PPxEEiUC8 CEMVPgyElJ2UaItwPzq+5XgjG1x5dpeG3bkP4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=kwiDa0HmvAn9xiqx1oeMGxALe+5YxxqsL1XXPELrtKJHqpOhfLdCQZMBsm2gXeJcZz +PpBjgtm9+AELCVhm8tpG07dDNrGy6NeeiAUjIRYbsNQ9DRKG+9rUIEEdoJPz5wGVpPt gUEGEsnyacGyvx1mqxgyoVnKV0N5JVXPC1weI= Original-Received: by 10.231.30.70 with SMTP id t6mr3061193ibc.165.1295766501440; Sat, 22 Jan 2011 23:08:21 -0800 (PST) Original-Received: by 10.231.160.211 with HTTP; Sat, 22 Jan 2011 23:08:21 -0800 (PST) In-Reply-To: <87d3noy81o.fsf@stupidchicken.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 23 Jan 2011 02:01:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43559 Archived-At: On Sun, Jan 23, 2011 at 5:53 AM, Chong Yidong wrote: > Thanks, now I see it. I've commited your patch. I tried your commit, though it seems that the menu "Case sensitive" still won't be updated properly. I think that a check mark on the menu should be TURNED ON at step 6 of my step-by-step procedure, because this menu should tell the status of a variable `case-fold-search' in `reb-target-buffer' (in my example, the buffer "*scratch*" is set to this variable) to user. Could you try my patch again? --- emacs/lisp/emacs-lisp/re-builder.el.orig 2011-01-23 15:44:02.000000000 +0900 +++ emacs/lisp/emacs-lisp/re-builder.el 2011-01-23 15:46:41.000000000 +0900 @@ -243,7 +243,7 @@ Except for Lisp syntax this is the same :help "Quit the RE Builder mode")) (define-key menu-map [rt] '(menu-item "Case sensitive" reb-toggle-case - :button (:toggle . (null case-fold-search)) + :button (:toggle . (with-current-buffer reb-target-buffer case-fold-search)) :help "Toggle case sensitivity of searches for RE Builder target buffer")) (define-key menu-map [rb] '(menu-item "Change target buffer..." reb-change-target-buffer Best regards, Keitaro -- This bug report will be sent to the Free Software Foundation, not to your local site managers! Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your report will be posted to the bug-gnu-emacs@gnu.org mailing list and the gnu.emacs.bug news group, and at http://debbugs.gnu.org. Please describe exactly what actions triggered the bug and the precise symptoms of the bug. If you can, give a recipe starting from `emacs -Q': If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/kay/Work/emacs-current/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG. In GNU Emacs 24.0.50.2 (x86_64-apple-darwin10.6.0, NS apple-appkit-1038.35) of 2011-01-23 on mac Windowing system distributor `Apple', version 10.3.1038 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: ja_JP.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: RE Builder Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x b * s c r a t c h * A b C d M-x r e - b u a b c d M-x r e p o r t - e m a c s - b u g Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. 195 matches [2 times] 11 matches 1 match [3 times] No matches 1 match Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug help-mode easymenu view re-builder japan-util tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs)