From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.bugs Subject: bug#6828: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows Date: Mon, 9 Aug 2010 02:28:26 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e0cb4e887bc117d1d9048d591aec X-Trace: dough.gmane.org 1281314413 3404 80.91.229.12 (9 Aug 2010 00:40:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 9 Aug 2010 00:40:13 +0000 (UTC) To: 6828@debbugs.gnu.org, rcyeske@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 09 02:40:10 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGPR-0006ec-2h for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Aug 2010 02:40:09 +0200 Original-Received: from localhost ([127.0.0.1]:45546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiGPQ-0003G2-Er for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Aug 2010 20:40:08 -0400 Original-Received: from [140.186.70.92] (port=49164 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiGNq-0003Do-Lc for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:38:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiGNp-0005qL-18 for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:38:30 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46255) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGNo-0005qG-UF for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:38:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OiGEg-00007a-2S; Sun, 08 Aug 2010 20:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Aug 2010 00:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Ryan Yeske Original-Received: via spool by submit@debbugs.gnu.org id=B.1281313704455 (code B ref -1); Mon, 09 Aug 2010 00:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Aug 2010 00:28:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGE4-00007I-86 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:28:24 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGE2-00007D-43 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:28:23 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:57840) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OiGEf-0000WH-G5 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:29:01 -0400 Original-Received: from [140.186.70.92] (port=60377 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiGEd-0001nW-B3 for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:29:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiGEb-0004bP-FP for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:28:58 -0400 Original-Received: from mail-qw0-f41.google.com ([209.85.216.41]:64180) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGEb-0004bJ-DG for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:28:57 -0400 Original-Received: by qwk4 with SMTP id 4so7771421qwk.0 for ; Sun, 08 Aug 2010 17:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=FrasqIeeRLncPgpLp0V1Mf1ylpDsnwu8MSX5Fy4tHNY=; b=qxswZS7YjKL/AGslWAcFtM1G130MkU+HaylnhUb+5sCXXWHepYNgjgvTlg6wXHOhJa 7g6xOWxEmEkRM7GJOvkO60jV+EjrkWSyw6laCTOqftibemLfViFCX26jCGtwBipRliEX tmCESB5Y72HbO8BYY16nrW5Je52QU+1q7dav0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=o3zjmLGSS9IiwiWf10rQzCd8EyKHW58xKoQ3CuyCQ0oSh4pKCHxGptx+6Yc6Nh8m1f q/WCQTxGLDj+Lf4Vy3nmgl33L0nWGIfB51sgtkzV5fO0Kna2dabVffCXUOxO+owoaLIA UjTe3vWuQGJKmd0Hkhzwr1wD/B+ccKWaIu+VU= Original-Received: by 10.220.157.141 with SMTP id b13mr9247386vcx.27.1281313736216; Sun, 08 Aug 2010 17:28:56 -0700 (PDT) Original-Received: by 10.220.188.77 with HTTP; Sun, 8 Aug 2010 17:28:26 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 08 Aug 2010 20:29:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39326 Archived-At: --e0cb4e887bc117d1d9048d591aec Content-Type: text/plain; charset=ISO-8859-1 The rcirc logging facility doesn't play nicely when it comes to writing process buffers (or "server buffers") to disk on Windows systems. The generated log filenames contain asterisks which are not allowed on Windows systems. This makes rcirc and Emacs as a whole unusable when rcirc-log-flag is non-nil, i.e. when logging to disk is turned on. Emacs just messages errors in the echo area when this happens and you can't easily stop it. Attached is a patch which introduces a new function and a new customizable variable. rcirc-generate-log-filename is the function which takes care of generating filenames for rcirc buffer logs. It is now the default instead of the old rcirc-generate-new-buffer-name. rcirc-log-process-buffers is the new variable which decides whether or not to log process buffers to disk at all. I get the feeling that not that many people are interested in logging this as it rarely contains any useful information that you would want to store. Nevertheless, the variable is non-nil by default which turns on process buffer logging. The setup I'm using by the way: In GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600) of 2010-08-02 on 3249CTO Windowing system distributor `Microsoft Corp.', version 6.1.7600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include' -- Deniz Dogan --e0cb4e887bc117d1d9048d591aec Content-Type: application/octet-stream; name="rcirc-log-patch-dd.diff" Content-Disposition: attachment; filename="rcirc-log-patch-dd.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gcml1ps90 MTUxMCwxNTExYzE1MTAsMTUxMw0KPCAgICAgICAod2hlbiByY2lyYy1sb2ctZmxhZw0KPCAgICAg ICAgIChyY2lyYy1sb2cgcHJvY2VzcyBzZW5kZXIgcmVzcG9uc2UgdGFyZ2V0IHRleHQpKQ0KLS0t DQo+ICAgICAgICh3aGVuIChhbmQgcmNpcmMtbG9nLWZsYWcNCj4gICAgICAgICAgICAgICAgICAg IChvciB0YXJnZXQNCj4gICAgICAgICAgICAgICAgICAgICAgICByY2lyYy1sb2ctcHJvY2Vzcy1i dWZmZXJzKSkNCj4gICAgICAgICAgIChyY2lyYy1sb2cgcHJvY2VzcyBzZW5kZXIgcmVzcG9uc2Ug dGFyZ2V0IHRleHQpKQ0KMTUxN2MxNTE5LDE1MjkNCjwgKGRlZmN1c3RvbSByY2lyYy1sb2ctZmls ZW5hbWUtZnVuY3Rpb24gJ3JjaXJjLWdlbmVyYXRlLW5ldy1idWZmZXItbmFtZQ0KLS0tDQo+IChk ZWZ1biByY2lyYy1nZW5lcmF0ZS1sb2ctZmlsZW5hbWUgKHByb2Nlc3MgdGFyZ2V0KQ0KPiAgIChp ZiB0YXJnZXQNCj4gICAgICAgKHJjaXJjLWdlbmVyYXRlLW5ldy1idWZmZXItbmFtZSBwcm9jZXNz IHRhcmdldCkNCj4gICAgIChwcm9jZXNzLW5hbWUgcHJvY2VzcykpKQ0KPg0KPiAoZGVmY3VzdG9t IHJjaXJjLWxvZy1wcm9jZXNzLWJ1ZmZlcnMgdA0KPiAgICJOb24tbmlsIGlmIHJjaXJjIHByb2Nl c3MgYnVmZmVycyBzaG91bGQgYmUgbG9nZ2VkIHRvIGRpc2suIg0KPiAgIDpncm91cCAncmNpcmMN Cj4gICA6dHlwZSAnYm9vbGVhbikNCj4NCj4gKGRlZmN1c3RvbSByY2lyYy1sb2ctZmlsZW5hbWUt ZnVuY3Rpb24gJ3JjaXJjLWdlbmVyYXRlLWxvZy1maWxlbmFtZQ== --e0cb4e887bc117d1d9048d591aec--