From: Lennart Borgman <lennart.borgman@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 6385@debbugs.gnu.org
Subject: bug#6385: A slightly less aggressive fit-window-to-buffer
Date: Sun, 13 Jun 2010 17:23:51 +0200 [thread overview]
Message-ID: <AANLkTinF2yQTrBUIGiqXZMu5qUjgYsUdDWDLrRQAzkwJ@mail.gmail.com> (raw)
In-Reply-To: <4C148E06.2040308@gmx.at>
On Sun, Jun 13, 2010 at 9:51 AM, martin rudalics <rudalics@gmx.at> wrote:
>> Can't we just throw in a better code instead of fit-window-to-buffer?
>> (And rename fit-window-to-buffer to killing-window-fit-to-buffer if
>> someone really wants it.)
>>
>> It does not have to be perfect. Just good enough. We can surely make
>> it better later if we need to.
>
> I suppose there's no need for a `killing-window-fit-to-buffer'. Writing
> a non-killing one with Emacs 23 means can be done in a number of ways:
>
> (1) Use `adjust-window-trailing-edge'. IIRC that's what you already did
> when you wrote your window balancing algorithm so you know how to do
> that.
>
> (2) Save the window configuration and the number of windows around the
> `enlarge-window' call in `fit-window-to-buffer' and restore the
> configuration when a window got deleted. That's more or less what
> `adjust-window-trailing-edge' does internally.
>
> (3) Adjust enlarge_window so it doesn't delete windows.
>
> Since I don't understand enlarge_window any more I can't give you advice
> on (3). If you want to try (1) or (2) ask me if you encounter problems.
Thanks. Writing the code is probably not a big problem, keeping
another patch in my patched Emacs is. So I will write a new version
and send it here. (I wonder if I had not written it already and threw
it away to avoid keeping another patch.)
next prev parent reply other threads:[~2010-06-13 15:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 18:56 bug#6385: A slightly less aggressive fit-window-to-buffer Lennart Borgman
2010-06-11 13:21 ` martin rudalics
2010-06-11 17:15 ` Lennart Borgman
2010-06-12 8:00 ` martin rudalics
2010-06-12 13:03 ` Lennart Borgman
2010-06-12 14:16 ` martin rudalics
2010-06-12 14:24 ` Lennart Borgman
2010-06-13 7:51 ` martin rudalics
2010-06-13 15:23 ` Lennart Borgman [this message]
2010-06-12 15:21 ` Drew Adams
2010-06-13 7:51 ` martin rudalics
2010-06-13 12:39 ` Drew Adams
2010-06-13 14:34 ` martin rudalics
2010-06-13 15:20 ` Lennart Borgman
2010-06-13 17:44 ` martin rudalics
2010-06-13 17:48 ` Lennart Borgman
2010-06-13 16:33 ` Drew Adams
2010-06-13 17:45 ` martin rudalics
2010-06-13 18:21 ` Drew Adams
2010-06-13 20:04 ` Stefan Monnier
2010-06-14 6:49 ` martin rudalics
2010-06-14 6:57 ` Drew Adams
2011-10-11 9:31 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinF2yQTrBUIGiqXZMu5qUjgYsUdDWDLrRQAzkwJ@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=6385@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).