From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6963: More usecases, patch attached Date: Wed, 29 Sep 2010 16:42:41 +0200 Message-ID: References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1285773115 2822 80.91.229.12 (29 Sep 2010 15:11:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 29 Sep 2010 15:11:55 +0000 (UTC) Cc: 6963@debbugs.gnu.org To: Wolfgang Schnerring Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 29 17:11:54 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yK1-0006zJ-Nz for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Sep 2010 17:11:54 +0200 Original-Received: from localhost ([127.0.0.1]:52187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0yK0-0002Vh-PD for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Sep 2010 11:11:52 -0400 Original-Received: from [140.186.70.92] (port=42892 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0yJf-0002JA-LC for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 11:11:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0yJX-0001sz-9W for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 11:11:31 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50512) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yJX-0001st-86 for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 11:11:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0xqA-0005GS-3F; Wed, 29 Sep 2010 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128577123520230 (code B ref 6963); Wed, 29 Sep 2010 14:41:02 +0000 Original-Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 14:40:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xpi-0005GF-Hf for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:40:34 -0400 Original-Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xpg-0005GA-49 for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 10:40:32 -0400 Original-Received: by iwn3 with SMTP id 3so1041072iwn.3 for <6963@debbugs.gnu.org>; Wed, 29 Sep 2010 07:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ohgd0ZlbkNyKpFpE2K4FBMKAqNVAmR50+1Y+zs+TzfM=; b=FQfoW+bamoGNeRTRudVLu1DeSfxp2r3G/QZj2+qYwabCu/+6NaLVuBuMiDMepjg9lU OcuAYqiNTPy0Tqo6c+0xwuxu/IL3wOql3W1nyQ784QlsSi+7cc0enEyDQcPvPGtCKykH FgaLQ2xYXt7llc1v/OlVXUafuCHNVte97UdKc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=hKHBWFnj6u5PExExghhD/Zbt+rH/UrdOnVUGBpZpJ3l3jwDmzk+Pj30QCMHaMb2R85 cL+N0by4c0/Smqh3AKfl+P5BnxPHiYgElkLb8H//WfZxwE0Agz19i6BRNX/cRzLf5XS1 ODUg6y6zcANypFUyoDiXNfBC6QKlX+fYBjc5M= Original-Received: by 10.231.157.135 with SMTP id b7mr1862676ibx.164.1285771401632; Wed, 29 Sep 2010 07:43:21 -0700 (PDT) Original-Received: by 10.231.196.71 with HTTP; Wed, 29 Sep 2010 07:42:41 -0700 (PDT) In-Reply-To: <20100929060918.GB9654@elzar.ws.whq.gocept.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 29 Sep 2010 10:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40542 Archived-At: On Wed, Sep 29, 2010 at 08:09, Wolfgang Schnerring wrote: > But that it does not signal error > situations via its exit status It does in most cases. > since emacsclient returns 0 no matter what. That's not accurate. When emacsclient detects a problem with itself (missing server file, error opening socket, etc.) it returns EXIT_FAILURE (1). What it currently does not do, however, is returning EXIT_FAILURE for errors passed back from Emacs. > I've attached a patch that makes emacsclient exit with nonzero status > when it receives an error message from Emacs -- it already *prints* > "*ERROR*" in these cases, so I feel this makes a lot of sense. Yes, it makes sense, because after -error the client's process is deleted, so emacsclient exits immediately. So, two questions remain: - should this be considered a bug, and installed on emacs-23, or a new feature, for the trunk? - should emacsclient return 1 for these new errors, or a new error code (2) to allow distinguishing them? =C2=A0 =C2=A0 Juanma