From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: sho nakatani Newsgroups: gmane.emacs.bugs Subject: bug#8364: 24.0.9999; PATCH: Fit to width/height/page for doc-view.el Date: Wed, 30 Mar 2011 23:35:51 +0900 Message-ID: References: <878vvz8sml.fsf@fastmail.fm> <87k4fj6z8e.fsf@member.fsf.org> <87hbanw3ll.fsf@member.fsf.org> <87vcz0x62y.fsf@member.fsf.org> <87ipv0wxuw.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1301495893 26813 80.91.229.12 (30 Mar 2011 14:38:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Mar 2011 14:38:13 +0000 (UTC) Cc: 8364@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 30 16:38:09 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4wX7-0001Rr-Vd for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Mar 2011 16:38:06 +0200 Original-Received: from localhost ([127.0.0.1]:53588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4wX7-0003ep-8D for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Mar 2011 10:38:05 -0400 Original-Received: from [140.186.70.92] (port=37098 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4wWQ-00034y-5B for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 10:37:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4wWP-0000uz-4j for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 10:37:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4wWP-0000uk-2l for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 10:37:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q4wV7-0001xy-TC; Wed, 30 Mar 2011 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sho nakatani Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2011 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8364-submit@debbugs.gnu.org id=B8364.13014957597549 (code B ref 8364); Wed, 30 Mar 2011 14:36:01 +0000 Original-Received: (at 8364) by debbugs.gnu.org; 30 Mar 2011 14:35:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4wV4-0001xi-Q4 for submit@debbugs.gnu.org; Wed, 30 Mar 2011 10:35:59 -0400 Original-Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4wV3-0001xX-GJ for 8364@debbugs.gnu.org; Wed, 30 Mar 2011 10:35:57 -0400 Original-Received: by wwb28 with SMTP id 28so1668106wwb.15 for <8364@debbugs.gnu.org>; Wed, 30 Mar 2011 07:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=vluYVSJ9RzALzMzcRc+UmItYFszrPlzuDoDNwqrtPW0=; b=IG6gW3Hcv1Z1wCI7KIGEdNOLv7b9lqj5lmyP/Fp23VzP1KUAH2CjgRGBt0C7iLwz3y b4eL180OYgZHWuAElL1RKKl0kKb1cwdutshIUNTPQzogODHHC8i8/1g1Vod7BWS1rCqg PPb1XPfjmhdG78XLJ0VXXp1Karf01F7/yTR48= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=tfmX3xzCaLKSWGNOp2Vkky8rhghQ2sO1j9Gm7EVwiq88qgfCwQfl//LYkDWevQFIBJ vD4zIV5p1iJLO4K1ZhfClhRXuqUGQraQPO1XvF3Zwjb3+OpHDllGW4VSfNjgzb9kthhj /P6ZJu1vx8G6hFhRptq5gnipEjBRbG6OjhG5s= Original-Received: by 10.216.120.193 with SMTP id p43mr1193819weh.92.1301495751688; Wed, 30 Mar 2011 07:35:51 -0700 (PDT) Original-Received: by 10.216.120.146 with HTTP; Wed, 30 Mar 2011 07:35:51 -0700 (PDT) In-Reply-To: <87ipv0wxuw.fsf@member.fsf.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Mar 2011 10:36:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45500 Archived-At: Tassilo Hi Tassilo, >> But your function doesn't work for some files. > > What exactly doesn't work? I meant that after calling `doc-view-fit-slice-width-to-window' the image disappeared from the window. I tested some files written in both English and Japanese. After that, I realized only images written in Japanese sometimes (not always) cause this error. I guess this error is related with font set and ghostscript, or my own environment. We non-Westerner are sometimes bothered by errors related by fonts. Actually, DocViewMode display files in English quite well but sometimes it fails to display files in Japanese. In my opinion, current implementation is enough for use. As I said, I sometimes fail to view PDF/PS files in DocViewMode, so I don't mind so much even if `doc-view-fit-slice-width-to-window' causes an error. Also, if a file written in Japanese can be displayed by DocViewMode, at least `doc-view-fit-*-to-window' without slice succeeds. Adding `doc-view-fit-slice-to-window' feature does help viewing English files, and it does not do ANY harm for viewing Japanese files. So I suggest to add this new feature. I'll send a patch soon. Thanks. -- Sho Nakatani