From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: MON KEY Newsgroups: gmane.emacs.bugs Subject: bug#7518: image-dired defcustom'd paths Date: Sun, 5 Dec 2010 19:56:36 -0500 Message-ID: References: <8762v9jagu.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1291598134 15057 80.91.229.12 (6 Dec 2010 01:15:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Dec 2010 01:15:34 +0000 (UTC) Cc: 7518@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 06 02:15:29 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PPPfs-00072z-2L for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Dec 2010 02:15:28 +0100 Original-Received: from localhost ([127.0.0.1]:59605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPPfr-0002W0-AW for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Dec 2010 20:15:27 -0500 Original-Received: from [140.186.70.92] (port=54676 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPPfm-0002Vp-6n for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 20:15:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPPfk-0008Mb-CC for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 20:15:22 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPPfk-0008MX-9J for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 20:15:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PPPIE-0006AK-7a; Sun, 05 Dec 2010 19:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: MON KEY Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2010 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7518-submit@debbugs.gnu.org id=B7518.129159664823675 (code B ref 7518); Mon, 06 Dec 2010 00:51:02 +0000 Original-Received: (at 7518) by debbugs.gnu.org; 6 Dec 2010 00:50:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPPI0-00069o-8p for submit@debbugs.gnu.org; Sun, 05 Dec 2010 19:50:48 -0500 Original-Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPPHy-00069c-ME for 7518@debbugs.gnu.org; Sun, 05 Dec 2010 19:50:47 -0500 Original-Received: by wyf23 with SMTP id 23so10795978wyf.3 for <7518@debbugs.gnu.org>; Sun, 05 Dec 2010 16:56:37 -0800 (PST) Original-Received: by 10.216.181.76 with SMTP id k54mr1768091wem.58.1291596996856; Sun, 05 Dec 2010 16:56:36 -0800 (PST) Original-Received: by 10.216.70.212 with HTTP; Sun, 5 Dec 2010 16:56:36 -0800 (PST) In-Reply-To: <8762v9jagu.fsf@stupidchicken.com> X-Google-Sender-Auth: iiLzHTA4q9W0wcjoipfPaSrD_Z8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 05 Dec 2010 19:51:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42196 Archived-At: On Sat, Dec 4, 2010 at 8:05 PM, Chong Yidong wrote: > MON KEY writes: >> AFAIK `image-dired' isn't loaded by default. Why should _each_ of >> these variables elevate to creation of a `user-emacs-directory' >> if/when one doesn't already exit? > > This sentence does not parse. > >> Why should _each_ of these variables elevate to creation of a >> `user-emacs-directory' if/when one doesn't already exit? > `image-dired-dir' is the "top-level" defcustom from which other related `image-dired-*' vars derive their path default values. As such, only `image-dired-dir' need evaluate a form containing `locate-user-emacs-file' any other of the paths which "inherit" from `image-dired-dir' will either find an existing directoy already available or will incorrectly create one which may otherwise be separate from a user paths specified the in some other `image-dired-*' var. IOW, "hands of my directory tree image-dired!" Moreover, I would argue that none of the `image-dired-*' vars should be hardwired by default to `user-home-directory' not only is this non-transparently intrusive but it is potentially error prone on w32. Let the user explicitly specify a path for these instead if this is what is wanted. As an aside, none of the `image-dired-*' path customizations have :type specializations more specific than string so at the very least it isn't immediately clear that these vars are creat. > > The usage of locate-user-emacs-file in image-dired is correct, as far as > I can tell. > Maybe not. :) Most other packages don't operate this way to they? -- /s_P\