bug#7480: 24.0.50 no images in Custom

bug#7480: 24.0.50 no images in Custom

[Jonas Bernoulli]

In Custom buffers no images are shown for widgets that support it;
instead the respective text representations are shown.
`widget-image-enable' is t and the required images can be found.

I verified that `widget-image-insert' actually does get called when
appropriate and likewise calls `image-insert' .

Evaluating (insert-image (widget-image-find "right") "text") in the
scratch buffer does insert the image there. Setting
`before-change-functions' nil an evaluating the same expression in
Custom buffers also works.

In Custom buffers (text-properties-at (point)) returns

(rear-nonsticky
 (display)
 display
 (image :type xpm :file
"/usr/share/emacs/24.0.50/etc/images/custom/right.xpm" :ascent
center))

on "Show Value" as will as the manually inserted "right" image. I
don't understand in what way they differ that makes them be shown as
image resp. text.

Thanks

-- Jonas

bug#7480: 24.0.50 no images in Custom

[Chong Yidong]

Jonas Bernoulli <jonas@bernoul.li> writes:

> In Custom buffers no images are shown for widgets that support it;
> instead the respective text representations are shown.
> `widget-image-enable' is t and the required images can be found.
>
> I verified that `widget-image-insert' actually does get called when
> appropriate and likewise calls `image-insert' .

Could you provide a simple step-by-step recipe for reproducing this bug,
starting from `emacs -Q'?  Your description is not precise enough to
figure out where exactly the problem lies.

bug#7480: 24.0.50 no images in Custom

[Jonas Bernoulli]

On Fri, Dec 17, 2010 at 12:06, Chong Yidong <cyd@stupidchicken.com> wrote:
> Could you provide a simple step-by-step recipe for reproducing this bug,
> starting from `emacs -Q'?  Your description is not precise enough to
> figure out where exactly the problem lies.

0. emerge emacs-vcs  #  [1]
1. emacs -Q
2. M-: eval-expression RET widget-image-enable RET
-> t
2. M-x customize-group RET editing RET

[1] install gentoo gnu/linux live package:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/emacs-vcs/emacs-vcs-24.0.9999.ebuild?revision=1.20&view=markup

bug#7480: 24.0.50 no images in Custom

[Jonas Bernoulli]

Meeeh, sorry: this should have read:

0. emerge emacs-vcs  #  [1]
1. emacs -Q
2. M-x customize-group RET editing RET
3. M-: widget-image-enable RET
-> t

[1] gentoo gnu/linux live package:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/emacs-vcs/emacs-vcs-24.0.9999.ebuild?revision=1.20&view=markup

bug#7480: 24.0.50 no images in Custom

[Jonas Bernoulli]

> 0. emerge emacs-vcs  #  [1]

Maybe there is a problem in the package description. I will later
install manually to test.

bug#7480: 24.0.50 no images in Custom

[Chong Yidong]

Jonas Bernoulli <jonas@bernoul.li> writes:

> Meeeh, sorry: this should have read:
>
> 1. emacs -Q
> 2. M-x customize-group RET editing RET
> 3. M-: widget-image-enable RET
> -> t

And?  I am looking at a *Customize Group: Editing* buffer, and nothing
seems to be out of the ordinary.  Please describe what you expected to
see, and what you see instead.

bug#7480: 24.0.50 no images in Custom

[Jonas Bernoulli]

On Mon, Dec 20, 2010 at 15:59, Chong Yidong <cyd@stupidchicken.com> wrote:
> Please describe what you expected to see, and what you see instead.

I expected:

    > Delete Active Region

where ">" is an image.

but got:

    Show Value Delete Active Region

where "Show Value" is text.

bug#7480: 24.0.50 no images in Custom

[Chong Yidong]

Jonas Bernoulli <jonas@bernoul.li> writes:

> On Mon, Dec 20, 2010 at 15:59, Chong Yidong <cyd@stupidchicken.com> wrote:
>> Please describe what you expected to see, and what you see instead.
>
> I expected:
>
>     > Delete Active Region
>
> where ">" is an image.
>
> but got:
>
>     Show Value Delete Active Region
>
> where "Show Value" is text.

I see it now.  Thanks, I've committed a fix.

bug#7480: 24.0.50 no images in Custom

[David De La Harpe Golden]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On 20/12/10 14:59, Chong Yidong wrote:
> Jonas Bernoulli<jonas@bernoul.li>  writes:
>
>> Meeeh, sorry: this should have read:
>>
>> 1. emacs -Q
>> 2. M-x customize-group RET editing RET
>> 3. M-: widget-image-enable RET
>> ->  t
>
> And?  I am looking at a *Customize Group: Editing* buffer, and nothing
> seems to be out of the ordinary.  Please describe what you expected to
> see, and what you see instead.


... Certainly looks a bit strange to me (X11 Emacs, Gtk+, r102694).

"Show Value" is just text with little in the way of affordances 
indicating clickability (though middle click still works on it and the 
pointer changes, it doesn't look like either a button or hyperlink).

While the change may have been a deliberate tidy-up, IMO "Show Value" 
should at least be made visibly a button widget.  Right now, it
just sorta runs into the actual setting.

Older emacs had a small (but obviously clickable) visibility triangle 
button (see attached screenshots) to expand/contract (and of course you 
could also read the value of various simple settings without expanding)












[-- Attachment #2: emacs_7480_23.2_custom.png --]
[-- Type: image/png, Size: 62832 bytes --]

[-- Attachment #3: emacs_7480_trunk_custom.png --]
[-- Type: image/png, Size: 58338 bytes --]

bug#7480: 24.0.50 no images in Custom

[Lennart Borgman]

On Mon, Dec 20, 2010 at 11:46 PM, David De La Harpe Golden
<david@harpegolden.net> wrote:
> On 20/12/10 14:59, Chong Yidong wrote:
>>
>> Jonas Bernoulli<jonas@bernoul.li>  writes:
>>
>>> Meeeh, sorry: this should have read:
>>>
>>> 1. emacs -Q
>>> 2. M-x customize-group RET editing RET
>>> 3. M-: widget-image-enable RET
>>> ->  t
>>
>> And?  I am looking at a *Customize Group: Editing* buffer, and nothing
>> seems to be out of the ordinary.  Please describe what you expected to
>> see, and what you see instead.
>
>
> ... Certainly looks a bit strange to me (X11 Emacs, Gtk+, r102694).
>
> "Show Value" is just text with little in the way of affordances indicating
> clickability (though middle click still works on it and the pointer changes,
> it doesn't look like either a button or hyperlink).
>
> While the change may have been a deliberate tidy-up, IMO "Show Value" should
> at least be made visibly a button widget.  Right now, it
> just sorta runs into the actual setting.
>
> Older emacs had a small (but obviously clickable) visibility triangle button
> (see attached screenshots) to expand/contract (and of course you could also
> read the value of various simple settings without expanding)


I see the same problem as David with a checkout from 2010-12-15, i.e.
"Show Value" does not have the "link" face and the image that was
there before instead of this text is now gone.

Either the text should have the link face or the image should be there instead.