* bug#4940:
@ 2009-12-06 17:21 Deniz Dogan
0 siblings, 0 replies; 3+ messages in thread
From: Deniz Dogan @ 2009-12-06 17:21 UTC (permalink / raw)
To: 4940
Shouldn't rcirc-log-flag be part of the equation here?
(and rcirc-log-flag rcirc-log-directory rcirc-log-alist)
--
Deniz Dogan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4940: Avoiding loss of rcirc messages from the on disk log
[not found] <b6fx8ecfln.fsf@fencepost.gnu.org>
@ 2010-01-18 0:01 ` Chong Yidong
2011-01-22 16:26 ` bug#4940: Deniz Dogan
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2010-01-18 0:01 UTC (permalink / raw)
To: Ryan Yeske; +Cc: 4940
Hi Ryan,
Could you review the patch from Giorgos Keramidas? Thanks.
> The IRC buffers of "rcirc.el" use the auto-save mechanism to push log
> messages on disk. This is a very good idea, since it avoids hitting the
> disk for every single line of the IRC log. On busy channels it probably
> saves a *lot* of time that would be spent waiting for messages to be
> saved on disk.
> Unfortunately, it also means that the simple action of killing an rcirc
> buffer may lose some of the messages. Any messages still on the alist
> `rcirc-log-alist' are still in memory and I've noticed that some of
> these may not be written to the log files in `rcirc-log-directory'.
diff -r e1381fd70a71 lisp/net/rcirc.el
--- a/lisp/net/rcirc.el Fri Apr 03 03:02:01 2009 +0300
+++ b/lisp/net/rcirc.el Sat Oct 31 05:12:55 2009 +0200
<at> <at> -984,6 +984,8 <at> <at> If ALL is non-nil, update prompts in all
(defun rcirc-kill-buffer-hook ()
"Part the channel when killing an rcirc buffer."
(when (eq major-mode 'rcirc-mode)
+ (when (and rcirc-log-directory rcirc-log-alist)
+ (rcirc-log-write))
(rcirc-clean-up-buffer "Killed buffer")))
(defun rcirc-change-major-mode-hook ()
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4940:
[not found] <b6fx8ecfln.fsf@fencepost.gnu.org>
2010-01-18 0:01 ` bug#4940: Avoiding loss of rcirc messages from the on disk log Chong Yidong
@ 2011-01-22 16:26 ` Deniz Dogan
1 sibling, 0 replies; 3+ messages in thread
From: Deniz Dogan @ 2011-01-22 16:26 UTC (permalink / raw)
To: 4940-done
I just pushed this change, only slightly modified, to trunk. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-22 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <b6fx8ecfln.fsf@fencepost.gnu.org>
2010-01-18 0:01 ` bug#4940: Avoiding loss of rcirc messages from the on disk log Chong Yidong
2011-01-22 16:26 ` bug#4940: Deniz Dogan
2009-12-06 17:21 bug#4940: Deniz Dogan
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).