* bug#6459: 24.0.50; completions-format should not have a `nil' choice
@ 2010-06-18 20:17 Drew Adams
2010-06-19 14:37 ` Juri Linkov
0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2010-06-18 20:17 UTC (permalink / raw)
To: 6459
This is the definition:
(defcustom completions-format nil
"Define the appearance and sorting of completions.
If the value is `vertical', display completions sorted vertically
in columns in the *Completions* buffer.
If the value is `horizontal' or nil, display completions sorted
horizontally in alphabetical order, rather than down the screen."
:type '(choice (const nil) (const horizontal) (const vertical))
:group 'minibuffer
:version "23.2")
There is no reason for the `nil' choice. Please remove it and make the
default value `horizontal'. Occam's razor (KISS) and clarity for users
argue for this.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-06-14 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6459: 24.0.50; completions-format should not have a `nil' choice
2010-06-18 20:17 bug#6459: 24.0.50; completions-format should not have a `nil' choice Drew Adams
@ 2010-06-19 14:37 ` Juri Linkov
2010-06-19 15:04 ` Lennart Borgman
0 siblings, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2010-06-19 14:37 UTC (permalink / raw)
To: Drew Adams; +Cc: 6459
> (defcustom completions-format nil
> "Define the appearance and sorting of completions.
> If the value is `vertical', display completions sorted vertically
> in columns in the *Completions* buffer.
> If the value is `horizontal' or nil, display completions sorted
> horizontally in alphabetical order, rather than down the screen."
> :type '(choice (const nil) (const horizontal) (const vertical))
> :group 'minibuffer
> :version "23.2")
>
> There is no reason for the `nil' choice. Please remove it and make the
> default value `horizontal'. Occam's razor (KISS) and clarity for users
> argue for this.
We could remove nil from the docstring and from :type, and change
the default value to `horizontal', but I'd still treat nil as
`horizontal' internally for compatibility.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6459: 24.0.50; completions-format should not have a `nil' choice
2010-06-19 14:37 ` Juri Linkov
@ 2010-06-19 15:04 ` Lennart Borgman
2010-06-20 14:50 ` Drew Adams
0 siblings, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2010-06-19 15:04 UTC (permalink / raw)
To: Juri Linkov; +Cc: 6459
On Sat, Jun 19, 2010 at 4:37 PM, Juri Linkov <juri@jurta.org> wrote:
>> (defcustom completions-format nil
>> "Define the appearance and sorting of completions.
>> If the value is `vertical', display completions sorted vertically
>> in columns in the *Completions* buffer.
>> If the value is `horizontal' or nil, display completions sorted
>> horizontally in alphabetical order, rather than down the screen."
>> :type '(choice (const nil) (const horizontal) (const vertical))
>> :group 'minibuffer
>> :version "23.2")
>>
>> There is no reason for the `nil' choice. Please remove it and make the
>> default value `horizontal'. Occam's razor (KISS) and clarity for users
>> argue for this.
>
> We could remove nil from the docstring and from :type, and change
> the default value to `horizontal', but I'd still treat nil as
> `horizontal' internally for compatibility.
Since this is a new defcustom woulddn't it be better to not let nil be
a valid value? That may catch some problems and the backward
compatibilities are not likely to be big.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6459: 24.0.50; completions-format should not have a `nil' choice
2010-06-19 15:04 ` Lennart Borgman
@ 2010-06-20 14:50 ` Drew Adams
2010-06-24 21:54 ` Juri Linkov
0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2010-06-20 14:50 UTC (permalink / raw)
To: 'Lennart Borgman', 'Juri Linkov'; +Cc: 6459
> >> (defcustom completions-format nil
> >> "Define the appearance and sorting of completions.
> >> If the value is `vertical', display completions sorted vertically
> >> in columns in the *Completions* buffer.
> >> If the value is `horizontal' or nil, display completions sorted
> >> horizontally in alphabetical order, rather than down the screen."
> >> :type '(choice (const nil) (const horizontal) (const vertical))
> >> :group 'minibuffer
> >> :version "23.2")
> >>
> >> There is no reason for the `nil' choice. Please remove it
> >> and make the default value `horizontal'. Occam's razor
> >> (KISS) and clarity for users argue for this.
> >
> > We could remove nil from the docstring and from :type, and change
> > the default value to `horizontal', but I'd still treat nil as
> > `horizontal' internally for compatibility.
I don't have a big problem with that. But what "compatibility" is gained?
Compatibility of what with what? This is a new variable.
> Since this is a new defcustom woulddn't it be better to not let nil be
> a valid value? That may catch some problems and the backward
> compatibilities are not likely to be big.
I agree with Lennart here. KISS. I see no reason for nil. I am unaware of any
backward compatibility issue for this variable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6459: 24.0.50; completions-format should not have a `nil' choice
2010-06-20 14:50 ` Drew Adams
@ 2010-06-24 21:54 ` Juri Linkov
[not found] ` <8BEE1EFC8295492FA9737701B9F633FA@us.oracle.com>
0 siblings, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2010-06-24 21:54 UTC (permalink / raw)
To: Drew Adams; +Cc: 6459-done
>> >> There is no reason for the `nil' choice. Please remove it
>> >> and make the default value `horizontal'. Occam's razor
>> >> (KISS) and clarity for users argue for this.
>> >
>> > We could remove nil from the docstring and from :type, and change
>> > the default value to `horizontal', but I'd still treat nil as
>> > `horizontal' internally for compatibility.
This is changed now.
> I don't have a big problem with that. But what "compatibility" is gained?
> Compatibility of what with what? This is a new variable.
>
>> Since this is a new defcustom woulddn't it be better to not let nil be
>> a valid value? That may catch some problems and the backward
>> compatibilities are not likely to be big.
>
> I agree with Lennart here. KISS. I see no reason for nil. I am unaware of any
> backward compatibility issue for this variable.
I don't want to completely break the *Completions* buffer with
an unadvertized value. So currently I left `horizontal' as a
catch-all case in the implementation.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-06-25 21:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-18 20:17 bug#6459: 24.0.50; completions-format should not have a `nil' choice Drew Adams
2010-06-19 14:37 ` Juri Linkov
2010-06-19 15:04 ` Lennart Borgman
2010-06-20 14:50 ` Drew Adams
2010-06-24 21:54 ` Juri Linkov
[not found] ` <8BEE1EFC8295492FA9737701B9F633FA@us.oracle.com>
[not found] ` <87hbksf3xh.fsf@mail.jurta.org>
2010-06-25 21:09 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).