unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7480: 24.0.50 no images in Custom
@ 2010-11-25 14:35 Jonas Bernoulli
  2010-12-17 11:06 ` Chong Yidong
  0 siblings, 1 reply; 10+ messages in thread
From: Jonas Bernoulli @ 2010-11-25 14:35 UTC (permalink / raw)
  To: 7480

In Custom buffers no images are shown for widgets that support it;
instead the respective text representations are shown.
`widget-image-enable' is t and the required images can be found.

I verified that `widget-image-insert' actually does get called when
appropriate and likewise calls `image-insert' .

Evaluating (insert-image (widget-image-find "right") "text") in the
scratch buffer does insert the image there. Setting
`before-change-functions' nil an evaluating the same expression in
Custom buffers also works.

In Custom buffers (text-properties-at (point)) returns

(rear-nonsticky
 (display)
 display
 (image :type xpm :file
"/usr/share/emacs/24.0.50/etc/images/custom/right.xpm" :ascent
center))

on "Show Value" as will as the manually inserted "right" image. I
don't understand in what way they differ that makes them be shown as
image resp. text.

Thanks

-- Jonas





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-11-25 14:35 bug#7480: 24.0.50 no images in Custom Jonas Bernoulli
@ 2010-12-17 11:06 ` Chong Yidong
  2010-12-17 13:24   ` Jonas Bernoulli
  0 siblings, 1 reply; 10+ messages in thread
From: Chong Yidong @ 2010-12-17 11:06 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: 7480

Jonas Bernoulli <jonas@bernoul.li> writes:

> In Custom buffers no images are shown for widgets that support it;
> instead the respective text representations are shown.
> `widget-image-enable' is t and the required images can be found.
>
> I verified that `widget-image-insert' actually does get called when
> appropriate and likewise calls `image-insert' .

Could you provide a simple step-by-step recipe for reproducing this bug,
starting from `emacs -Q'?  Your description is not precise enough to
figure out where exactly the problem lies.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-17 11:06 ` Chong Yidong
@ 2010-12-17 13:24   ` Jonas Bernoulli
  2010-12-17 13:29     ` Jonas Bernoulli
  0 siblings, 1 reply; 10+ messages in thread
From: Jonas Bernoulli @ 2010-12-17 13:24 UTC (permalink / raw)
  To: 7480

On Fri, Dec 17, 2010 at 12:06, Chong Yidong <cyd@stupidchicken.com> wrote:
> Could you provide a simple step-by-step recipe for reproducing this bug,
> starting from `emacs -Q'?  Your description is not precise enough to
> figure out where exactly the problem lies.

0. emerge emacs-vcs  #  [1]
1. emacs -Q
2. M-: eval-expression RET widget-image-enable RET
-> t
2. M-x customize-group RET editing RET

[1] install gentoo gnu/linux live package:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/emacs-vcs/emacs-vcs-24.0.9999.ebuild?revision=1.20&view=markup





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-17 13:24   ` Jonas Bernoulli
@ 2010-12-17 13:29     ` Jonas Bernoulli
  2010-12-17 13:41       ` Jonas Bernoulli
  2010-12-20 14:59       ` Chong Yidong
  0 siblings, 2 replies; 10+ messages in thread
From: Jonas Bernoulli @ 2010-12-17 13:29 UTC (permalink / raw)
  To: 7480

Meeeh, sorry: this should have read:

0. emerge emacs-vcs  #  [1]
1. emacs -Q
2. M-x customize-group RET editing RET
3. M-: widget-image-enable RET
-> t

[1] gentoo gnu/linux live package:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/emacs-vcs/emacs-vcs-24.0.9999.ebuild?revision=1.20&view=markup





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-17 13:29     ` Jonas Bernoulli
@ 2010-12-17 13:41       ` Jonas Bernoulli
  2010-12-20 14:59       ` Chong Yidong
  1 sibling, 0 replies; 10+ messages in thread
From: Jonas Bernoulli @ 2010-12-17 13:41 UTC (permalink / raw)
  To: 7480

> 0. emerge emacs-vcs  #  [1]

Maybe there is a problem in the package description. I will later
install manually to test.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-17 13:29     ` Jonas Bernoulli
  2010-12-17 13:41       ` Jonas Bernoulli
@ 2010-12-20 14:59       ` Chong Yidong
  2010-12-20 15:21         ` Jonas Bernoulli
  2010-12-20 22:46         ` David De La Harpe Golden
  1 sibling, 2 replies; 10+ messages in thread
From: Chong Yidong @ 2010-12-20 14:59 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: 7480

Jonas Bernoulli <jonas@bernoul.li> writes:

> Meeeh, sorry: this should have read:
>
> 1. emacs -Q
> 2. M-x customize-group RET editing RET
> 3. M-: widget-image-enable RET
> -> t

And?  I am looking at a *Customize Group: Editing* buffer, and nothing
seems to be out of the ordinary.  Please describe what you expected to
see, and what you see instead.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-20 14:59       ` Chong Yidong
@ 2010-12-20 15:21         ` Jonas Bernoulli
  2010-12-21  2:36           ` Chong Yidong
  2010-12-20 22:46         ` David De La Harpe Golden
  1 sibling, 1 reply; 10+ messages in thread
From: Jonas Bernoulli @ 2010-12-20 15:21 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 7480

On Mon, Dec 20, 2010 at 15:59, Chong Yidong <cyd@stupidchicken.com> wrote:
> Please describe what you expected to see, and what you see instead.

I expected:

    > Delete Active Region

where ">" is an image.

but got:

    Show Value Delete Active Region

where "Show Value" is text.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-20 14:59       ` Chong Yidong
  2010-12-20 15:21         ` Jonas Bernoulli
@ 2010-12-20 22:46         ` David De La Harpe Golden
  2010-12-20 23:49           ` Lennart Borgman
  1 sibling, 1 reply; 10+ messages in thread
From: David De La Harpe Golden @ 2010-12-20 22:46 UTC (permalink / raw)
  To: Chong Yidong; +Cc: Jonas Bernoulli, 7480

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On 20/12/10 14:59, Chong Yidong wrote:
> Jonas Bernoulli<jonas@bernoul.li>  writes:
>
>> Meeeh, sorry: this should have read:
>>
>> 1. emacs -Q
>> 2. M-x customize-group RET editing RET
>> 3. M-: widget-image-enable RET
>> ->  t
>
> And?  I am looking at a *Customize Group: Editing* buffer, and nothing
> seems to be out of the ordinary.  Please describe what you expected to
> see, and what you see instead.


... Certainly looks a bit strange to me (X11 Emacs, Gtk+, r102694).

"Show Value" is just text with little in the way of affordances 
indicating clickability (though middle click still works on it and the 
pointer changes, it doesn't look like either a button or hyperlink).

While the change may have been a deliberate tidy-up, IMO "Show Value" 
should at least be made visibly a button widget.  Right now, it
just sorta runs into the actual setting.

Older emacs had a small (but obviously clickable) visibility triangle 
button (see attached screenshots) to expand/contract (and of course you 
could also read the value of various simple settings without expanding)












[-- Attachment #2: emacs_7480_23.2_custom.png --]
[-- Type: image/png, Size: 62832 bytes --]

[-- Attachment #3: emacs_7480_trunk_custom.png --]
[-- Type: image/png, Size: 58338 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-20 22:46         ` David De La Harpe Golden
@ 2010-12-20 23:49           ` Lennart Borgman
  0 siblings, 0 replies; 10+ messages in thread
From: Lennart Borgman @ 2010-12-20 23:49 UTC (permalink / raw)
  To: David De La Harpe Golden; +Cc: Chong Yidong, Jonas Bernoulli, 7480

On Mon, Dec 20, 2010 at 11:46 PM, David De La Harpe Golden
<david@harpegolden.net> wrote:
> On 20/12/10 14:59, Chong Yidong wrote:
>>
>> Jonas Bernoulli<jonas@bernoul.li>  writes:
>>
>>> Meeeh, sorry: this should have read:
>>>
>>> 1. emacs -Q
>>> 2. M-x customize-group RET editing RET
>>> 3. M-: widget-image-enable RET
>>> ->  t
>>
>> And?  I am looking at a *Customize Group: Editing* buffer, and nothing
>> seems to be out of the ordinary.  Please describe what you expected to
>> see, and what you see instead.
>
>
> ... Certainly looks a bit strange to me (X11 Emacs, Gtk+, r102694).
>
> "Show Value" is just text with little in the way of affordances indicating
> clickability (though middle click still works on it and the pointer changes,
> it doesn't look like either a button or hyperlink).
>
> While the change may have been a deliberate tidy-up, IMO "Show Value" should
> at least be made visibly a button widget.  Right now, it
> just sorta runs into the actual setting.
>
> Older emacs had a small (but obviously clickable) visibility triangle button
> (see attached screenshots) to expand/contract (and of course you could also
> read the value of various simple settings without expanding)


I see the same problem as David with a checkout from 2010-12-15, i.e.
"Show Value" does not have the "link" face and the image that was
there before instead of this text is now gone.

Either the text should have the link face or the image should be there instead.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#7480: 24.0.50 no images in Custom
  2010-12-20 15:21         ` Jonas Bernoulli
@ 2010-12-21  2:36           ` Chong Yidong
  0 siblings, 0 replies; 10+ messages in thread
From: Chong Yidong @ 2010-12-21  2:36 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: 7480

Jonas Bernoulli <jonas@bernoul.li> writes:

> On Mon, Dec 20, 2010 at 15:59, Chong Yidong <cyd@stupidchicken.com> wrote:
>> Please describe what you expected to see, and what you see instead.
>
> I expected:
>
>     > Delete Active Region
>
> where ">" is an image.
>
> but got:
>
>     Show Value Delete Active Region
>
> where "Show Value" is text.

I see it now.  Thanks, I've committed a fix.





^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2010-12-21  2:36 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-25 14:35 bug#7480: 24.0.50 no images in Custom Jonas Bernoulli
2010-12-17 11:06 ` Chong Yidong
2010-12-17 13:24   ` Jonas Bernoulli
2010-12-17 13:29     ` Jonas Bernoulli
2010-12-17 13:41       ` Jonas Bernoulli
2010-12-20 14:59       ` Chong Yidong
2010-12-20 15:21         ` Jonas Bernoulli
2010-12-21  2:36           ` Chong Yidong
2010-12-20 22:46         ` David De La Harpe Golden
2010-12-20 23:49           ` Lennart Borgman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).