unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tim Van Holder <tim.vanholder@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, 7905@debbugs.gnu.org
Subject: bug#7905: 24.0.50; VC not updating file status properly anymore after commit from vc-dir
Date: Wed, 2 Feb 2011 12:40:39 +0100	[thread overview]
Message-ID: <AANLkTimEyhBoDSDGTGt45CnYj4aVV4jLGAp9umMANXcm@mail.gmail.com> (raw)
In-Reply-To: <6sjw7tony.fsf@fencepost.gnu.org>

On 1 February 2011 22:45, Glenn Morris <rgm@gnu.org> wrote:
> Tim Van Holder wrote:
>
>>>>   (encode-time 16 18 15 11 1 2011 2 nil 3600)
>>>>   (encode-time 16 18 15 11 1 2011 2 nil 0)
>>>> both return the same value "(19756 26280)"
> [...]
>> In order to do the (apparent) right thing, encode-time seems to rely
>> on mktime() to take $TZ into account (otherwise there is no point in
>> saving/restoring the environment with a specific TZ value).
>> However, lib/mktime.c (which is in use by my emacs build) does not
>> seem to refer to any timezone info at all - neither $TZ nor tm_zone is
>> referenced; it seems to rely on localtime() to deal with that. I guess
>> that's not the case for my localtime() (from glibc 2.3.6).
>
> FWIW I built the current trunk on a system with glibc 2.3.4, and the
> two above encode-times return two different values. So whatever it is,
> it's not related to the glibc version.

I ran some separate tests and glibc's mktime and localtime seem to
properly take time zone info into account, regardless of whether it
came from $TZ, setenv("TZ", ...) or set_time_zone_rule() as copied
from editfns.c. So things _should_ be working fine in encode-time.
So it looks like it's an interaction inside emacs breaking things.
Whatever it is, it seems to be triggered by display-time-mode. Before
that is run, everything works fine. After running it, all
CVS-controlled files are edited as far as VC knows. After running it
again (disabling the actual display-time-mode display), things do NOT
return to normal. But I don't immediately see anything in time.el that
would suggest a problem.
It's particularly annoying that noone seems to be able to reproduce
it... I give up - I'll just disable display-time-mode.





      reply	other threads:[~2011-02-02 11:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 10:48 bug#7905: 24.0.50; VC not updating file status properly anymore after commit from vc-dir Tim Van Holder
2011-01-25  0:48 ` Glenn Morris
2011-01-25  8:00   ` Tim Van Holder
2011-01-25  9:44     ` Tim Van Holder
2011-01-25 11:30       ` Tim Van Holder
2011-01-26  4:25         ` Glenn Morris
2011-01-26  9:44           ` Tim Van Holder
2011-01-26 10:07             ` Tim Van Holder
2011-01-27  7:25               ` Glenn Morris
2011-01-27  9:51                 ` Tim Van Holder
2011-01-28 18:16                   ` Glenn Morris
2011-01-31  9:06                     ` Tim Van Holder
2011-01-31 10:31                       ` Andreas Schwab
2011-01-31 13:59                         ` Tim Van Holder
2011-01-31 14:10                           ` Andreas Schwab
2011-02-01 10:18                             ` Tim Van Holder
2011-02-01 21:45                               ` Glenn Morris
2011-02-02 11:40                                 ` Tim Van Holder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimEyhBoDSDGTGt45CnYj4aVV4jLGAp9umMANXcm@mail.gmail.com \
    --to=tim.vanholder@gmail.com \
    --cc=7905@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).