From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6602: [PATCH] make dist target for Windows Date: Sat, 24 Jul 2010 15:28:41 +0200 Message-ID: References: <4C387CF9.4070301@gmail.com> <4C48ED04.2090407@gmail.com> <4C4A5B6A.9080700@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279978666 9645 80.91.229.12 (24 Jul 2010 13:37:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Jul 2010 13:37:46 +0000 (UTC) Cc: 6602-done@debbugs.gnu.org To: Christoph Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 24 15:37:42 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocev5-0004rU-4u for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 15:37:39 +0200 Original-Received: from localhost ([127.0.0.1]:45207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ocev4-0000dE-K1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 09:37:38 -0400 Original-Received: from [140.186.70.92] (port=48983 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oceux-0000cB-8A for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 09:37:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oceuw-00030g-2F for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 09:37:31 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56796) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oceuv-00030V-TJ for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 09:37:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Ocenj-0006Kb-7d for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 09:30:03 -0400 Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2010 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 6602 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 6602@debbugs.gnu.org, lekktu@gmail.com Original-Received: via spool by 6602-done@debbugs.gnu.org id=D6602.127997814224312 (code D ref 6602); Sat, 24 Jul 2010 13:30:02 +0000 Original-Received: (at 6602-done) by debbugs.gnu.org; 24 Jul 2010 13:29:02 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocemk-0006K5-MD for submit@debbugs.gnu.org; Sat, 24 Jul 2010 09:29:02 -0400 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocemj-0006Jj-Lc for 6602-done@debbugs.gnu.org; Sat, 24 Jul 2010 09:29:02 -0400 Original-Received: by bwz7 with SMTP id 7so2287776bwz.3 for <6602-done@debbugs.gnu.org>; Sat, 24 Jul 2010 06:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=bjsgr+N7CQ9r+vuiQDcKB0rybYQN41wP696PTlsxy6s=; b=Lf+krnT2xQPvUdSoq42H/VYCThKzanHCsC1qBxNfuBOVSCZXiMdpUrCIGqKhULY8iu NDvNdRjQzMmtijZ5sfho9FlHIYXHpTa77dxBEnUt8btS6R0ggU3f5/7m3cv6scONv6vF 7yHuYTLHPPC2tsuLFwcQq8cNl58SR1QR7a1Ec= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=BE6IyG0zcDCE6RU+stLlkFsy7ItZzOJszLxRVB/AdWs3UHAjjn9r6yoIV1TpCoBIyN ySo+cs+rbW+rnPPAHTmV50ISTNCN801+aHPxErfs/4hzCN+JKaTMK/cAkMeNgcuh02SD btQjrNWrBgNTTCBVVHUdqMfVS0TnQxBKdQtv8= Original-Received: by 10.204.127.75 with SMTP id f11mr3729665bks.85.1279978141203; Sat, 24 Jul 2010 06:29:01 -0700 (PDT) Original-Received: by 10.204.180.136 with HTTP; Sat, 24 Jul 2010 06:28:41 -0700 (PDT) In-Reply-To: <4C4A5B6A.9080700@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Jul 2010 09:30:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38867 Archived-At: On Sat, Jul 24, 2010 at 05:18, Christoph wrote: > Find attached the new patch for the `make dist' target. > > I added a Changelog and NEWS entry and removed README.W32 and makedist.ba= t > files from the nt/ directory. OK, thaks a lot. A few comments (nitpicks, mostly): - You've added the ChangeLog entry to the root directory's ChangeLog, instead of nt/ChangeLog. Also, it lacks an entry in admin/ChangeLog about the changes in that directory (you've documented most of them in the other ChangeLog, though). In some cases, as when moving files, it is customary to put a "Moved to X/" entry in the old directory's ChangeLog, and ad "Moved from Y/" in the new's. - Changes to documentation files, like etc/NEWS and nt/INSTALL, must also be documented in ChangeLog entries. - If you're going to move a file, like README.W32, instead of cd admin/nt copy README.W32 ../../nt del README.W32 or move admin/nt/README.W32 nt/ please do bzr mv admin/nt/README.W32 nt/ so Bazaar knows that it is the same file. - It's best if you do these changes in a branch, and then submit a bundle. For example, applying your patch creates a file nt/zipdist.bat, but it has to be "bzr add"ed manually. - Try not to introduce trailing whitespace in files you modify. Not earth-shaking, but ugly if you have `show-trailing-whitespace' set to t (which I recommend). That said, I'm committing your change right now. Great work. Thanks! =C2=A0 =C2=A0 Juanma