From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Date: Tue, 28 Sep 2010 01:35:12 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1285630900 7081 80.91.229.12 (27 Sep 2010 23:41:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Sep 2010 23:41:40 +0000 (UTC) Cc: 7118@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 28 01:41:37 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NK6-0005fV-6N for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Sep 2010 01:41:30 +0200 Original-Received: from localhost ([127.0.0.1]:49105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0NK5-0002j0-FW for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Sep 2010 19:41:29 -0400 Original-Received: from [140.186.70.92] (port=40095 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0NJy-0002hh-4f for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 19:41:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0NJu-0001N7-5W for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 19:41:22 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32902) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NJu-0001N0-06 for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 19:41:18 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0NCs-0002Z3-7J; Mon, 27 Sep 2010 19:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Sep 2010 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7118-submit@debbugs.gnu.org id=B7118.12856303899846 (code B ref 7118); Mon, 27 Sep 2010 23:34:02 +0000 Original-Received: (at 7118) by debbugs.gnu.org; 27 Sep 2010 23:33:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NC0-0002Yl-GV for submit@debbugs.gnu.org; Mon, 27 Sep 2010 19:33:08 -0400 Original-Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NBy-0002YO-H3 for 7118@debbugs.gnu.org; Mon, 27 Sep 2010 19:33:07 -0400 Original-Received: by iwn3 with SMTP id 3so5108098iwn.3 for <7118@debbugs.gnu.org>; Mon, 27 Sep 2010 16:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=+PL+cdvs6tj8GV4uF/aa6uvoIyBGiKX1Z446hODR3tA=; b=ChsjwBVFtSrqpbAiREW7n7ObJ7blEGgXKoN6irNRFl1yL0KPLidnwWcAcmQ6T/hfnl wymij0PobdtpmmpNcSvFz98UvuQYrC2OBC1mA1Ptjx46uWAimRYvQOojsm+UUpbMruvP Rox0xaZaXeKAciE5RFpiwLf915AQwLkc4UgeA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=qjyCHD78wHHPtnb3hCfMsLPwnaoCfqISgDdHqRXncnupT/pCTcFMew9pBoZBCie9W/ LAC3MEskRyYz9qjVpI8/nG9Ok/0KdSBEt172U/DYfBDZsJJu9aT3oaWu2WJYD75itIYx FWXxi1RhMmUQYEw1KeTPtasvsfXDdtJLkT/mk= Original-Received: by 10.231.144.74 with SMTP id y10mr9874101ibu.65.1285630552271; Mon, 27 Sep 2010 16:35:52 -0700 (PDT) Original-Received: by 10.231.196.71 with HTTP; Mon, 27 Sep 2010 16:35:12 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 27 Sep 2010 19:34:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40503 Archived-At: On Mon, Sep 27, 2010 at 20:47, Drew Adams wrote: > We should use `make-variable-buffer-local' with vars such as > `dired-subdir-alist' and `dired-directory', instead of just calling > `make-local-variable'. =C2=A0Why? =C2=A0Because these vars MUST be buffer= local, > and we might as well make the code clearer by pointing that out. =C2=A0Th= at > is precisely the use case for `make-variable-buffer-local': a var that > is necessarily buffer-local. On the same vein, every single use of revert-buffer-function starts with (make-local-variable 'revert-buffer-function) (setq revert-buffer-function XXXXX) or (set (make-local-variable 'revert-buffer-function) XXXXXX) except the one in dired-x.el, which relies in dired-mode doing it before. There have been at least three bugs in the past year caused by revert-buffer-function not being automatically buffer-local. =C2=A0 =C2=A0 Juanma