From: Lennart Borgman <lennart.borgman@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: 7567@debbugs.gnu.org
Subject: bug#7567: Please add a history variable to read-regexp
Date: Wed, 8 Dec 2010 03:19:47 +0100 [thread overview]
Message-ID: <AANLkTim87oaOgCrq2L6-Vna9LKFxMeC+YZNJg5R-9aBW@mail.gmail.com> (raw)
In-Reply-To: <871v5tqb60.fsf@mail.jurta.org>
On Wed, Dec 8, 2010 at 2:57 AM, Juri Linkov <juri@jurta.org> wrote:
>> So after reading the rest of the thread, I think I finally understand
>> that you want to "add a history *argument* to read-regexp", right?
>> Then it sounds perfectly acceptable.
>
> For consistency, `read-regexp' could have the same function signature
> as other minibuffer reading functions, e.g. like `read-string':
>
> (read-string PROMPT &optional INITIAL-INPUT HISTORY DEFAULT-VALUE INHERIT-INPUT-METHOD)
>
> (read-regexp PROMPT &optional INITIAL-INPUT HISTORY DEFAULT-VALUE INHERIT-INPUT-METHOD)
I agree.
In addition to that when we have that in place then a number of places
in the code should be updated to use it instead of read-string. (And
some new history vars for it should be added.)
next prev parent reply other threads:[~2010-12-08 2:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 2:24 bug#7567: Please add a history variable to read-regexp Lennart Borgman
2010-12-06 22:43 ` Lennart Borgman
2010-12-06 22:57 ` Drew Adams
2010-12-06 23:00 ` Lennart Borgman
2010-12-06 23:11 ` Drew Adams
2010-12-06 23:23 ` Lennart Borgman
2010-12-07 0:31 ` Drew Adams
2010-12-07 4:09 ` Drew Adams
2010-12-08 1:51 ` Juri Linkov
2010-12-08 3:03 ` Drew Adams
2010-12-06 23:03 ` Juri Linkov
2010-12-06 23:46 ` Lennart Borgman
2010-12-08 1:44 ` Juri Linkov
2010-12-07 3:48 ` Stefan Monnier
2010-12-08 1:57 ` Juri Linkov
2010-12-08 2:19 ` Lennart Borgman [this message]
2010-12-09 1:25 ` Juri Linkov
2010-12-08 3:10 ` Drew Adams
2010-12-09 14:31 ` Stefan Monnier
2010-12-09 16:14 ` Drew Adams
2010-12-10 3:09 ` Stefan Monnier
2010-12-09 14:28 ` Stefan Monnier
2010-12-09 17:43 ` Drew Adams
2010-12-10 3:06 ` Stefan Monnier
2010-12-10 3:46 ` Drew Adams
2010-12-10 20:10 ` Stefan Monnier
2010-12-08 3:32 ` Lennart Borgman
2012-09-20 8:30 ` bug#7567: Please add a history argument " Juri Linkov
2012-09-20 21:59 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim87oaOgCrq2L6-Vna9LKFxMeC+YZNJg5R-9aBW@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=7567@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).