unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: 7534@debbugs.gnu.org
Subject: bug#7534: 24.0.50; G-g within Isearch regexp mode
Date: Fri, 3 Dec 2010 08:57:23 +0100	[thread overview]
Message-ID: <AANLkTim63sFU4_grzuikRTpwJyW4tTPHX=oN4V-VCWTF@mail.gmail.com> (raw)
In-Reply-To: <878w0724dn.fsf@mail.jurta.org>

On Thu, Dec 2, 2010 at 23:31, Juri Linkov <juri@jurta.org> wrote:
[...]
>
> IMO, this is consistent behavior.  As the message says after typing `['
> it's incomplete input, so C-g behaves exactly like if there is no input
> for `[' (and an unfinished sequence of characters that follows it).
>
> So the main principle here is that "incomplete input" means "no input"
> for Isearch, and given this rule all your examples work as expected, i.e.
>
> "C-M-s is[ C-g" works like "C-M-s is C-g"
> "C-M-s iss[ C-g" works like "C-M-s iss C-g"
> "C-M-s is[blablabla C-g" works like "C-M-s is C-g"
>

Thanks for thinking on this, Juri.

Indeed, the current behaviour seems to be like you mentioned
("incomplete input" means "no input"), but IMO that doesn't fit well
user's needs. If the user is searching for "is[blablabla", and
suddenly changes his(her) mind, I think C-g should allow to get rid of
the unmatched part.

So, IMO, the main principle for C-g (within Isearch mode) should be:
* if there is unmatched and/or incomplete input --> Delete it.
* Otherwise --> Exit Isearch mode.

-- 
Dani Moncayo





  reply	other threads:[~2010-12-03  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 19:47 bug#7534: 24.0.50; G-g within Isearch regexp mode Dani Moncayo
2010-12-02 22:31 ` Juri Linkov
2010-12-03  7:57   ` Dani Moncayo [this message]
2010-12-05 23:11     ` Juri Linkov
2010-12-06 10:41       ` Dani Moncayo
2010-12-25  2:47         ` Juri Linkov
2011-01-04 11:42           ` Dani Moncayo
2011-01-15  9:57 ` bug#7534: C-g in " Dani Moncayo
2011-01-15 15:51   ` Stefan Monnier
2011-01-16  1:06     ` Juri Linkov
2011-02-04  7:54 ` bug#7534: what about committing the patch also to emacs-23? Dani Moncayo
2011-02-04 14:40   ` Stefan Monnier
2011-02-04 15:39     ` Dani Moncayo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTim63sFU4_grzuikRTpwJyW4tTPHX=oN4V-VCWTF@mail.gmail.com' \
    --to=dmoncayo@gmail.com \
    --cc=7534@debbugs.gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).