From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6385: A slightly less aggressive fit-window-to-buffer Date: Sat, 12 Jun 2010 16:24:25 +0200 Message-ID: References: <4C12383E.5030405@gmx.at> <4C133EBB.5090702@gmx.at> <4C1396B9.6080705@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276353715 10515 80.91.229.12 (12 Jun 2010 14:41:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Jun 2010 14:41:55 +0000 (UTC) Cc: 6385@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 12 16:41:52 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ONRu9-0008Mj-1h for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jun 2010 16:41:51 +0200 Original-Received: from localhost ([127.0.0.1]:46407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONRjj-0005W5-3S for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jun 2010 10:31:03 -0400 Original-Received: from [140.186.70.92] (port=38972 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONRhk-00058M-0I for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 10:29:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONRh8-0003Wb-J1 for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 10:28:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41596) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONRh8-0003WX-Hh for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 10:28:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ONRdu-00021S-6V; Sat, 12 Jun 2010 10:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jun 2010 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6385-submit@debbugs.gnu.org id=B6385.12763526947767 (code B ref 6385); Sat, 12 Jun 2010 14:25:02 +0000 Original-Received: (at 6385) by debbugs.gnu.org; 12 Jun 2010 14:24:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONRdk-00021E-FI for submit@debbugs.gnu.org; Sat, 12 Jun 2010 10:24:54 -0400 Original-Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONRdi-000217-SE for 6385@debbugs.gnu.org; Sat, 12 Jun 2010 10:24:51 -0400 Original-Received: by gwj16 with SMTP id 16so1557313gwj.3 for <6385@debbugs.gnu.org>; Sat, 12 Jun 2010 07:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=/EehAMe6NDGFXg07zwQNJYBbOp69sGYDe3wb9zFe+hs=; b=g8urKFVgMzUGuK32QMrGiAWPhK2tDXroKi8FZW8mFTDX3vTtblhxfq+e6IgmsGw2am EUO9KnnLoGBanyk8HT+6x+tjis5Vhysu6BPPgqFOI2l95m99vHrqPMnC6PRoEaXkejPa zYwVUmLIEJNPsfYfiP6uLFxjNEjUxHj/rp1rg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=RuKwN9v2F2VfFkeb2AxC3b0UhLo9Ks9hDUGGzLw5xkceWjs2o68uqB2WPiW41JQ92N tvCR1T69tpklDy1KMm9fYRDZjyRXIeK/IrgG9INxfnoOOhKT/LJ/2nHdpRz75Wshgak5 CnR0fqcoFRGWziLqQLY91KV6lJt+GQdzbeCMQ= Original-Received: by 10.101.191.4 with SMTP id t4mr2909086anp.214.1276352685599; Sat, 12 Jun 2010 07:24:45 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Sat, 12 Jun 2010 07:24:25 -0700 (PDT) In-Reply-To: <4C1396B9.6080705@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 12 Jun 2010 10:25:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37726 Archived-At: On Sat, Jun 12, 2010 at 4:16 PM, martin rudalics wrote: >>> Deleting other windows when resizing was a misguided feature. =C2=A0I d= on't >>> do that any more for quite some time and didn't miss it yet ;-) >> >> Did you rewrite fit-window-to-buffer or do you have another function for >> this? > > I wrote my own windows resizing functions mostly in Elisp. > >> Yes, but what it handled was that it prevented a window to grow over >> the buffers size. > > If your concern is that enlarging the window of a temporary buffer can > delete other windows then doing what you propose would handle just a few > cases. > >> But I do not know why the window grow bigger than the buffer. > > The while loop at the end of `fit-window-to-buffer' is not sane. =C2=A0He= re I > still have it wrapped in a `condition-case' because in some pathological > cases it can throw an error. Can't we just throw in a better code instead of fit-window-to-buffer? (And rename fit-window-to-buffer to killing-window-fit-to-buffer if someone really wants it.) It does not have to be perfect. Just good enough. We can surely make it better later if we need to.