unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 6385@debbugs.gnu.org
Subject: bug#6385: A slightly less aggressive fit-window-to-buffer
Date: Sat, 12 Jun 2010 16:24:25 +0200	[thread overview]
Message-ID: <AANLkTilMydlLQ0BwDMstY861rGEQhfQUX6irSBL0DpQt@mail.gmail.com> (raw)
In-Reply-To: <4C1396B9.6080705@gmx.at>

On Sat, Jun 12, 2010 at 4:16 PM, martin rudalics <rudalics@gmx.at> wrote:
>>> Deleting other windows when resizing was a misguided feature.  I don't
>>> do that any more for quite some time and didn't miss it yet ;-)
>>
>> Did you rewrite fit-window-to-buffer or do you have another function for
>> this?
>
> I wrote my own windows resizing functions mostly in Elisp.
>
>> Yes, but what it handled was that it prevented a window to grow over
>> the buffers size.
>
> If your concern is that enlarging the window of a temporary buffer can
> delete other windows then doing what you propose would handle just a few
> cases.
>
>> But I do not know why the window grow bigger than the buffer.
>
> The while loop at the end of `fit-window-to-buffer' is not sane.  Here I
> still have it wrapped in a `condition-case' because in some pathological
> cases it can throw an error.


Can't we just throw in a better code instead of fit-window-to-buffer?
(And rename fit-window-to-buffer to killing-window-fit-to-buffer if
someone really wants it.)

It does not have to be perfect. Just good enough. We can surely make
it better later if we need to.





  reply	other threads:[~2010-06-12 14:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09 18:56 bug#6385: A slightly less aggressive fit-window-to-buffer Lennart Borgman
2010-06-11 13:21 ` martin rudalics
2010-06-11 17:15   ` Lennart Borgman
2010-06-12  8:00     ` martin rudalics
2010-06-12 13:03       ` Lennart Borgman
2010-06-12 14:16         ` martin rudalics
2010-06-12 14:24           ` Lennart Borgman [this message]
2010-06-13  7:51             ` martin rudalics
2010-06-13 15:23               ` Lennart Borgman
2010-06-12 15:21       ` Drew Adams
2010-06-13  7:51         ` martin rudalics
2010-06-13 12:39           ` Drew Adams
2010-06-13 14:34             ` martin rudalics
2010-06-13 15:20               ` Lennart Borgman
2010-06-13 17:44                 ` martin rudalics
2010-06-13 17:48                   ` Lennart Borgman
2010-06-13 16:33               ` Drew Adams
2010-06-13 17:45                 ` martin rudalics
2010-06-13 18:21                   ` Drew Adams
2010-06-13 20:04                     ` Stefan Monnier
2010-06-14  6:49                     ` martin rudalics
2010-06-14  6:57                       ` Drew Adams
2011-10-11  9:31 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTilMydlLQ0BwDMstY861rGEQhfQUX6irSBL0DpQt@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=6385@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).