From: Lennart Borgman <lennart.borgman@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 6385@debbugs.gnu.org
Subject: bug#6385: A slightly less aggressive fit-window-to-buffer
Date: Fri, 11 Jun 2010 19:15:25 +0200 [thread overview]
Message-ID: <AANLkTikp3oN1iP33ZASM-uD56fyZG-n1LsIVLljUlGZC@mail.gmail.com> (raw)
In-Reply-To: <4C12383E.5030405@gmx.at>
On Fri, Jun 11, 2010 at 3:21 PM, martin rudalics <rudalics@gmx.at> wrote:
>> I believe fit-window-to-buffer has become a bit upset and unnecessary
>> aggressive because of visual lines. It looks like it need a bit more
>> feedback from the display system to be really sure that the buffer is
>> entirely visible.
>>
>> The attached patch is something I have used to get around the problem.
>> I am not sure it is the right thing but I am rather sure it does not
>> hurt.
>
> IIUC your change defeats the whole point of `pos-visible-in-window-p',
> namely to calculate a position without doing a redisplay.
Yes, I know. I hoped someone had a better idea long term idea. Doing a
redisplay is just a quick fix.
What I saw was the even 2 lines high buffer made fit-window-to-buffer
delete sibling windows. All the time - but... I thought I knew how to
reproduce it. So I did not write any test procedures, I was just a bit
irritated. A mistake.
> Worse even,
> you might end up doing multiple redisplays within a loop.
Yes, I know. Maybe the first redisplay was all that was needed.
> TRT would be to handle the various line cases within `pos_visible_p'.
Thanks, I will leave this for the moment, but keep it in mind.
> And obviously get rid of resizing windows within a loop.
>
>> Of course we need a non-killing version of fit-window-to-buffer, but
>> for the moment this patch might be useful.
>
> What is a "non-killing version of fit-window-to-buffer"?
This function killed all other siblings even if it just actually needs
two lines if certain conditions are met. (Those I tried to describe.)
So this was just a desperate attempt to stop that. I do not know what
to do at the moment. I will try to reproduce this and look a bit
closer at it later.
next prev parent reply other threads:[~2010-06-11 17:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 18:56 bug#6385: A slightly less aggressive fit-window-to-buffer Lennart Borgman
2010-06-11 13:21 ` martin rudalics
2010-06-11 17:15 ` Lennart Borgman [this message]
2010-06-12 8:00 ` martin rudalics
2010-06-12 13:03 ` Lennart Borgman
2010-06-12 14:16 ` martin rudalics
2010-06-12 14:24 ` Lennart Borgman
2010-06-13 7:51 ` martin rudalics
2010-06-13 15:23 ` Lennart Borgman
2010-06-12 15:21 ` Drew Adams
2010-06-13 7:51 ` martin rudalics
2010-06-13 12:39 ` Drew Adams
2010-06-13 14:34 ` martin rudalics
2010-06-13 15:20 ` Lennart Borgman
2010-06-13 17:44 ` martin rudalics
2010-06-13 17:48 ` Lennart Borgman
2010-06-13 16:33 ` Drew Adams
2010-06-13 17:45 ` martin rudalics
2010-06-13 18:21 ` Drew Adams
2010-06-13 20:04 ` Stefan Monnier
2010-06-14 6:49 ` martin rudalics
2010-06-14 6:57 ` Drew Adams
2011-10-11 9:31 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikp3oN1iP33ZASM-uD56fyZG-n1LsIVLljUlGZC@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=6385@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).