From: Juanma Barranquero <lekktu@gmail.com>
To: Wolfgang Schnerring <wosc@wosc.de>
Cc: 6963@debbugs.gnu.org
Subject: bug#6963: More usecases, patch attached
Date: Wed, 29 Sep 2010 17:43:16 +0200 [thread overview]
Message-ID: <AANLkTikakJTZ-irhcrhDowTyHEUbikOWgt2TBkPiEULM@mail.gmail.com> (raw)
In-Reply-To: <20100929150805.GA6325@elzar.ws.whq.gocept.com>
On Wed, Sep 29, 2010 at 17:08, Wolfgang Schnerring <wosc@wosc.de> wrote:
> I personally consider it a bug, since everything else about "errors
> from Emacs" is already there, only the exit status is missing. And
> that really does not play nice with others.
> (That said, this is a gray area, and one could probably also just as
> well argue the opposite.)
I tend to agree with you about it being a bug, but OTOH I try to be
extremely conservative about committing changes into the release
branch, other than typos, docfixes, regression fixes and
very-obviously-correct bugfixes. That's the stated (though not always
followed) policy, and I think it's a very good one.
In this case, the patch changes the behavior of emacsclient, so even
if it fixes a bug, it could still affect users of emacsclient in
non-obvious ways (because, as you do, they could be using emacsclient
from scripts, tools, etc.). So I'd say it's best to keep this for the
trunk.
> It probably makes sense to distinguish these, since they are different
> types of errors, technical ("communication with Emacs failed") vs.
> semantic ("Emacs said boo!").
> One might want to invoke something that has known error cases, which
> would benefit from being treated differently than a socket error or
> somesuch.
I agree, and it doesn't make the patch more complicate (just one more line).
Juanma
next prev parent reply other threads:[~2010-09-29 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 10:16 bug#6963: 23.2; emacsclient -e "(remember-other-frame)" doesn’t give an error-code on error Arne Babenhauserheide
2010-09-29 6:09 ` bug#6963: More usecases, patch attached Wolfgang Schnerring
2010-09-29 7:02 ` Thierry Volpiatto
2010-09-29 14:42 ` Juanma Barranquero
2010-09-29 15:08 ` Wolfgang Schnerring
2010-09-29 15:43 ` Juanma Barranquero [this message]
2010-09-29 18:01 ` Wolfgang Schnerring
2010-09-30 1:52 ` Juanma Barranquero
2010-10-03 0:00 ` Chong Yidong
2010-10-03 0:38 ` Juanma Barranquero
2010-10-03 4:55 ` Chong Yidong
2010-10-03 10:44 ` Juanma Barranquero
2010-10-22 21:23 ` bug#6963: Thank you! Arne Babenhauserheide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikakJTZ-irhcrhDowTyHEUbikOWgt2TBkPiEULM@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=6963@debbugs.gnu.org \
--cc=wosc@wosc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).