bug#6435: Go to eval-buffer: Reading at buffer position

bug#6435: Go to eval-buffer: Reading at buffer position

[Lennart Borgman]

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

A small patch I have forgotten that lets you more conveniently go to
the position where eval-buffer finds an error.

[-- Attachment #2: debug-eval-goto-0.diff --]
[-- Type: text/x-patch, Size: 1285 bytes --]

=== modified file 'lisp/emacs-lisp/debug.el'
--- trunk/lisp/emacs-lisp/debug.el	2010-01-13 08:35:10 +0000
+++ patched/lisp/emacs-lisp/debug.el	2010-06-16 02:44:54 +0000
@@ -317,12 +317,21 @@
       (while (and tem
 		  (re-search-forward "^  eval-\\(buffer\\|region\\)(" nil t))
 	(end-of-line)
-	(insert (format "  ; Reading at buffer position %d"
+	(insert "  ; Reading at buffer position ")
+        (let* ((buf (car tem))
 			;; This will get the wrong result
 			;; if there are two nested eval-region calls
 			;; for the same buffer.  That's not a very useful case.
-			(with-current-buffer (car tem)
-			  (point))))
+               (pos (with-current-buffer buf (point))))
+          (insert-text-button (format "%d" pos)
+                              'buf buf
+                              'pos pos
+                              'action (lambda (btn)
+                                        (interactive)
+                                        (let ((buf (button-get btn 'buf))
+                                              (pos (button-get btn 'pos)))
+                                          (switch-to-buffer-other-window buf)
+                                          (goto-char pos)))))
 	(pop tem))))
   (debugger-make-xrefs))
 

bug#6435: Go to eval-buffer: Reading at buffer position

[Gemini Lasswell]

tags 6435 fixed
close 6435 27.1

Lennart Borgman <lennart.borgman@gmail.com> writes:

> A small patch I have forgotten that lets you more conveniently go to
> the position where eval-buffer finds an error.

Hi Lennart,

I didn't use your patch, but included with the backtrace-mode changes
which I have just pushed to master is a similar change to add links to
the reading positions of eval-buffer and eval-region when they occur in
backtraces.

Gemini