unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Keitaro Miyazaki <keitaro.miyazaki@gmail.com>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 7282@debbugs.gnu.org
Subject: bug#7282: 23.2; [PATCH] Improve text composition by Input Methods on MacOSX.
Date: Thu, 28 Oct 2010 15:15:54 +0900	[thread overview]
Message-ID: <AANLkTikQ71OcUkD_WSyMkbP=ZwwJovf4iSwqHCSmXu5+@mail.gmail.com> (raw)
In-Reply-To: <wl39rrt9ti.wl%mituharu@math.s.chiba-u.ac.jp>

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Do you mean that there are some cases that the number of characters in
a string, in other words, the length of a string, is different from
the one counted by NSString to the one counted by Emacs?

If so, could you show me any example of these cases?


> Also, selected range handling is not enough for the following case:

Thank you for pointing that out.
I made an attached patch which may fix this problem
by moving cursor in composing text.

Apply this patch after applying my previous patch.

[-- Attachment #2: im-cursor-position-fix.diff --]
[-- Type: application/octet-stream, Size: 671 bytes --]

--- emacs-23.2/lisp/term/ns-win.el.orig	2010-10-28 14:57:50.000000000 +0900
+++ emacs-23.2/lisp/term/ns-win.el	2010-10-28 14:58:18.000000000 +0900
@@ -611,7 +611,8 @@ The overlay is assigned the face `ns-wor
                        (make-overlay (+ start (car ns-range-of-active-clause))
                                      (+ start (cdr ns-range-of-active-clause))
                                      nil t))
-                 'face 'ns-active-clause-face)))
+                 'face 'ns-active-clause-face)
+    (goto-char (+ start (cdr ns-range-of-active-clause)))))
 
 (defun ns-echo-working-text ()
   "Echo contents of `ns-working-text' in message display area.

  reply	other threads:[~2010-10-28  6:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 12:20 bug#7282: 23.2; [PATCH] Improve text composition by Input Methods on MacOSX Keitaro Miyazaki
2010-10-27  5:46 ` YAMAMOTO Mitsuharu
2010-10-27  6:17   ` YAMAMOTO Mitsuharu
2010-10-27 14:56     ` Keitaro Miyazaki
2010-10-28  0:55       ` YAMAMOTO Mitsuharu
2010-10-28  6:15         ` Keitaro Miyazaki [this message]
2010-10-28  6:35           ` YAMAMOTO Mitsuharu
2010-10-28 15:31             ` Keitaro Miyazaki
2016-07-10 15:15               ` Alan Third
2017-12-27  0:14                 ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikQ71OcUkD_WSyMkbP=ZwwJovf4iSwqHCSmXu5+@mail.gmail.com' \
    --to=keitaro.miyazaki@gmail.com \
    --cc=7282@debbugs.gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).