From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Key Newsgroups: gmane.emacs.bugs Subject: bug#8181: 23.2; Dired on Windows 7 Date: Mon, 7 Mar 2011 10:19:19 -0600 Message-ID: References: <4D72BF5D.20403@comcast.net> <87ei6jdmt3.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=00032555a4aac64163049de6dee1 X-Trace: dough.gmane.org 1299515835 2399 80.91.229.12 (7 Mar 2011 16:37:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2011 16:37:15 +0000 (UTC) Cc: Juanma Barranquero , 8181@debbugs.gnu.org To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 07 17:37:05 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PwdQe-0003k8-DX for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2011 17:37:04 +0100 Original-Received: from localhost ([127.0.0.1]:59166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwdQd-0004sM-Ha for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2011 11:37:03 -0500 Original-Received: from [140.186.70.92] (port=35355 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwdQU-0004rI-3h for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2011 11:36:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwdQS-000145-P2 for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2011 11:36:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwdQS-00013r-M9 for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2011 11:36:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PwdB8-00085k-SV; Mon, 07 Mar 2011 11:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ben Key Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Mar 2011 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8181 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8181-submit@debbugs.gnu.org id=B8181.129951482231048 (code B ref 8181); Mon, 07 Mar 2011 16:21:02 +0000 Original-Received: (at 8181) by debbugs.gnu.org; 7 Mar 2011 16:20:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwdAT-00084i-6n for submit@debbugs.gnu.org; Mon, 07 Mar 2011 11:20:21 -0500 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwdAQ-00084N-Rq for 8181@debbugs.gnu.org; Mon, 07 Mar 2011 11:20:19 -0500 Original-Received: by bwz13 with SMTP id 13so3933419bwz.3 for <8181@debbugs.gnu.org>; Mon, 07 Mar 2011 08:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=GNiOs1tNrrn+TR1wOq4RGbvR17wmm1U4vguxhU8mio4=; b=pc4bw0V3D5FX8ZMu4vyyhGkj0IXlISjbRm7AYQzPy/grQM60evPHLHpQo8F52xg3aK zZb3d7m/kd+If2Ob6SYHQ4sB+nMAiUKCVxDD1BeXFpQgFQqnEHmNaqjJ2lMHfRLtPPxi 7VmPPfp/pyO9/Ho2pBLqu1LlIPJbE6IdfMKVw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=GxWCj73b2bAv8X4ND4kyVu5hrcdxmJ3x3e+6+aZw8DHrXGrYptUkCAuF5YuxaF5G9c sfjmad2p2IKBhyUfMSidLjsR9DuKDcsSg+YYLmYeWebhWh5p2XBCAJzfSfh0AK5C7XjA J6eknIxro6R3oOWgQKS8V6o3H4RBpopEmmIE8= Original-Received: by 10.204.22.194 with SMTP id o2mr2061681bkb.67.1299514812416; Mon, 07 Mar 2011 08:20:12 -0800 (PST) Original-Received: by 10.204.14.147 with HTTP; Mon, 7 Mar 2011 08:19:19 -0800 (PST) In-Reply-To: <87ei6jdmt3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 07 Mar 2011 11:21:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44747 Archived-At: --00032555a4aac64163049de6dee1 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Mar 7, 2011 at 8:31 AM, Jason Rumney wrote: > > Has Microsoft changed the names of these fields in Windows 7, or is it > some new "security" feature getting in the way of changing this dialog > programmatically? > Hello, Note that a patch to fix the issue has already been submitted by my and improved upon by Juanma Barranquero. See the messages < http://lists.gnu.org/archive/html/bug-gnu-emacs/2011-03/msg00270.html> and for more details. The cause of the problem that prevented Emacs from being able to set the initial value of the file name text field was a result of the fact that the code that processes the lpstrFile member of the OPENFILENAME structure to set the initial value of the window is now called after the CDN_INITDONE WM_NOTIFY message is processed. Since lpstrFile was set to an empty string, this caused the text to be removed from the window after it was set. The fix for that was to set lpstrFile to "Current Directory" in the only_dir_p case. The cause of the problem that caused Emacs to be unable to disable the edit window was simply a change in the window hierarchy of the File Open dialog box since the bad old Windows 95 days. The patches resolve both issues. Note that only the latest patch by Juanma Barranquero should be committed. --00032555a4aac64163049de6dee1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Mon, Mar 7, 2011 at 8:31 AM, Jason Rumney <jasonr@gnu.org>= wrote:

Has Microsoft changed the names of these fields in Windows 7, or is i= t
some new "security" feature getting in the way of changing this d= ialog
programmatically?

Hello,

Note that a patch to = fix the issue has already been submitted by my and improved upon by Juanma = Barranquero.=A0 See the messages <http://lists.gnu.org/archive/ht= ml/bug-gnu-emacs/2011-03/msg00270.html>=A0 and <http://lis= ts.gnu.org/archive/html/bug-gnu-emacs/2011-03/msg00269.html> for mor= e details.

The cause of the problem that prevented Emacs from being able to set th= e initial value of the file name text field was a r= esult of the fact that the code that processes the = lpstrFile member of the=20 OPENFILENAME structure to set the initial value of the window is now called= =20 after the CDN_INITDONE WM_NOTIFY message is process= ed.=A0 Since lpstrFile was set to an empty string, = this caused the text to be removed from the window after it was set.=A0 The= fix for that was to set lpstrFile to "Current= Directory" in the only_dir_p case.

The cause of the problem that caused Emacs to be unable to disable the = edit window was simply a change in the window hierarchy of the File Open di= alog box since the bad old Windows 95 days.

The patches resolve both= issues.=A0 Note that only the latest patch by Juan= ma Barranquero should be committed.

 --00032555a4aac64163049de6dee1--