unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Key <bkey76@gmail.com>
To: Jason Rumney <jasonr@gnu.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, 8181@debbugs.gnu.org
Subject: bug#8181: 23.2; Dired on Windows 7
Date: Mon, 7 Mar 2011 10:19:19 -0600	[thread overview]
Message-ID: <AANLkTikJ8qBE973CtXWkg0rGPeb2atAkSHkEsOYyTKYb@mail.gmail.com> (raw)
In-Reply-To: <87ei6jdmt3.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Mon, Mar 7, 2011 at 8:31 AM, Jason Rumney <jasonr@gnu.org> wrote:

>
> Has Microsoft changed the names of these fields in Windows 7, or is it
> some new "security" feature getting in the way of changing this dialog
> programmatically?
>

Hello,

Note that a patch to fix the issue has already been submitted by my and
improved upon by Juanma Barranquero.  See the messages <
http://lists.gnu.org/archive/html/bug-gnu-emacs/2011-03/msg00270.html>  and
<http://lists.gnu.org/archive/html/bug-gnu-emacs/2011-03/msg00269.html> for
more details.

The cause of the problem that prevented Emacs from being able to set the
initial value of the file name text field was a result of the fact that the
code that processes the lpstrFile member of the OPENFILENAME structure to
set the initial value of the window is now called after the CDN_INITDONE
WM_NOTIFY message is processed.  Since lpstrFile was set to an empty string,
this caused the text to be removed from the window after it was set.  The
fix for that was to set lpstrFile to "Current Directory" in the only_dir_p
case.

The cause of the problem that caused Emacs to be unable to disable the edit
window was simply a change in the window hierarchy of the File Open dialog
box since the bad old Windows 95 days.

The patches resolve both issues.  Note that only the latest patch by Juanma
Barranquero should be committed.

[-- Attachment #2: Type: text/html, Size: 2056 bytes --]

  reply	other threads:[~2011-03-07 16:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  4:15 bug#8191: Patch to fix bug#8181: 23.2; Dired on Windows 7 Ben Key
2011-03-07  5:37 ` bug#8181: " Juanma Barranquero
2011-03-07 15:56   ` Ben Key
2011-03-07 18:06     ` Juanma Barranquero
2011-03-07 19:54       ` Juanma Barranquero
2011-03-07 20:16         ` Chong Yidong
2011-03-07 20:24           ` Juanma Barranquero
2011-03-07 20:59             ` Chong Yidong
2011-03-07 21:17               ` Juanma Barranquero
2011-03-05 22:55                 ` Robert I. Eachus
2011-03-06  0:08                   ` Lennart Borgman
2011-03-06  0:40                     ` Robert I. Eachus
2011-03-06  0:42                       ` Lennart Borgman
2011-03-06  3:30                       ` Juanma Barranquero
2011-03-07 14:19                         ` Jason Rumney
2011-03-06 13:14                   ` Dani Moncayo
2011-03-06 14:17                     ` Eli Zaretskii
2011-03-06 16:04                   ` Ben Key
2011-03-06 20:28                     ` Juanma Barranquero
2011-03-07 14:31                       ` Jason Rumney
2011-03-07 16:19                         ` Ben Key [this message]
2011-03-07 18:09                         ` Juanma Barranquero
2011-03-07 23:04                           ` Jason Rumney
2011-03-07 14:28                     ` Jason Rumney
     [not found]                   ` <handler.8181.D8181.129953268524792.notifdone@debbugs.gnu.org>
2011-03-08  1:58                     ` bug#8181: closed (Re: bug#8181: Patch to fix bug#8181: 23.2; Dired on Windows 7) Robert I. Eachus
2011-03-08  2:24                       ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikJ8qBE973CtXWkg0rGPeb2atAkSHkEsOYyTKYb@mail.gmail.com \
    --to=bkey76@gmail.com \
    --cc=8181@debbugs.gnu.org \
    --cc=jasonr@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).